From: "Ville Syrjälä" <ville.syrjala@intel.com>
To: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Peres, Martin" <martin.peres@intel.com>
Subject: Re: [PATCH v3] drm/i915: Restrict qgv points which don't have enough bandwidth.
Date: Mon, 14 Oct 2019 17:50:18 +0300 [thread overview]
Message-ID: <20191014145018.GV1208@intel.com> (raw)
In-Reply-To: <dd75af7e26d67fa4fb160cf58ab6d71ae53cfa10.camel@intel.com>
On Mon, Oct 14, 2019 at 02:13:31PM +0300, Lisovskiy, Stanislav wrote:
> On Fri, 2019-10-11 at 16:49 -0700, James Ausmus wrote:
> > > + new_qgv_points_mask |= new_mask_bit;
> > > + }
> > > +
> > > + ret = icl_pcode_restrict_qgv_points(dev_priv,
> > > new_qgv_points_mask);
> > > + if (ret < 0)
> > > + DRM_DEBUG_KMS("Could not restrict required gqv
> > > points(%d)\n", ret);
> >
> > s/gqv/qgv/
> >
> >
> > Also, if we fail masking off the qgv points that can't support our BW
> > req, shouldn't we handle that failure somehow - maybe just disable
> > SAGV
> > entirely? Better we lose power than have flickering screens...
Sounds like dead code to me. My approach is: don't deal with hw/firmware
failures until they are proven to exist.
The debug msg should be an error so that we get a bug report if this
ever happens.
--
Ville Syrjälä
Intel
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-14 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:17 [PATCH v3] drm/i915: Restrict qgv points which don't have enough bandwidth Stanislav Lisovskiy
2019-09-25 14:28 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Restrict qgv points which don't have enough bandwidth. (rev3) Patchwork
2019-09-25 15:01 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-26 6:02 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-11 23:49 ` [PATCH v3] drm/i915: Restrict qgv points which don't have enough bandwidth James Ausmus
2019-10-14 11:13 ` Lisovskiy, Stanislav
2019-10-14 14:50 ` Ville Syrjälä [this message]
2019-10-14 16:33 ` James Ausmus
2019-10-14 16:46 ` Ville Syrjälä
2019-10-14 16:32 ` James Ausmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014145018.GV1208@intel.com \
--to=ville.syrjala@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox