From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, tglx@linutronix.de,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't disable interrupts independently of the lock
Date: Mon, 14 Oct 2019 18:10:00 +0200 [thread overview]
Message-ID: <20191014160959.j55o7owd42qedknt@linutronix.de> (raw)
In-Reply-To: <157073943519.31572.16175211768966306500@skylake-alporthouse-com>
On 2019-10-10 21:30:35 [+0100], Chris Wilson wrote:
> > | spin_lock_irq(&rq->engine->active.lock);
> > | list_del(&rq->sched.link);
> > | spin_unlock_irq(&rq->engine->active.lock);
> > |
> > | spin_lock_irq(&rq->lock);
> > | i915_request_mark_complete(rq);
> > …
> > | spin_unlock_irq(&rq->lock);
> >
> > has been avoided because an interrupt here could change something or if
> > this is just an optimisation.
>
> Just avoiding the back-to-back enable/disable.
as I assumed. Is the patch okay?
> -Chris
Sebastian
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-14 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:06 [PATCH] drm/i915: Don't disable interrupts independently of the lock Sebastian Andrzej Siewior
2019-10-10 18:11 ` [Intel-gfx] " Chris Wilson
2019-10-10 18:26 ` Sebastian Andrzej Siewior
2019-10-10 20:30 ` [Intel-gfx] " Chris Wilson
2019-10-14 16:10 ` Sebastian Andrzej Siewior [this message]
2019-10-10 19:22 ` ✗ Fi.CI.BUILD: failure for drm/i915: Don't disable interrupts independently of the lock (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-04-10 14:24 [PATCH] drm/i915: Don't disable interrupts independently of the lock Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014160959.j55o7owd42qedknt@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox