Re: [PATCH] drm/i915: Do initial mocs configuration directly

["Kumar Valsan, Prathap" <prathap.kumar.valsan@intel.com>]

On Wed, Oct 16, 2019 at 10:07:49AM +0100, Chris Wilson wrote:
> Now that we record the default "goldenstate" context, we do not need to
> emit the mocs registers at the start of each context and can simply do
> mmio before the first context and capture the registers as part of its
> default image. As a consequence, this means that we repeat the mmio
> after each engine reset, fixing up any platform and registers that were
> zapped by the reset (for those platforms with global not context-saved
> settings).
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=111723
> References: https://bugs.freedesktop.org/show_bug.cgi?id=111645
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Prathap Kumar Valsan <prathap.kumar.valsan@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_mocs.c | 281 +++++++--------------------
>  drivers/gpu/drm/i915/gt/intel_mocs.h |   3 -
>  drivers/gpu/drm/i915/i915_gem.c      |   9 -
>  3 files changed, 73 insertions(+), 220 deletions(-)
> 
> +/**
> + * intel_mocs_init_engine() - emit the mocs control table
> + * @engine:	The engine for whom to emit the registers.
> + *
> + * This function simply emits a MI_LOAD_REGISTER_IMM command for the
This function description  needs a fix as we don't emit the mocs now.

Reviewed-by: Prathap Kumar Valsan <prathap.kumar.valsan@intel.com>


> + * given table starting at the given address.
> + */
> +void intel_mocs_init_engine(struct intel_engine_cs *engine)
>  {
> -- 
> 2.23.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx