From: Ramalingam C <ramalingam.c@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: s/hdcp2_hdmi_msg_data/hdcp2_hdmi_msg_timeout/
Date: Thu, 17 Oct 2019 12:25:38 +0530 [thread overview]
Message-ID: <20191017065538.GA4730@intel.com> (raw)
In-Reply-To: <20191010145127.7487-2-ville.syrjala@linux.intel.com>
On 2019-10-10 at 17:51:24 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The array is there only for timeout, "data" doesn't mean anything
> so let's rename the thing to be more descriptive.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Looks good to me.
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 0a6846c5ba95..13c588ae88a4 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1527,13 +1527,13 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
> return true;
> }
>
> -struct hdcp2_hdmi_msg_data {
> +struct hdcp2_hdmi_msg_timeout {
> u8 msg_id;
> u32 timeout;
> u32 timeout2;
> };
>
> -static const struct hdcp2_hdmi_msg_data hdcp2_msg_data[] = {
> +static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = {
> { HDCP_2_2_AKE_INIT, 0, 0 },
> { HDCP_2_2_AKE_SEND_CERT, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
> { HDCP_2_2_AKE_NO_STORED_KM, 0, 0 },
> @@ -1564,12 +1564,12 @@ static int get_hdcp2_msg_timeout(u8 msg_id, bool is_paired)
> {
> int i;
>
> - for (i = 0; i < ARRAY_SIZE(hdcp2_msg_data); i++)
> - if (hdcp2_msg_data[i].msg_id == msg_id &&
> + for (i = 0; i < ARRAY_SIZE(hdcp2_msg_timeout); i++)
> + if (hdcp2_msg_timeout[i].msg_id == msg_id &&
> (msg_id != HDCP_2_2_AKE_SEND_HPRIME || is_paired))
> - return hdcp2_msg_data[i].timeout;
> - else if (hdcp2_msg_data[i].msg_id == msg_id)
> - return hdcp2_msg_data[i].timeout2;
> + return hdcp2_msg_timeout[i].timeout;
> + else if (hdcp2_msg_timeout[i].msg_id == msg_id)
> + return hdcp2_msg_timeout[i].timeout2;
>
> return -EINVAL;
> }
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-17 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:51 [PATCH 1/5] drm/i915: Shrink eDRAM ways/sets arrays Ville Syrjala
2019-10-10 14:51 ` [PATCH 2/5] drm/i915: s/hdcp2_hdmi_msg_data/hdcp2_hdmi_msg_timeout/ Ville Syrjala
2019-10-17 6:55 ` Ramalingam C [this message]
2019-10-10 14:51 ` [PATCH 3/5] drm/i915: Remove dead weight from hdcp2_msg_timeout[] Ville Syrjala
2019-10-17 7:02 ` Ramalingam C
2019-10-10 14:51 ` [PATCH 4/5] drm/i915: Remove hdcp2_hdmi_msg_timeout.timeout2 Ville Syrjala
2019-10-17 7:05 ` Ramalingam C
2019-10-10 14:51 ` [PATCH 5/5] drm/i915: Make hdcp2_msg_timeout.timeout u16 Ville Syrjala
2019-10-17 7:08 ` Ramalingam C
2019-10-10 16:57 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Shrink eDRAM ways/sets arrays Patchwork
2019-10-17 7:58 ` [PATCH 1/5] " Ramalingam C
2019-10-17 12:54 ` Ville Syrjälä
2019-10-17 13:26 ` Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017065538.GA4730@intel.com \
--to=ramalingam.c@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).