From: Ramalingam C <ramalingam.c@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/i915: Remove dead weight from hdcp2_msg_timeout[]
Date: Thu, 17 Oct 2019 12:32:35 +0530 [thread overview]
Message-ID: <20191017070235.GB4730@intel.com> (raw)
In-Reply-To: <20191010145127.7487-3-ville.syrjala@linux.intel.com>
On 2019-10-10 at 17:51:25 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The .read_2_2() hooks is never called for any of the message
> types with a zero timeout. So it's all just dead weight which
> we can chuck.
>
> text data bss dec hex filename
> - 34701 360 0 35061 88f5 intel_hdmi.o
> + 34633 360 0 34993 88b1 intel_hdmi.o
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Timeout is added for supporting msgs read. These msgs with 0 timeout
are only written. Hence can be removed from the timeout table.
Reviwed-by: Ramalingam C < ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 13c588ae88a4..8a574be86bc6 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1534,19 +1534,12 @@ struct hdcp2_hdmi_msg_timeout {
> };
>
> static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = {
> - { HDCP_2_2_AKE_INIT, 0, 0 },
> { HDCP_2_2_AKE_SEND_CERT, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
> - { HDCP_2_2_AKE_NO_STORED_KM, 0, 0 },
> - { HDCP_2_2_AKE_STORED_KM, 0, 0 },
> { HDCP_2_2_AKE_SEND_HPRIME, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
> { HDCP_2_2_AKE_SEND_PAIRING_INFO, HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
> - { HDCP_2_2_LC_INIT, 0, 0 },
> { HDCP_2_2_LC_SEND_LPRIME, HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS, 0 },
> - { HDCP_2_2_SKE_SEND_EKS, 0, 0 },
> { HDCP_2_2_REP_SEND_RECVID_LIST, HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
> - { HDCP_2_2_REP_SEND_ACK, 0, 0 },
> - { HDCP_2_2_REP_STREAM_MANAGE, 0, 0 },
> { HDCP_2_2_REP_STREAM_READY, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
> };
>
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-17 7:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:51 [PATCH 1/5] drm/i915: Shrink eDRAM ways/sets arrays Ville Syrjala
2019-10-10 14:51 ` [PATCH 2/5] drm/i915: s/hdcp2_hdmi_msg_data/hdcp2_hdmi_msg_timeout/ Ville Syrjala
2019-10-17 6:55 ` Ramalingam C
2019-10-10 14:51 ` [PATCH 3/5] drm/i915: Remove dead weight from hdcp2_msg_timeout[] Ville Syrjala
2019-10-17 7:02 ` Ramalingam C [this message]
2019-10-10 14:51 ` [PATCH 4/5] drm/i915: Remove hdcp2_hdmi_msg_timeout.timeout2 Ville Syrjala
2019-10-17 7:05 ` Ramalingam C
2019-10-10 14:51 ` [PATCH 5/5] drm/i915: Make hdcp2_msg_timeout.timeout u16 Ville Syrjala
2019-10-17 7:08 ` Ramalingam C
2019-10-10 16:57 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Shrink eDRAM ways/sets arrays Patchwork
2019-10-17 7:58 ` [PATCH 1/5] " Ramalingam C
2019-10-17 12:54 ` Ville Syrjälä
2019-10-17 13:26 ` Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017070235.GB4730@intel.com \
--to=ramalingam.c@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).