From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/14] drm/i915: Rework watermark readout to use plane api Date: Thu, 17 Oct 2019 16:37:49 +0300 Message-ID: <20191017133749.GU1208@intel.com> References: <20191017132105.15528-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38B9B6E489 for ; Thu, 17 Oct 2019 13:37:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191017132105.15528-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTcsIDIwMTkgYXQgMDM6MjA6NTJQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSW5zdGVhZCBvZiB1bmNvbmRpdGlvbmFsbHkgdmVyaWZ5aW5nIHRoZSBjdXJz b3IgcGxhbmUsIGhhbmRsZSBpdCBpbiB0aGUKPiBzYW1lIHdheSBhcyBhbnkgb3RoZXIgcGxhbmUs IGFuZCB1c2Ugb3VyIGV4aXN0aW5nIGFwaSB0byB2ZXJpZnkuCj4gCj4gV2hpbGUgYXQgaXQsIGVu c3VyZSB0aGF0IG9uIGdlbjkrIHdlIHZlcmlmeSBhY3RpdmVfcGxhbmVzIG1hc2sgYXMgd2VsbC4K PiBUaGlzIHNob3VsZCBnaXZlIHRoZSBjb3JyZWN0IHJlc3VsdHMgZm9yIHBsYW5hciBZVVYgcGxh bmVzIHRvbywgYXMgd2UKPiB1cGRhdGUgYWN0aXZlX3BsYW5lcyBmb3IgdGhlbS4KCldoeSBpcyB0 aGF0IGhpZGRlbiBpbiB0aGUgd2F0ZXJtYXJrIHZlcmlmaWNhdGlvbiBjb2RlPyBXZSBhbHJlYWR5 IGhhdmUKaW50ZWxfdmVyaWZ5X3BsYW5lcygpIHdoaWNoIHNlZW1zIGxpa2UgYSBiZXR0ZXIgZml0 LgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9y c3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2Rpc3BsYXkuYyB8IDgzICsrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCA2MCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDE2NGRlZDg2MjE0OC4u OTQ1YWIyMTgwNjE0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kaXNwbGF5LmMKPiBAQCAtMTI5MzIsNyArMTI5MzIsOCBAQCBzdGF0aWMgdm9pZCB2ZXJpZnlf d21fc3RhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAlzdHJ1Y3Qgc2tsX3BpcGVfd20g KnN3X3dtOwo+ICAJc3RydWN0IHNrbF9kZGJfZW50cnkgKmh3X2RkYl9lbnRyeSwgKnN3X2RkYl9l bnRyeTsKPiAgCWNvbnN0IGVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlwZTsKPiAtCWludCBwbGFu ZSwgbGV2ZWwsIG1heF9sZXZlbCA9IGlsa193bV9tYXhfbGV2ZWwoZGV2X3ByaXYpOwo+ICsJaW50 IGxldmVsLCBtYXhfbGV2ZWwgPSBpbGtfd21fbWF4X2xldmVsKGRldl9wcml2KTsKPiArCXN0cnVj dCBpbnRlbF9wbGFuZSAqcGxhbmU7Cj4gIAo+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5 IHx8ICFuZXdfY3J0Y19zdGF0ZS0+YmFzZS5hY3RpdmUpCj4gIAkJcmV0dXJuOwo+IEBAIC0xMjk1 Niw2MyArMTI5NTcsMjUgQEAgc3RhdGljIHZvaWQgdmVyaWZ5X3dtX3N0YXRlKHN0cnVjdCBpbnRl bF9jcnRjICpjcnRjLAo+ICAJCQkgIGh3LT5kZGIuZW5hYmxlZF9zbGljZXMpOwo+ICAKPiAgCS8q IHBsYW5lcyAqLwo+IC0JZm9yX2VhY2hfdW5pdmVyc2FsX3BsYW5lKGRldl9wcml2LCBwaXBlLCBw bGFuZSkgewo+ICsJZm9yX2VhY2hfaW50ZWxfcGxhbmVfb25fY3J0YygmZGV2X3ByaXYtPmRybSwg Y3J0YywgcGxhbmUpIHsKPiAgCQlzdHJ1Y3Qgc2tsX3BsYW5lX3dtICpod19wbGFuZV93bSwgKnN3 X3BsYW5lX3dtOwo+ICsJCWVudW0gcGlwZSBwbGFuZV9waXBlID0gcGlwZTsKPiAgCj4gLQkJaHdf cGxhbmVfd20gPSAmaHctPndtLnBsYW5lc1twbGFuZV07Cj4gLQkJc3dfcGxhbmVfd20gPSAmc3df d20tPnBsYW5lc1twbGFuZV07Cj4gLQo+IC0JCS8qIFdhdGVybWFya3MgKi8KPiAtCQlmb3IgKGxl dmVsID0gMDsgbGV2ZWwgPD0gbWF4X2xldmVsOyBsZXZlbCsrKSB7Cj4gLQkJCWlmIChza2xfd21f bGV2ZWxfZXF1YWxzKCZod19wbGFuZV93bS0+d21bbGV2ZWxdLAo+IC0JCQkJCQkmc3dfcGxhbmVf d20tPndtW2xldmVsXSkpCj4gLQkJCQljb250aW51ZTsKPiAtCj4gLQkJCURSTV9FUlJPUigibWlz bWF0Y2ggaW4gV00gcGlwZSAlYyBwbGFuZSAlZCBsZXZlbCAlZCAoZXhwZWN0ZWQgZT0lZCBiPSV1 IGw9JXUsIGdvdCBlPSVkIGI9JXUgbD0ldSlcbiIsCj4gLQkJCQkgIHBpcGVfbmFtZShwaXBlKSwg cGxhbmUgKyAxLCBsZXZlbCwKPiAtCQkJCSAgc3dfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9l biwKPiAtCQkJCSAgc3dfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfYiwKPiAtCQkJCSAg c3dfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfbCwKPiAtCQkJCSAgaHdfcGxhbmVfd20t PndtW2xldmVsXS5wbGFuZV9lbiwKPiAtCQkJCSAgaHdfcGxhbmVfd20tPndtW2xldmVsXS5wbGFu ZV9yZXNfYiwKPiAtCQkJCSAgaHdfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfbCk7Cj4g LQkJfQo+ICsJCWh3X3BsYW5lX3dtID0gJmh3LT53bS5wbGFuZXNbcGxhbmUtPmlkXTsKPiArCQlz d19wbGFuZV93bSA9ICZzd193bS0+cGxhbmVzW3BsYW5lLT5pZF07Cj4gIAo+IC0JCWlmICghc2ts X3dtX2xldmVsX2VxdWFscygmaHdfcGxhbmVfd20tPnRyYW5zX3dtLAo+IC0JCQkJCSAmc3dfcGxh bmVfd20tPnRyYW5zX3dtKSkgewo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIHRyYW5zIFdN IHBpcGUgJWMgcGxhbmUgJWQgKGV4cGVjdGVkIGU9JWQgYj0ldSBsPSV1LCBnb3QgZT0lZCBiPSV1 IGw9JXUpXG4iLAo+IC0JCQkJICBwaXBlX25hbWUocGlwZSksIHBsYW5lICsgMSwKPiAtCQkJCSAg c3dfcGxhbmVfd20tPnRyYW5zX3dtLnBsYW5lX2VuLAo+IC0JCQkJICBzd19wbGFuZV93bS0+dHJh bnNfd20ucGxhbmVfcmVzX2IsCj4gLQkJCQkgIHN3X3BsYW5lX3dtLT50cmFuc193bS5wbGFuZV9y ZXNfbCwKPiAtCQkJCSAgaHdfcGxhbmVfd20tPnRyYW5zX3dtLnBsYW5lX2VuLAo+IC0JCQkJICBo d19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVfcmVzX2IsCj4gLQkJCQkgIGh3X3BsYW5lX3dtLT50 cmFuc193bS5wbGFuZV9yZXNfbCk7Cj4gLQkJfQo+IC0KPiAtCQkvKiBEREIgKi8KPiAtCQlod19k ZGJfZW50cnkgPSAmaHctPmRkYl95W3BsYW5lXTsKPiAtCQlzd19kZGJfZW50cnkgPSAmbmV3X2Ny dGNfc3RhdGUtPndtLnNrbC5wbGFuZV9kZGJfeVtwbGFuZV07Cj4gLQo+IC0JCWlmICghc2tsX2Rk Yl9lbnRyeV9lcXVhbChod19kZGJfZW50cnksIHN3X2RkYl9lbnRyeSkpIHsKPiAtCQkJRFJNX0VS Uk9SKCJtaXNtYXRjaCBpbiBEREIgc3RhdGUgcGlwZSAlYyBwbGFuZSAlZCAoZXhwZWN0ZWQgKCV1 LCV1KSwgZm91bmQgKCV1LCV1KSlcbiIsCj4gLQkJCQkgIHBpcGVfbmFtZShwaXBlKSwgcGxhbmUg KyAxLAo+IC0JCQkJICBzd19kZGJfZW50cnktPnN0YXJ0LCBzd19kZGJfZW50cnktPmVuZCwKPiAt CQkJCSAgaHdfZGRiX2VudHJ5LT5zdGFydCwgaHdfZGRiX2VudHJ5LT5lbmQpOwo+ICsJCWlmICgh cGxhbmUtPmdldF9od19zdGF0ZShwbGFuZSwgJnBsYW5lX3BpcGUpKSB7Cj4gKwkJCVdBUk4obmV3 X2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMgJiBCSVQocGxhbmUtPmlkKSwKPiArCQkJICAgICAi cGlwZSAlYyAlcyBzaG91bGQgYmUgdmlzaWJsZSwgYnV0IGlzbid0XG4iLAo+ICsJCQkgICAgIHBp cGVfbmFtZShwaXBlKSwgcGxhbmUtPmJhc2UubmFtZSk7Cj4gKwkJCWNvbnRpbnVlOwo+ICAJCX0K PiAtCX0KPiAgCj4gLQkvKgo+IC0JICogY3Vyc29yCj4gLQkgKiBJZiB0aGUgY3Vyc29yIHBsYW5l IGlzbid0IGFjdGl2ZSwgd2UgbWF5IG5vdCBoYXZlIHVwZGF0ZWQgaXQncyBkZGIKPiAtCSAqIGFs bG9jYXRpb24uIEluIHRoYXQgY2FzZSBzaW5jZSB0aGUgZGRiIGFsbG9jYXRpb24gd2lsbCBiZSB1 cGRhdGVkCj4gLQkgKiBvbmNlIHRoZSBwbGFuZSBiZWNvbWVzIHZpc2libGUsIHdlIGNhbiBza2lw IHRoaXMgY2hlY2sKPiAtCSAqLwo+IC0JaWYgKDEpIHsKPiAtCQlzdHJ1Y3Qgc2tsX3BsYW5lX3dt ICpod19wbGFuZV93bSwgKnN3X3BsYW5lX3dtOwo+ICsJCVdBUk5fT04ocGxhbmVfcGlwZSAhPSBw aXBlKTsKPiAgCj4gLQkJaHdfcGxhbmVfd20gPSAmaHctPndtLnBsYW5lc1tQTEFORV9DVVJTT1Jd Owo+IC0JCXN3X3BsYW5lX3dtID0gJnN3X3dtLT5wbGFuZXNbUExBTkVfQ1VSU09SXTsKPiArCQlX QVJOKCEobmV3X2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMgJiBCSVQocGxhbmUtPmlkKSksCj4g KwkJICAgICAicGlwZSAlYyAlcyBzaG91bGQgYmUgaW52aXNpYmxlLCBidXQgdmlzaWJsZS5cbiIs Cj4gKwkJICAgICBwaXBlX25hbWUocGlwZSksIHBsYW5lLT5iYXNlLm5hbWUpOwo+ICAKPiAgCQkv KiBXYXRlcm1hcmtzICovCj4gIAkJZm9yIChsZXZlbCA9IDA7IGxldmVsIDw9IG1heF9sZXZlbDsg bGV2ZWwrKykgewo+IEBAIC0xMzAyMCw4ICsxMjk4Myw4IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93 bV9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQkJCQkJJnN3X3BsYW5lX3dtLT53 bVtsZXZlbF0pKQo+ICAJCQkJY29udGludWU7Cj4gIAo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNo IGluIFdNIHBpcGUgJWMgY3Vyc29yIGxldmVsICVkIChleHBlY3RlZCBlPSVkIGI9JXUgbD0ldSwg Z290IGU9JWQgYj0ldSBsPSV1KVxuIiwKPiAtCQkJCSAgcGlwZV9uYW1lKHBpcGUpLCBsZXZlbCwK PiArCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiBXTSBwaXBlICVjICVzIGxldmVsICVkIChleHBl Y3RlZCBlPSVkIGI9JXUgbD0ldSwgZ290IGU9JWQgYj0ldSBsPSV1KVxuIiwKPiArCQkJCSAgcGlw ZV9uYW1lKHBpcGUpLCBwbGFuZS0+YmFzZS5uYW1lLCBsZXZlbCwKPiAgCQkJCSAgc3dfcGxhbmVf d20tPndtW2xldmVsXS5wbGFuZV9lbiwKPiAgCQkJCSAgc3dfcGxhbmVfd20tPndtW2xldmVsXS5w bGFuZV9yZXNfYiwKPiAgCQkJCSAgc3dfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfbCwK PiBAQCAtMTMwMzIsOCArMTI5OTUsOCBAQCBzdGF0aWMgdm9pZCB2ZXJpZnlfd21fc3RhdGUoc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gIAo+ICAJCWlmICghc2tsX3dtX2xldmVsX2VxdWFscygm aHdfcGxhbmVfd20tPnRyYW5zX3dtLAo+ICAJCQkJCSAmc3dfcGxhbmVfd20tPnRyYW5zX3dtKSkg ewo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIHRyYW5zIFdNIHBpcGUgJWMgY3Vyc29yIChl eHBlY3RlZCBlPSVkIGI9JXUgbD0ldSwgZ290IGU9JWQgYj0ldSBsPSV1KVxuIiwKPiAtCQkJCSAg cGlwZV9uYW1lKHBpcGUpLAo+ICsJCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIHRyYW5zIFdNIHBp cGUgJWMgJXMgKGV4cGVjdGVkIGU9JWQgYj0ldSBsPSV1LCBnb3QgZT0lZCBiPSV1IGw9JXUpXG4i LAo+ICsJCQkJICBwaXBlX25hbWUocGlwZSksIHBsYW5lLT5iYXNlLm5hbWUsCj4gIAkJCQkgIHN3 X3BsYW5lX3dtLT50cmFuc193bS5wbGFuZV9lbiwKPiAgCQkJCSAgc3dfcGxhbmVfd20tPnRyYW5z X3dtLnBsYW5lX3Jlc19iLAo+ICAJCQkJICBzd19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVfcmVz X2wsCj4gQEAgLTEzMDQzLDEyICsxMzAwNiwxMiBAQCBzdGF0aWMgdm9pZCB2ZXJpZnlfd21fc3Rh dGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJfQo+ICAKPiAgCQkvKiBEREIgKi8KPiAt CQlod19kZGJfZW50cnkgPSAmaHctPmRkYl95W1BMQU5FX0NVUlNPUl07Cj4gLQkJc3dfZGRiX2Vu dHJ5ID0gJm5ld19jcnRjX3N0YXRlLT53bS5za2wucGxhbmVfZGRiX3lbUExBTkVfQ1VSU09SXTsK PiArCQlod19kZGJfZW50cnkgPSAmaHctPmRkYl95W3BsYW5lLT5pZF07Cj4gKwkJc3dfZGRiX2Vu dHJ5ID0gJm5ld19jcnRjX3N0YXRlLT53bS5za2wucGxhbmVfZGRiX3lbcGxhbmUtPmlkXTsKPiAg Cj4gIAkJaWYgKCFza2xfZGRiX2VudHJ5X2VxdWFsKGh3X2RkYl9lbnRyeSwgc3dfZGRiX2VudHJ5 KSkgewo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIEREQiBzdGF0ZSBwaXBlICVjIGN1cnNv ciAoZXhwZWN0ZWQgKCV1LCV1KSwgZm91bmQgKCV1LCV1KSlcbiIsCj4gLQkJCQkgIHBpcGVfbmFt ZShwaXBlKSwKPiArCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiBEREIgc3RhdGUgcGlwZSAlYyAl cyAoZXhwZWN0ZWQgKCV1LCV1KSwgZm91bmQgKCV1LCV1KSlcbiIsCj4gKwkJCQkgIHBpcGVfbmFt ZShwaXBlKSwgcGxhbmUtPmJhc2UubmFtZSwKPiAgCQkJCSAgc3dfZGRiX2VudHJ5LT5zdGFydCwg c3dfZGRiX2VudHJ5LT5lbmQsCj4gIAkJCQkgIGh3X2RkYl9lbnRyeS0+c3RhcnQsIGh3X2RkYl9l bnRyeS0+ZW5kKTsKPiAgCQl9Cj4gLS0gCj4gMi4yMy4wCj4gCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==