From: Manasi Navare <manasi.d.navare@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [2/2] drm/i915: Check some transcoder timing minimum limits
Date: Fri, 18 Oct 2019 12:45:18 -0700 [thread overview]
Message-ID: <20191018194518.GA2391@intel.com> (raw)
In-Reply-To: <20190718144340.1114-2-ville.syrjala@linux.intel.com>
On Fri, Oct 18, 2019 at 12:43:56PM -0700, Manasi Navare wrote:
> From: Ville Syrjala <ville.syrjala@linux.intel.com>
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On ILK+ the documented min hdisplay is 64, min hblank is 32, and min
> vblank is 5. On earlier platforms min hblank is also 32, and min
> vblank is 3. Make sure the mode satisfies those limits.
>
> There are further limits for HDMI and pfit use cases, but we'll check
> for those in a more specific location.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Double checked the min limits from the spec and looks good to me
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index e25b82d07d4f..1141f4aa31c7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -15816,6 +15816,21 @@ intel_mode_valid(struct drm_device *dev,
> mode->vtotal > vtotal_max)
> return MODE_V_ILLEGAL;
>
> + if (INTEL_GEN(dev_priv) >= 5) {
> + if (mode->hdisplay < 64 ||
> + mode->htotal - mode->hdisplay < 32)
> + return MODE_H_ILLEGAL;
> +
> + if (mode->vtotal - mode->vdisplay < 5)
> + return MODE_V_ILLEGAL;
> + } else {
> + if (mode->htotal - mode->hdisplay < 32)
> + return MODE_H_ILLEGAL;
> +
> + if (mode->vtotal - mode->vdisplay < 3)
> + return MODE_V_ILLEGAL;
> + }
> +
> return MODE_OK;
> }
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-18 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 14:43 [PATCH 1/2] drm/i915: Refuse modes with hdisplay==4096 on pre-HSW DP Ville Syrjala
2019-07-18 14:43 ` [PATCH 2/2] drm/i915: Check some transcoder timing minimum limits Ville Syrjala
2019-10-18 19:45 ` Manasi Navare [this message]
2019-07-18 15:11 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Refuse modes with hdisplay==4096 on pre-HSW DP Patchwork
2019-07-29 19:11 ` [PATCH 1/2] " Manasi Navare
2019-08-19 16:14 ` Ville Syrjälä
2019-10-16 19:37 ` Manasi Navare
2019-09-30 19:41 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Refuse modes with hdisplay==4096 on pre-HSW DP (rev2) Patchwork
2019-10-01 1:06 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018194518.GA2391@intel.com \
--to=manasi.d.navare@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).