From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH V5 1/6] mdev: class id support Date: Thu, 24 Oct 2019 13:46:36 -0600 Message-ID: <20191024134636.253131c5@x1.home> References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-2-jasowang@redhat.com> <20191023154204.31d74866@x1.home> <38bdf762-524a-e0f1-6e9a-1102adfe8fb1@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <38bdf762-524a-e0f1-6e9a-1102adfe8fb1@redhat.com> Sender: netdev-owner@vger.kernel.org To: Jason Wang Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com List-Id: intel-gfx@lists.freedesktop.org On Thu, 24 Oct 2019 11:27:36 +0800 Jason Wang wrote: > On 2019/10/24 =E4=B8=8A=E5=8D=885:42, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:47 +0800 > > Jason Wang wrote: > > =20 > >> Mdev bus only supports vfio driver right now, so it doesn't implement > >> match method. But in the future, we may add drivers other than vfio, > >> the first driver could be virtio-mdev. This means we need to add > >> device class id support in bus match method to pair the mdev device > >> and mdev driver correctly. > >> > >> So this patch adds id_table to mdev_driver and class_id for mdev > >> device with the match method for mdev bus. > >> > >> Signed-off-by: Jason Wang > >> --- > >> .../driver-api/vfio-mediated-device.rst | 5 +++++ > >> drivers/gpu/drm/i915/gvt/kvmgt.c | 1 + > >> drivers/s390/cio/vfio_ccw_ops.c | 1 + > >> drivers/s390/crypto/vfio_ap_ops.c | 1 + > >> drivers/vfio/mdev/mdev_core.c | 18 +++++++++++++++ > >> drivers/vfio/mdev/mdev_driver.c | 22 +++++++++++++++++= ++ > >> drivers/vfio/mdev/mdev_private.h | 1 + > >> drivers/vfio/mdev/vfio_mdev.c | 6 +++++ > >> include/linux/mdev.h | 8 +++++++ > >> include/linux/mod_devicetable.h | 8 +++++++ > >> samples/vfio-mdev/mbochs.c | 1 + > >> samples/vfio-mdev/mdpy.c | 1 + > >> samples/vfio-mdev/mtty.c | 1 + > >> 13 files changed, 74 insertions(+) > >> > >> diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Docum= entation/driver-api/vfio-mediated-device.rst > >> index 25eb7d5b834b..6709413bee29 100644 > >> --- a/Documentation/driver-api/vfio-mediated-device.rst > >> +++ b/Documentation/driver-api/vfio-mediated-device.rst > >> @@ -102,12 +102,14 @@ structure to represent a mediated device's drive= r:: > >> * @probe: called when new device created > >> * @remove: called when device removed > >> * @driver: device driver structure > >> + * @id_table: the ids serviced by this driver > >> */ > >> struct mdev_driver { > >> =09 const char *name; > >> =09 int (*probe) (struct device *dev); > >> =09 void (*remove) (struct device *dev); > >> =09 struct device_driver driver; > >> +=09 const struct mdev_class_id *id_table; > >> }; > >> =20 > >> A mediated bus driver for mdev should use this structure in the func= tion calls > >> @@ -170,6 +172,9 @@ that a driver should use to unregister itself with= the mdev core driver:: > >> =20 > >> =09extern void mdev_unregister_device(struct device *dev); > >> =20 > >> +It is also required to specify the class_id in create() callback thro= ugh:: > >> + > >> +=09int mdev_set_class(struct mdev_device *mdev, u16 id); > >> =20 > >> Mediated Device Management Interface Through sysfs > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > >> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/g= vt/kvmgt.c > >> index 343d79c1cb7e..6420f0dbd31b 100644 > >> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c > >> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c > >> @@ -678,6 +678,7 @@ static int intel_vgpu_create(struct kobject *kobj,= struct mdev_device *mdev) > >> =09=09 dev_name(mdev_dev(mdev))); > >> =09ret =3D 0; > >> =20 > >> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VFIO); > >> out: > >> =09return ret; > >> } > >> diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_c= cw_ops.c > >> index f0d71ab77c50..cf2c013ae32f 100644 > >> --- a/drivers/s390/cio/vfio_ccw_ops.c > >> +++ b/drivers/s390/cio/vfio_ccw_ops.c > >> @@ -129,6 +129,7 @@ static int vfio_ccw_mdev_create(struct kobject *ko= bj, struct mdev_device *mdev) > >> =09=09=09 private->sch->schid.ssid, > >> =09=09=09 private->sch->schid.sch_no); > >> =20 > >> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VFIO); > >> =09return 0; > >> } > >> =20 > >> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/v= fio_ap_ops.c > >> index 5c0f53c6dde7..07c31070afeb 100644 > >> --- a/drivers/s390/crypto/vfio_ap_ops.c > >> +++ b/drivers/s390/crypto/vfio_ap_ops.c > >> @@ -343,6 +343,7 @@ static int vfio_ap_mdev_create(struct kobject *kob= j, struct mdev_device *mdev) > >> =09list_add(&matrix_mdev->node, &matrix_dev->mdev_list); > >> =09mutex_unlock(&matrix_dev->lock); > >> =20 > >> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VFIO); > >> =09return 0; > >> } > >> =20 > >> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_co= re.c > >> index b558d4cfd082..3a9c52d71b4e 100644 > >> --- a/drivers/vfio/mdev/mdev_core.c > >> +++ b/drivers/vfio/mdev/mdev_core.c > >> @@ -45,6 +45,16 @@ void mdev_set_drvdata(struct mdev_device *mdev, voi= d *data) > >> } > >> EXPORT_SYMBOL(mdev_set_drvdata); > >> =20 > >> +/* Specify the class for the mdev device, this must be called during > >> + * create() callback. > >> + */ > >> +void mdev_set_class(struct mdev_device *mdev, u16 id) > >> +{ > >> +=09WARN_ON(mdev->class_id); > >> +=09mdev->class_id =3D id; > >> +} > >> +EXPORT_SYMBOL(mdev_set_class); > >> + > >> struct device *mdev_dev(struct mdev_device *mdev) > >> { > >> =09return &mdev->dev; > >> @@ -135,6 +145,7 @@ static int mdev_device_remove_cb(struct device *de= v, void *data) > >> * mdev_register_device : Register a device > >> * @dev: device structure representing parent device. > >> * @ops: Parent device operation structure to be registered. > >> + * @id: class id. > >> * > >> * Add device to list of registered parent devices. > >> * Returns a negative value on error, otherwise 0. > >> @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, > >> =09if (ret) > >> =09=09goto ops_create_fail; > >> =20 > >> +=09if (!mdev->class_id) { > >> +=09=09ret =3D -EINVAL; > >> +=09=09WARN(1, "class id must be specified for device %s\n", > >> +=09=09 dev_name(dev)); =20 > > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n= "); =20 >=20 >=20 > Will fix. >=20 >=20 > > =20 > >> +=09=09goto add_fail; > >> +=09} > >> + > >> =09ret =3D device_add(&mdev->dev); > >> =09if (ret) > >> =09=09goto add_fail; > >> diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_= driver.c > >> index 0d3223aee20b..319d886ffaf7 100644 > >> --- a/drivers/vfio/mdev/mdev_driver.c > >> +++ b/drivers/vfio/mdev/mdev_driver.c > >> @@ -69,8 +69,30 @@ static int mdev_remove(struct device *dev) > >> =09return 0; > >> } > >> =20 > >> +static int mdev_match(struct device *dev, struct device_driver *drv) > >> +{ > >> +=09unsigned int i; > >> +=09struct mdev_device *mdev =3D to_mdev_device(dev); > >> +=09struct mdev_driver *mdrv =3D to_mdev_driver(drv); > >> +=09const struct mdev_class_id *ids =3D mdrv->id_table; > >> + =20 > > Nit, as we start to allow new mdev bus drivers, mdev-core might want to > > protect itself from a NULL id_table, by either failing the > > mdev_register_driver() or failing the match here. I think such a > > condition would segfault as written here, but clearly we don't have > > such external drivers yet. Thanks, =20 >=20 >=20 > I'm not sure I get the point here. My understanding is that mdev-core=20 > won't try to be matched here since it was not a complete mdev device. The parent driver failing to set a type vs the parent driver failing to register with a struct mdev_driver where id_table is not null are different issues. I agree that if a vendor driver was not updated for this series that they'd never successfully create a device because the mdev-core would reject it for not setting a class, but mdev_match() is called for devices that might be created by other vendor drivers, so loading a parent driver with a null id_table potentially breaks matching for everyone. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D030CA9EBC for ; Thu, 24 Oct 2019 19:47:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55B952070B for ; Thu, 24 Oct 2019 19:47:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55B952070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A57C6E637; Thu, 24 Oct 2019 19:47:01 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27AE16E77F for ; Thu, 24 Oct 2019 19:47:00 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-_h2FRMZQMb62lVvm9O8R9A-1; Thu, 24 Oct 2019 15:46:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3F8B107AD33; Thu, 24 Oct 2019 19:46:50 +0000 (UTC) Received: from x1.home (ovpn-118-102.phx2.redhat.com [10.3.118.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id CDC055C21A; Thu, 24 Oct 2019 19:46:36 +0000 (UTC) Date: Thu, 24 Oct 2019 13:46:36 -0600 From: Alex Williamson To: Jason Wang Message-ID: <20191024134636.253131c5@x1.home> In-Reply-To: <38bdf762-524a-e0f1-6e9a-1102adfe8fb1@redhat.com> References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-2-jasowang@redhat.com> <20191023154204.31d74866@x1.home> <38bdf762-524a-e0f1-6e9a-1102adfe8fb1@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: _h2FRMZQMb62lVvm9O8R9A-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571946419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H9X0BtuoZ8Jvkk6PkqP3IQvdtLRJY5D+ojk6YTP+TA8=; b=TAKwabPnX4bKsX0vNOHBMBRAE3/96KBP2VPSu9vZHWEsx+kSVVw1nxNRscLNYRBZlKfZHx Y/yKIQbr8Qmak9l31XiBg+tRWrwA+jRn/dQwm1eKa0KQyTsvM9t7byXIn4WUKfzMSQotrr H1J5astDGqicYEYgA+SptDkhuEG4eCQ= Subject: Re: [Intel-gfx] [PATCH V5 1/6] mdev: class id support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191024194636.1kC9HUXYSBEq5E9LTE4a3u-QQkkZ6ziOSrPd0JXUrP4@z> T24gVGh1LCAyNCBPY3QgMjAxOSAxMToyNzozNiArMDgwMApKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPiB3cm90ZToKCj4gT24gMjAxOS8xMC8yNCDkuIrljYg1OjQyLCBBbGV4IFdpbGxp YW1zb24gd3JvdGU6Cj4gPiBPbiBXZWQsIDIzIE9jdCAyMDE5IDIxOjA3OjQ3ICswODAwCj4gPiBK YXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPiA+ICAKPiA+PiBNZGV2IGJ1 cyBvbmx5IHN1cHBvcnRzIHZmaW8gZHJpdmVyIHJpZ2h0IG5vdywgc28gaXQgZG9lc24ndCBpbXBs ZW1lbnQKPiA+PiBtYXRjaCBtZXRob2QuIEJ1dCBpbiB0aGUgZnV0dXJlLCB3ZSBtYXkgYWRkIGRy aXZlcnMgb3RoZXIgdGhhbiB2ZmlvLAo+ID4+IHRoZSBmaXJzdCBkcml2ZXIgY291bGQgYmUgdmly dGlvLW1kZXYuIFRoaXMgbWVhbnMgd2UgbmVlZCB0byBhZGQKPiA+PiBkZXZpY2UgY2xhc3MgaWQg c3VwcG9ydCBpbiBidXMgbWF0Y2ggbWV0aG9kIHRvIHBhaXIgdGhlIG1kZXYgZGV2aWNlCj4gPj4g YW5kIG1kZXYgZHJpdmVyIGNvcnJlY3RseS4KPiA+Pgo+ID4+IFNvIHRoaXMgcGF0Y2ggYWRkcyBp ZF90YWJsZSB0byBtZGV2X2RyaXZlciBhbmQgY2xhc3NfaWQgZm9yIG1kZXYKPiA+PiBkZXZpY2Ug d2l0aCB0aGUgbWF0Y2ggbWV0aG9kIGZvciBtZGV2IGJ1cy4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYt Ynk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4gPj4gLS0tCj4gPj4gICAuLi4v ZHJpdmVyLWFwaS92ZmlvLW1lZGlhdGVkLWRldmljZS5yc3QgICAgICAgfCAgNSArKysrKwo+ID4+ ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2t2bWd0LmMgICAgICAgICAgICAgIHwgIDEgKwo+ ID4+ICAgZHJpdmVycy9zMzkwL2Npby92ZmlvX2Njd19vcHMuYyAgICAgICAgICAgICAgIHwgIDEg Kwo+ID4+ICAgZHJpdmVycy9zMzkwL2NyeXB0by92ZmlvX2FwX29wcy5jICAgICAgICAgICAgIHwg IDEgKwo+ID4+ICAgZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMgICAgICAgICAgICAgICAg IHwgMTggKysrKysrKysrKysrKysrCj4gPj4gICBkcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2RyaXZl ci5jICAgICAgICAgICAgICAgfCAyMiArKysrKysrKysrKysrKysrKysrCj4gPj4gICBkcml2ZXJz L3ZmaW8vbWRldi9tZGV2X3ByaXZhdGUuaCAgICAgICAgICAgICAgfCAgMSArCj4gPj4gICBkcml2 ZXJzL3ZmaW8vbWRldi92ZmlvX21kZXYuYyAgICAgICAgICAgICAgICAgfCAgNiArKysrKwo+ID4+ ICAgaW5jbHVkZS9saW51eC9tZGV2LmggICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDggKysr KysrKwo+ID4+ICAgaW5jbHVkZS9saW51eC9tb2RfZGV2aWNldGFibGUuaCAgICAgICAgICAgICAg IHwgIDggKysrKysrKwo+ID4+ICAgc2FtcGxlcy92ZmlvLW1kZXYvbWJvY2hzLmMgICAgICAgICAg ICAgICAgICAgIHwgIDEgKwo+ID4+ICAgc2FtcGxlcy92ZmlvLW1kZXYvbWRweS5jICAgICAgICAg ICAgICAgICAgICAgIHwgIDEgKwo+ID4+ICAgc2FtcGxlcy92ZmlvLW1kZXYvbXR0eS5jICAgICAg ICAgICAgICAgICAgICAgIHwgIDEgKwo+ID4+ICAgMTMgZmlsZXMgY2hhbmdlZCwgNzQgaW5zZXJ0 aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZHJpdmVyLWFwaS92 ZmlvLW1lZGlhdGVkLWRldmljZS5yc3QgYi9Eb2N1bWVudGF0aW9uL2RyaXZlci1hcGkvdmZpby1t ZWRpYXRlZC1kZXZpY2UucnN0Cj4gPj4gaW5kZXggMjVlYjdkNWI4MzRiLi42NzA5NDEzYmVlMjkg MTAwNjQ0Cj4gPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kcml2ZXItYXBpL3ZmaW8tbWVkaWF0ZWQt ZGV2aWNlLnJzdAo+ID4+ICsrKyBiL0RvY3VtZW50YXRpb24vZHJpdmVyLWFwaS92ZmlvLW1lZGlh dGVkLWRldmljZS5yc3QKPiA+PiBAQCAtMTAyLDEyICsxMDIsMTQgQEAgc3RydWN0dXJlIHRvIHJl cHJlc2VudCBhIG1lZGlhdGVkIGRldmljZSdzIGRyaXZlcjo6Cj4gPj4gICAgICAgICAqIEBwcm9i ZTogY2FsbGVkIHdoZW4gbmV3IGRldmljZSBjcmVhdGVkCj4gPj4gICAgICAgICAqIEByZW1vdmU6 IGNhbGxlZCB3aGVuIGRldmljZSByZW1vdmVkCj4gPj4gICAgICAgICAqIEBkcml2ZXI6IGRldmlj ZSBkcml2ZXIgc3RydWN0dXJlCj4gPj4gKyAgICAgICogQGlkX3RhYmxlOiB0aGUgaWRzIHNlcnZp Y2VkIGJ5IHRoaXMgZHJpdmVyCj4gPj4gICAgICAgICAqLwo+ID4+ICAgICAgICBzdHJ1Y3QgbWRl dl9kcml2ZXIgewo+ID4+ICAgCSAgICAgY29uc3QgY2hhciAqbmFtZTsKPiA+PiAgIAkgICAgIGlu dCAgKCpwcm9iZSkgIChzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+ID4+ICAgCSAgICAgdm9pZCAoKnJl bW92ZSkgKHN0cnVjdCBkZXZpY2UgKmRldik7Cj4gPj4gICAJICAgICBzdHJ1Y3QgZGV2aWNlX2Ry aXZlciAgICBkcml2ZXI7Cj4gPj4gKwkgICAgIGNvbnN0IHN0cnVjdCBtZGV2X2NsYXNzX2lkICpp ZF90YWJsZTsKPiA+PiAgICAgICAgfTsKPiA+PiAgIAo+ID4+ICAgQSBtZWRpYXRlZCBidXMgZHJp dmVyIGZvciBtZGV2IHNob3VsZCB1c2UgdGhpcyBzdHJ1Y3R1cmUgaW4gdGhlIGZ1bmN0aW9uIGNh bGxzCj4gPj4gQEAgLTE3MCw2ICsxNzIsOSBAQCB0aGF0IGEgZHJpdmVyIHNob3VsZCB1c2UgdG8g dW5yZWdpc3RlciBpdHNlbGYgd2l0aCB0aGUgbWRldiBjb3JlIGRyaXZlcjo6Cj4gPj4gICAKPiA+ PiAgIAlleHRlcm4gdm9pZCBtZGV2X3VucmVnaXN0ZXJfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRl dik7Cj4gPj4gICAKPiA+PiArSXQgaXMgYWxzbyByZXF1aXJlZCB0byBzcGVjaWZ5IHRoZSBjbGFz c19pZCBpbiBjcmVhdGUoKSBjYWxsYmFjayB0aHJvdWdoOjoKPiA+PiArCj4gPj4gKwlpbnQgbWRl dl9zZXRfY2xhc3Moc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYgaWQpOwo+ID4+ICAgCj4g Pj4gICBNZWRpYXRlZCBEZXZpY2UgTWFuYWdlbWVudCBJbnRlcmZhY2UgVGhyb3VnaCBzeXNmcwo+ ID4+ICAgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2t2bWd0LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndnQva3ZtZ3QuYwo+ID4+IGluZGV4IDM0M2Q3OWMxY2I3ZS4uNjQy MGYwZGJkMzFiIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9rdm1n dC5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2t2bWd0LmMKPiA+PiBAQCAt Njc4LDYgKzY3OCw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfdmdwdV9jcmVhdGUoc3RydWN0IGtvYmpl Y3QgKmtvYmosIHN0cnVjdCBtZGV2X2RldmljZSAqbWRldikKPiA+PiAgIAkJICAgICBkZXZfbmFt ZShtZGV2X2RldihtZGV2KSkpOwo+ID4+ICAgCXJldCA9IDA7Cj4gPj4gICAKPiA+PiArCW1kZXZf c2V0X2NsYXNzKG1kZXYsIE1ERVZfQ0xBU1NfSURfVkZJTyk7Cj4gPj4gICBvdXQ6Cj4gPj4gICAJ cmV0dXJuIHJldDsKPiA+PiAgIH0KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zMzkwL2Npby92 ZmlvX2Njd19vcHMuYyBiL2RyaXZlcnMvczM5MC9jaW8vdmZpb19jY3dfb3BzLmMKPiA+PiBpbmRl eCBmMGQ3MWFiNzdjNTAuLmNmMmMwMTNhZTMyZiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL3Mz OTAvY2lvL3ZmaW9fY2N3X29wcy5jCj4gPj4gKysrIGIvZHJpdmVycy9zMzkwL2Npby92ZmlvX2Nj d19vcHMuYwo+ID4+IEBAIC0xMjksNiArMTI5LDcgQEAgc3RhdGljIGludCB2ZmlvX2Njd19tZGV2 X2NyZWF0ZShzdHJ1Y3Qga29iamVjdCAqa29iaiwgc3RydWN0IG1kZXZfZGV2aWNlICptZGV2KQo+ ID4+ICAgCQkJICAgcHJpdmF0ZS0+c2NoLT5zY2hpZC5zc2lkLAo+ID4+ICAgCQkJICAgcHJpdmF0 ZS0+c2NoLT5zY2hpZC5zY2hfbm8pOwo+ID4+ICAgCj4gPj4gKwltZGV2X3NldF9jbGFzcyhtZGV2 LCBNREVWX0NMQVNTX0lEX1ZGSU8pOwo+ID4+ICAgCXJldHVybiAwOwo+ID4+ICAgfQo+ID4+ICAg Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvczM5MC9jcnlwdG8vdmZpb19hcF9vcHMuYyBiL2Ry aXZlcnMvczM5MC9jcnlwdG8vdmZpb19hcF9vcHMuYwo+ID4+IGluZGV4IDVjMGY1M2M2ZGRlNy4u MDdjMzEwNzBhZmViIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvczM5MC9jcnlwdG8vdmZpb19h cF9vcHMuYwo+ID4+ICsrKyBiL2RyaXZlcnMvczM5MC9jcnlwdG8vdmZpb19hcF9vcHMuYwo+ID4+ IEBAIC0zNDMsNiArMzQzLDcgQEAgc3RhdGljIGludCB2ZmlvX2FwX21kZXZfY3JlYXRlKHN0cnVj dCBrb2JqZWN0ICprb2JqLCBzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpCj4gPj4gICAJbGlzdF9h ZGQoJm1hdHJpeF9tZGV2LT5ub2RlLCAmbWF0cml4X2Rldi0+bWRldl9saXN0KTsKPiA+PiAgIAlt dXRleF91bmxvY2soJm1hdHJpeF9kZXYtPmxvY2spOwo+ID4+ICAgCj4gPj4gKwltZGV2X3NldF9j bGFzcyhtZGV2LCBNREVWX0NMQVNTX0lEX1ZGSU8pOwo+ID4+ICAgCXJldHVybiAwOwo+ID4+ICAg fQo+ID4+ICAgCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmZpby9tZGV2L21kZXZfY29yZS5j IGIvZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMKPiA+PiBpbmRleCBiNTU4ZDRjZmQwODIu LjNhOWM1MmQ3MWI0ZSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2Nv cmUuYwo+ID4+ICsrKyBiL2RyaXZlcnMvdmZpby9tZGV2L21kZXZfY29yZS5jCj4gPj4gQEAgLTQ1 LDYgKzQ1LDE2IEBAIHZvaWQgbWRldl9zZXRfZHJ2ZGF0YShzdHJ1Y3QgbWRldl9kZXZpY2UgKm1k ZXYsIHZvaWQgKmRhdGEpCj4gPj4gICB9Cj4gPj4gICBFWFBPUlRfU1lNQk9MKG1kZXZfc2V0X2Ry dmRhdGEpOwo+ID4+ICAgCj4gPj4gKy8qIFNwZWNpZnkgdGhlIGNsYXNzIGZvciB0aGUgbWRldiBk ZXZpY2UsIHRoaXMgbXVzdCBiZSBjYWxsZWQgZHVyaW5nCj4gPj4gKyAqIGNyZWF0ZSgpIGNhbGxi YWNrLgo+ID4+ICsgKi8KPiA+PiArdm9pZCBtZGV2X3NldF9jbGFzcyhzdHJ1Y3QgbWRldl9kZXZp Y2UgKm1kZXYsIHUxNiBpZCkKPiA+PiArewo+ID4+ICsJV0FSTl9PTihtZGV2LT5jbGFzc19pZCk7 Cj4gPj4gKwltZGV2LT5jbGFzc19pZCA9IGlkOwo+ID4+ICt9Cj4gPj4gK0VYUE9SVF9TWU1CT0wo bWRldl9zZXRfY2xhc3MpOwo+ID4+ICsKPiA+PiAgIHN0cnVjdCBkZXZpY2UgKm1kZXZfZGV2KHN0 cnVjdCBtZGV2X2RldmljZSAqbWRldikKPiA+PiAgIHsKPiA+PiAgIAlyZXR1cm4gJm1kZXYtPmRl djsKPiA+PiBAQCAtMTM1LDYgKzE0NSw3IEBAIHN0YXRpYyBpbnQgbWRldl9kZXZpY2VfcmVtb3Zl X2NiKHN0cnVjdCBkZXZpY2UgKmRldiwgdm9pZCAqZGF0YSkKPiA+PiAgICAqIG1kZXZfcmVnaXN0 ZXJfZGV2aWNlIDogUmVnaXN0ZXIgYSBkZXZpY2UKPiA+PiAgICAqIEBkZXY6IGRldmljZSBzdHJ1 Y3R1cmUgcmVwcmVzZW50aW5nIHBhcmVudCBkZXZpY2UuCj4gPj4gICAgKiBAb3BzOiBQYXJlbnQg ZGV2aWNlIG9wZXJhdGlvbiBzdHJ1Y3R1cmUgdG8gYmUgcmVnaXN0ZXJlZC4KPiA+PiArICogQGlk OiBjbGFzcyBpZC4KPiA+PiAgICAqCj4gPj4gICAgKiBBZGQgZGV2aWNlIHRvIGxpc3Qgb2YgcmVn aXN0ZXJlZCBwYXJlbnQgZGV2aWNlcy4KPiA+PiAgICAqIFJldHVybnMgYSBuZWdhdGl2ZSB2YWx1 ZSBvbiBlcnJvciwgb3RoZXJ3aXNlIDAuCj4gPj4gQEAgLTMyNCw2ICszMzUsMTMgQEAgaW50IG1k ZXZfZGV2aWNlX2NyZWF0ZShzdHJ1Y3Qga29iamVjdCAqa29iaiwKPiA+PiAgIAlpZiAocmV0KQo+ ID4+ICAgCQlnb3RvIG9wc19jcmVhdGVfZmFpbDsKPiA+PiAgIAo+ID4+ICsJaWYgKCFtZGV2LT5j bGFzc19pZCkgewo+ID4+ICsJCXJldCA9IC1FSU5WQUw7Cj4gPj4gKwkJV0FSTigxLCAiY2xhc3Mg aWQgbXVzdCBiZSBzcGVjaWZpZWQgZm9yIGRldmljZSAlc1xuIiwKPiA+PiArCQkgICAgIGRldl9u YW1lKGRldikpOyAgCj4gPiBOaXQsIGRldl93YXJuKGRldiwgIm1kZXYgdmVuZG9yIGRyaXZlciBm YWlsZWQgdG8gc3BlY2lmeSBkZXZpY2UgY2xhc3NcbiIpOyAgCj4gCj4gCj4gV2lsbCBmaXguCj4g Cj4gCj4gPiAgCj4gPj4gKwkJZ290byBhZGRfZmFpbDsKPiA+PiArCX0KPiA+PiArCj4gPj4gICAJ cmV0ID0gZGV2aWNlX2FkZCgmbWRldi0+ZGV2KTsKPiA+PiAgIAlpZiAocmV0KQo+ID4+ICAgCQln b3RvIGFkZF9mYWlsOwo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2Ry aXZlci5jIGIvZHJpdmVycy92ZmlvL21kZXYvbWRldl9kcml2ZXIuYwo+ID4+IGluZGV4IDBkMzIy M2FlZTIwYi4uMzE5ZDg4NmZmYWY3IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvdmZpby9tZGV2 L21kZXZfZHJpdmVyLmMKPiA+PiArKysgYi9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2RyaXZlci5j Cj4gPj4gQEAgLTY5LDggKzY5LDMwIEBAIHN0YXRpYyBpbnQgbWRldl9yZW1vdmUoc3RydWN0IGRl dmljZSAqZGV2KQo+ID4+ICAgCXJldHVybiAwOwo+ID4+ICAgfQo+ID4+ICAgCj4gPj4gK3N0YXRp YyBpbnQgbWRldl9tYXRjaChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2VfZHJpdmVy ICpkcnYpCj4gPj4gK3sKPiA+PiArCXVuc2lnbmVkIGludCBpOwo+ID4+ICsJc3RydWN0IG1kZXZf ZGV2aWNlICptZGV2ID0gdG9fbWRldl9kZXZpY2UoZGV2KTsKPiA+PiArCXN0cnVjdCBtZGV2X2Ry aXZlciAqbWRydiA9IHRvX21kZXZfZHJpdmVyKGRydik7Cj4gPj4gKwljb25zdCBzdHJ1Y3QgbWRl dl9jbGFzc19pZCAqaWRzID0gbWRydi0+aWRfdGFibGU7Cj4gPj4gKyAgCj4gPiBOaXQsIGFzIHdl IHN0YXJ0IHRvIGFsbG93IG5ldyBtZGV2IGJ1cyBkcml2ZXJzLCBtZGV2LWNvcmUgbWlnaHQgd2Fu dCB0bwo+ID4gcHJvdGVjdCBpdHNlbGYgZnJvbSBhIE5VTEwgaWRfdGFibGUsIGJ5IGVpdGhlciBm YWlsaW5nIHRoZQo+ID4gbWRldl9yZWdpc3Rlcl9kcml2ZXIoKSBvciBmYWlsaW5nIHRoZSBtYXRj aCBoZXJlLiAgSSB0aGluayBzdWNoIGEKPiA+IGNvbmRpdGlvbiB3b3VsZCBzZWdmYXVsdCBhcyB3 cml0dGVuIGhlcmUsIGJ1dCBjbGVhcmx5IHdlIGRvbid0IGhhdmUKPiA+IHN1Y2ggZXh0ZXJuYWwg ZHJpdmVycyB5ZXQuICBUaGFua3MsICAKPiAKPiAKPiBJJ20gbm90IHN1cmUgSSBnZXQgdGhlIHBv aW50IGhlcmUuIE15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCBtZGV2LWNvcmUgCj4gd29uJ3QgdHJ5 IHRvIGJlIG1hdGNoZWQgaGVyZSBzaW5jZSBpdCB3YXMgbm90IGEgY29tcGxldGUgbWRldiBkZXZp Y2UuCgpUaGUgcGFyZW50IGRyaXZlciBmYWlsaW5nIHRvIHNldCBhIHR5cGUgdnMgdGhlIHBhcmVu dCBkcml2ZXIgZmFpbGluZyB0bwpyZWdpc3RlciB3aXRoIGEgc3RydWN0IG1kZXZfZHJpdmVyIHdo ZXJlIGlkX3RhYmxlIGlzIG5vdCBudWxsIGFyZQpkaWZmZXJlbnQgaXNzdWVzLiAgSSBhZ3JlZSB0 aGF0IGlmIGEgdmVuZG9yIGRyaXZlciB3YXMgbm90IHVwZGF0ZWQgZm9yCnRoaXMgc2VyaWVzIHRo YXQgdGhleSdkIG5ldmVyIHN1Y2Nlc3NmdWxseSBjcmVhdGUgYSBkZXZpY2UgYmVjYXVzZSB0aGUK bWRldi1jb3JlIHdvdWxkIHJlamVjdCBpdCBmb3Igbm90IHNldHRpbmcgYSBjbGFzcywgYnV0IG1k ZXZfbWF0Y2goKSBpcwpjYWxsZWQgZm9yIGRldmljZXMgdGhhdCBtaWdodCBiZSBjcmVhdGVkIGJ5 IG90aGVyIHZlbmRvciBkcml2ZXJzLCBzbwpsb2FkaW5nIGEgcGFyZW50IGRyaXZlciB3aXRoIGEg bnVsbCBpZF90YWJsZSBwb3RlbnRpYWxseSBicmVha3MKbWF0Y2hpbmcgZm9yIGV2ZXJ5b25lLiAg VGhhbmtzLAoKQWxleAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4