From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH V5 2/6] modpost: add support for mdev class id Date: Thu, 24 Oct 2019 13:54:41 -0600 Message-ID: <20191024135441.160daa56@x1.home> References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-3-jasowang@redhat.com> <20191023154245.32e4fa49@x1.home> <555a101e-0ed1-2e9d-c1a4-e3b37d76bd18@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <555a101e-0ed1-2e9d-c1a4-e3b37d76bd18@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Jason Wang Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com List-Id: intel-gfx@lists.freedesktop.org On Thu, 24 Oct 2019 11:31:04 +0800 Jason Wang wrote: > On 2019/10/24 =E4=B8=8A=E5=8D=885:42, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:48 +0800 > > Jason Wang wrote: > > =20 > >> Add support to parse mdev class id table. > >> > >> Reviewed-by: Parav Pandit > >> Signed-off-by: Jason Wang > >> --- > >> drivers/vfio/mdev/vfio_mdev.c | 2 ++ > >> scripts/mod/devicetable-offsets.c | 3 +++ > >> scripts/mod/file2alias.c | 10 ++++++++++ > >> 3 files changed, 15 insertions(+) > >> > >> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_md= ev.c > >> index 7b24ee9cb8dd..cb701cd646f0 100644 > >> --- a/drivers/vfio/mdev/vfio_mdev.c > >> +++ b/drivers/vfio/mdev/vfio_mdev.c > >> @@ -125,6 +125,8 @@ static const struct mdev_class_id id_table[] =3D { > >> =09{ 0 }, > >> }; > >> =20 > >> +MODULE_DEVICE_TABLE(mdev, id_table); > >> + =20 > > Two questions, first we have: > > > > #define MODULE_DEVICE_TABLE(type, name) = \ > > extern typeof(name) __mod_##type##__##name##_device_table = \ > > __attribute__ ((unused, alias(__stringify(name)))) > > > > Therefore we're defining __mod_mdev__id_table_device_table with alias > > id_table. When the virtio mdev bus driver is added in 5/6 it uses the > > same name value. I see virtio types all register this way (virtio, > > id_table), so I assume there's no conflict, but pci types mostly (not > > entirely) seem to use unique names. Is there a preference to one way > > or the other or it simply doesn't matter? =20 >=20 >=20 > It looks to me that those symbol were local, so it doesn't matter. But=20 > if you wish I can switch to use unique name. I don't have a strong opinion, I'm just trying to make sure we're not doing something obviously broken. > >> static struct mdev_driver vfio_mdev_driver =3D { > >> =09.name=09=3D "vfio_mdev", > >> =09.probe=09=3D vfio_mdev_probe, > >> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetab= le-offsets.c > >> index 054405b90ba4..6cbb1062488a 100644 > >> --- a/scripts/mod/devicetable-offsets.c > >> +++ b/scripts/mod/devicetable-offsets.c > >> @@ -231,5 +231,8 @@ int main(void) > >> =09DEVID(wmi_device_id); > >> =09DEVID_FIELD(wmi_device_id, guid_string); > >> =20 > >> +=09DEVID(mdev_class_id); > >> +=09DEVID_FIELD(mdev_class_id, id); > >> + > >> =09return 0; > >> } > >> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > >> index c91eba751804..d365dfe7c718 100644 > >> --- a/scripts/mod/file2alias.c > >> +++ b/scripts/mod/file2alias.c > >> @@ -1335,6 +1335,15 @@ static int do_wmi_entry(const char *filename, v= oid *symval, char *alias) > >> =09return 1; > >> } > >> =20 > >> +/* looks like: "mdev:cN" */ > >> +static int do_mdev_entry(const char *filename, void *symval, char *al= ias) > >> +{ > >> +=09DEF_FIELD(symval, mdev_class_id, id); > >> + > >> +=09sprintf(alias, "mdev:c%02X", id); =20 > > A lot of entries call add_wildcard() here, should we? Sorry for the > > basic questions, I haven't played in this code. Thanks, =20 >=20 >=20 > It's really good question. My understanding is we won't have a module=20 > that can deal with all kinds of classes like CLASS_ID_ANY. So there's=20 > probably no need for the wildcard. The comment for add_wildcard() indicates future extension, so it's hard to know what we might need in the future until we do need it. The majority of modules.alias entries on my laptop (even if I exclude pci aliases) end with a wildcard. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFDDCA9EBB for ; Thu, 24 Oct 2019 19:55:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAEB52166E for ; Thu, 24 Oct 2019 19:55:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAEB52166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDA2A6E787; Thu, 24 Oct 2019 19:55:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DBEC6E781 for ; Thu, 24 Oct 2019 19:55:02 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-rQGSdyFqNNOUITf7Nv_epw-1; Thu, 24 Oct 2019 15:54:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85A4947B; Thu, 24 Oct 2019 19:54:54 +0000 (UTC) Received: from x1.home (ovpn-118-102.phx2.redhat.com [10.3.118.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EB675D9D5; Thu, 24 Oct 2019 19:54:42 +0000 (UTC) Date: Thu, 24 Oct 2019 13:54:41 -0600 From: Alex Williamson To: Jason Wang Message-ID: <20191024135441.160daa56@x1.home> In-Reply-To: <555a101e-0ed1-2e9d-c1a4-e3b37d76bd18@redhat.com> References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-3-jasowang@redhat.com> <20191023154245.32e4fa49@x1.home> <555a101e-0ed1-2e9d-c1a4-e3b37d76bd18@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: rQGSdyFqNNOUITf7Nv_epw-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571946900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=46JWhWsVeq/tB0Aj5YNxoiRSmrwdl+Kq9BaeK3ujO0U=; b=DFyau+12Pf776Ra8ToZbfReIJM3hr50lO1EqlGKpxMWpK9hKxLtlHi8EfiH8kRtmVZdQoy JpVJ1IDyNc/Pr/+n55GZM09pcm0m0bUta4d7Y+ih7FqD71L+yAQS45IKjw0MPpLgdzHqOs uuu/uL7ZxjoMq54T7hQLBG/3061NeOg= Subject: Re: [Intel-gfx] [PATCH V5 2/6] modpost: add support for mdev class id X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191024195441.hW5i5zhT4dRsbBiGL9G9FEi8vJ8Hwmjuqe9U99_i_M4@z> T24gVGh1LCAyNCBPY3QgMjAxOSAxMTozMTowNCArMDgwMApKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPiB3cm90ZToKCj4gT24gMjAxOS8xMC8yNCDkuIrljYg1OjQyLCBBbGV4IFdpbGxp YW1zb24gd3JvdGU6Cj4gPiBPbiBXZWQsIDIzIE9jdCAyMDE5IDIxOjA3OjQ4ICswODAwCj4gPiBK YXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPiA+ICAKPiA+PiBBZGQgc3Vw cG9ydCB0byBwYXJzZSBtZGV2IGNsYXNzIGlkIHRhYmxlLgo+ID4+Cj4gPj4gUmV2aWV3ZWQtYnk6 IFBhcmF2IFBhbmRpdCA8cGFyYXZAbWVsbGFub3guY29tPgo+ID4+IFNpZ25lZC1vZmYtYnk6IEph c29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4gPj4gLS0tCj4gPj4gICBkcml2ZXJzL3Zm aW8vbWRldi92ZmlvX21kZXYuYyAgICAgfCAgMiArKwo+ID4+ICAgc2NyaXB0cy9tb2QvZGV2aWNl dGFibGUtb2Zmc2V0cy5jIHwgIDMgKysrCj4gPj4gICBzY3JpcHRzL21vZC9maWxlMmFsaWFzLmMg ICAgICAgICAgfCAxMCArKysrKysrKysrCj4gPj4gICAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2Vy dGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8vbWRldi92ZmlvX21k ZXYuYyBiL2RyaXZlcnMvdmZpby9tZGV2L3ZmaW9fbWRldi5jCj4gPj4gaW5kZXggN2IyNGVlOWNi OGRkLi5jYjcwMWNkNjQ2ZjAgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy92ZmlvL21kZXYvdmZp b19tZGV2LmMKPiA+PiArKysgYi9kcml2ZXJzL3ZmaW8vbWRldi92ZmlvX21kZXYuYwo+ID4+IEBA IC0xMjUsNiArMTI1LDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBtZGV2X2NsYXNzX2lkIGlkX3Rh YmxlW10gPSB7Cj4gPj4gICAJeyAwIH0sCj4gPj4gICB9Owo+ID4+ICAgCj4gPj4gK01PRFVMRV9E RVZJQ0VfVEFCTEUobWRldiwgaWRfdGFibGUpOwo+ID4+ICsgIAo+ID4gVHdvIHF1ZXN0aW9ucywg Zmlyc3Qgd2UgaGF2ZToKPiA+Cj4gPiAjZGVmaW5lIE1PRFVMRV9ERVZJQ0VfVEFCTEUodHlwZSwg bmFtZSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4gPiBleHRlcm4gdHlwZW9m KG5hbWUpIF9fbW9kXyMjdHlwZSMjX18jI25hbWUjI19kZXZpY2VfdGFibGUgICAgICAgICAgICAg ICBcCj4gPiAgICBfX2F0dHJpYnV0ZV9fICgodW51c2VkLCBhbGlhcyhfX3N0cmluZ2lmeShuYW1l KSkpKQo+ID4KPiA+IFRoZXJlZm9yZSB3ZSdyZSBkZWZpbmluZyBfX21vZF9tZGV2X19pZF90YWJs ZV9kZXZpY2VfdGFibGUgd2l0aCBhbGlhcwo+ID4gaWRfdGFibGUuICBXaGVuIHRoZSB2aXJ0aW8g bWRldiBidXMgZHJpdmVyIGlzIGFkZGVkIGluIDUvNiBpdCB1c2VzIHRoZQo+ID4gc2FtZSBuYW1l IHZhbHVlLiAgSSBzZWUgdmlydGlvIHR5cGVzIGFsbCByZWdpc3RlciB0aGlzIHdheSAodmlydGlv LAo+ID4gaWRfdGFibGUpLCBzbyBJIGFzc3VtZSB0aGVyZSdzIG5vIGNvbmZsaWN0LCBidXQgcGNp IHR5cGVzIG1vc3RseSAobm90Cj4gPiBlbnRpcmVseSkgc2VlbSB0byB1c2UgdW5pcXVlIG5hbWVz LiAgSXMgdGhlcmUgYSBwcmVmZXJlbmNlIHRvIG9uZSB3YXkKPiA+IG9yIHRoZSBvdGhlciBvciBp dCBzaW1wbHkgZG9lc24ndCBtYXR0ZXI/ICAKPiAKPiAKPiBJdCBsb29rcyB0byBtZSB0aGF0IHRo b3NlIHN5bWJvbCB3ZXJlIGxvY2FsLCBzbyBpdCBkb2Vzbid0IG1hdHRlci4gQnV0IAo+IGlmIHlv dSB3aXNoIEkgY2FuIHN3aXRjaCB0byB1c2UgdW5pcXVlIG5hbWUuCgpJIGRvbid0IGhhdmUgYSBz dHJvbmcgb3BpbmlvbiwgSSdtIGp1c3QgdHJ5aW5nIHRvIG1ha2Ugc3VyZSB3ZSdyZSBub3QKZG9p bmcgc29tZXRoaW5nIG9idmlvdXNseSBicm9rZW4uCgo+ID4+ICAgc3RhdGljIHN0cnVjdCBtZGV2 X2RyaXZlciB2ZmlvX21kZXZfZHJpdmVyID0gewo+ID4+ICAgCS5uYW1lCT0gInZmaW9fbWRldiIs Cj4gPj4gICAJLnByb2JlCT0gdmZpb19tZGV2X3Byb2JlLAo+ID4+IGRpZmYgLS1naXQgYS9zY3Jp cHRzL21vZC9kZXZpY2V0YWJsZS1vZmZzZXRzLmMgYi9zY3JpcHRzL21vZC9kZXZpY2V0YWJsZS1v ZmZzZXRzLmMKPiA+PiBpbmRleCAwNTQ0MDViOTBiYTQuLjZjYmIxMDYyNDg4YSAxMDA2NDQKPiA+ PiAtLS0gYS9zY3JpcHRzL21vZC9kZXZpY2V0YWJsZS1vZmZzZXRzLmMKPiA+PiArKysgYi9zY3Jp cHRzL21vZC9kZXZpY2V0YWJsZS1vZmZzZXRzLmMKPiA+PiBAQCAtMjMxLDUgKzIzMSw4IEBAIGlu dCBtYWluKHZvaWQpCj4gPj4gICAJREVWSUQod21pX2RldmljZV9pZCk7Cj4gPj4gICAJREVWSURf RklFTEQod21pX2RldmljZV9pZCwgZ3VpZF9zdHJpbmcpOwo+ID4+ICAgCj4gPj4gKwlERVZJRCht ZGV2X2NsYXNzX2lkKTsKPiA+PiArCURFVklEX0ZJRUxEKG1kZXZfY2xhc3NfaWQsIGlkKTsKPiA+ PiArCj4gPj4gICAJcmV0dXJuIDA7Cj4gPj4gICB9Cj4gPj4gZGlmZiAtLWdpdCBhL3NjcmlwdHMv bW9kL2ZpbGUyYWxpYXMuYyBiL3NjcmlwdHMvbW9kL2ZpbGUyYWxpYXMuYwo+ID4+IGluZGV4IGM5 MWViYTc1MTgwNC4uZDM2NWRmZTdjNzE4IDEwMDY0NAo+ID4+IC0tLSBhL3NjcmlwdHMvbW9kL2Zp bGUyYWxpYXMuYwo+ID4+ICsrKyBiL3NjcmlwdHMvbW9kL2ZpbGUyYWxpYXMuYwo+ID4+IEBAIC0x MzM1LDYgKzEzMzUsMTUgQEAgc3RhdGljIGludCBkb193bWlfZW50cnkoY29uc3QgY2hhciAqZmls ZW5hbWUsIHZvaWQgKnN5bXZhbCwgY2hhciAqYWxpYXMpCj4gPj4gICAJcmV0dXJuIDE7Cj4gPj4g ICB9Cj4gPj4gICAKPiA+PiArLyogbG9va3MgbGlrZTogIm1kZXY6Y04iICovCj4gPj4gK3N0YXRp YyBpbnQgZG9fbWRldl9lbnRyeShjb25zdCBjaGFyICpmaWxlbmFtZSwgdm9pZCAqc3ltdmFsLCBj aGFyICphbGlhcykKPiA+PiArewo+ID4+ICsJREVGX0ZJRUxEKHN5bXZhbCwgbWRldl9jbGFzc19p ZCwgaWQpOwo+ID4+ICsKPiA+PiArCXNwcmludGYoYWxpYXMsICJtZGV2OmMlMDJYIiwgaWQpOyAg Cj4gPiBBIGxvdCBvZiBlbnRyaWVzIGNhbGwgYWRkX3dpbGRjYXJkKCkgaGVyZSwgc2hvdWxkIHdl PyAgU29ycnkgZm9yIHRoZQo+ID4gYmFzaWMgcXVlc3Rpb25zLCBJIGhhdmVuJ3QgcGxheWVkIGlu IHRoaXMgY29kZS4gIFRoYW5rcywgIAo+IAo+IAo+IEl0J3MgcmVhbGx5IGdvb2QgcXVlc3Rpb24u IE15IHVuZGVyc3RhbmRpbmcgaXMgd2Ugd29uJ3QgaGF2ZSBhIG1vZHVsZSAKPiB0aGF0IGNhbiBk ZWFsIHdpdGggYWxsIGtpbmRzIG9mIGNsYXNzZXMgbGlrZSBDTEFTU19JRF9BTlkuIFNvIHRoZXJl J3MgCj4gcHJvYmFibHkgbm8gbmVlZCBmb3IgdGhlIHdpbGRjYXJkLgoKVGhlIGNvbW1lbnQgZm9y IGFkZF93aWxkY2FyZCgpIGluZGljYXRlcyBmdXR1cmUgZXh0ZW5zaW9uLCBzbyBpdCdzIGhhcmQK dG8ga25vdyB3aGF0IHdlIG1pZ2h0IG5lZWQgaW4gdGhlIGZ1dHVyZSB1bnRpbCB3ZSBkbyBuZWVk IGl0LiAgVGhlCm1ham9yaXR5IG9mIG1vZHVsZXMuYWxpYXMgZW50cmllcyBvbiBteSBsYXB0b3Ag KGV2ZW4gaWYgSSBleGNsdWRlIHBjaQphbGlhc2VzKSBlbmQgd2l0aCBhIHdpbGRjYXJkLiAgVGhh bmtzLAoKQWxleAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4