From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm: share address space for dma bufs Date: Thu, 21 Nov 2019 14:55:48 +0100 Message-ID: <20191121135548.GF6236@phenom.ffwll.local> References: <20191121103807.18424-1-kraxel@redhat.com> <20191121103807.18424-3-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191121103807.18424-3-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , open list List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 21, 2019 at 11:38:07AM +0100, Gerd Hoffmann wrote: > Use the shared address space of the drm device (see drm_open() in > drm_file.c) for dma-bufs too. That removes a difference betweem drm > device mmap vmas and dma-buf mmap vmas and fixes corner cases like > unmaps not working properly. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/drm_prime.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c > index a9633bd241bb..c3fc341453c0 100644 > --- a/drivers/gpu/drm/drm_prime.c > +++ b/drivers/gpu/drm/drm_prime.c > @@ -240,6 +240,7 @@ void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv) > struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev, > struct dma_buf_export_info *exp_info) > { > + struct drm_gem_object *obj = exp_info->priv; > struct dma_buf *dma_buf; > > dma_buf = dma_buf_export(exp_info); > @@ -247,7 +248,8 @@ struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev, > return dma_buf; > > drm_dev_get(dev); > - drm_gem_object_get(exp_info->priv); > + drm_gem_object_get(obj); > + dma_buf->file->f_mapping = obj->dev->anon_inode->i_mapping; Can you pls also throw the change to amdgpu_gem_prime_export on top here? Imo makes a lot more sense that way. With that added I'm happy to r-b. -Daniel > > return dma_buf; > } > -- > 2.18.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B85C432C0 for ; Thu, 21 Nov 2019 13:55:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B9BF20714 for ; Thu, 21 Nov 2019 13:55:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B9BF20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1B5F6EF38; Thu, 21 Nov 2019 13:55:53 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 995316EF41 for ; Thu, 21 Nov 2019 13:55:52 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id x26so3523280wmk.4 for ; Thu, 21 Nov 2019 05:55:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=9ySz0CwRZWHJZeoXGkyjArkEnAI6EPJLUR1wbzYKrBQ=; b=PgqlmrumRJujUOaLctLeaHnKnbF+DwFzq+WtqPL6LKqsEDgv9PoR9qGvwz9Wk4o2Mg 6DUeYWV/M4tJw6K/aiTLDjx7JbkHkozu3QcrMdOui357sXJna/qOyXaxqr7dAaJFiCmG X+ai9gPwOLqo6/EhtX+KVi3/C2/mbceDXSA/RRyWpEGCC45mk0Ljh8WD4ro+pX/v4IFc 34mKkB/QmMuiFmR6Xw5FhlAJeH9ENWVqFeJztFSrsTvLVq4LOrvGu8eChNP29Sx2ztsC A2KkIJQakHd72OvV1tyP6O+B71/AXs1IcB9mojmezw+Z9clLMyfyoyx8A7Kj5go61BiY GPFA== X-Gm-Message-State: APjAAAVkjJSGfJ/2gScMKjXtvhRdvdIBy/z2zWBitySn1ZEJUv/WAq4A aOIESY4WW6mFAJxGxZnksJrkLg== X-Google-Smtp-Source: APXvYqyPjxCiSx6aRgQWwIldMrYfO6t2JwKnW+USv8OSUlMJ3Cgu+UrDu2H7r9eK85r7VgG7mWz6yA== X-Received: by 2002:a05:600c:2257:: with SMTP id a23mr10535918wmm.143.1574344551219; Thu, 21 Nov 2019 05:55:51 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id q5sm2956771wmc.27.2019.11.21.05.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 05:55:50 -0800 (PST) Date: Thu, 21 Nov 2019 14:55:48 +0100 From: Daniel Vetter To: Gerd Hoffmann Message-ID: <20191121135548.GF6236@phenom.ffwll.local> Mail-Followup-To: Gerd Hoffmann , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , open list References: <20191121103807.18424-1-kraxel@redhat.com> <20191121103807.18424-3-kraxel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191121103807.18424-3-kraxel@redhat.com> X-Operating-System: Linux phenom 5.3.0-1-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9ySz0CwRZWHJZeoXGkyjArkEnAI6EPJLUR1wbzYKrBQ=; b=NXvERH9x28CAg2d7Yb67iVNC5YQ/S+Mx85h8A/BauEU7nfIXLInBktQXN0epsENDlP 9Ccqiw+qy2rPeiXmtSZ78sJMmK4f2IAr6MFPNm7WgdSCO0K0nvL4R39ngGn5X0ipbI1u Y7IRB3tc3iGQupgccPGXN/bfAnS81ytVunXfU= Subject: Re: [Intel-gfx] [PATCH 2/2] drm: share address space for dma bufs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , Maxime Ripard , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191121135548.3o7GJIDV4KLdQe1kB8wHTruFKYPzeZWg8keHB0oDlfk@z> T24gVGh1LCBOb3YgMjEsIDIwMTkgYXQgMTE6Mzg6MDdBTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBVc2UgdGhlIHNoYXJlZCBhZGRyZXNzIHNwYWNlIG9mIHRoZSBkcm0gZGV2aWNlIChz ZWUgZHJtX29wZW4oKSBpbgo+IGRybV9maWxlLmMpIGZvciBkbWEtYnVmcyB0b28uICBUaGF0IHJl bW92ZXMgYSBkaWZmZXJlbmNlIGJldHdlZW0gZHJtCj4gZGV2aWNlIG1tYXAgdm1hcyBhbmQgZG1h LWJ1ZiBtbWFwIHZtYXMgYW5kIGZpeGVzIGNvcm5lciBjYXNlcyBsaWtlCj4gdW5tYXBzIG5vdCB3 b3JraW5nIHByb3Blcmx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEdlcmQgSG9mZm1hbm4gPGtyYXhl bEByZWRoYXQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMgfCA0ICsr Ky0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX3ByaW1lLmMKPiBpbmRleCBhOTYzM2JkMjQxYmIuLmMzZmMzNDE0NTNjMCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX3ByaW1lLmMKPiBAQCAtMjQwLDYgKzI0MCw3IEBAIHZvaWQgZHJtX3ByaW1lX2Rlc3Ry b3lfZmlsZV9wcml2YXRlKHN0cnVjdCBkcm1fcHJpbWVfZmlsZV9wcml2YXRlICpwcmltZV9mcHJp dikKPiAgc3RydWN0IGRtYV9idWYgKmRybV9nZW1fZG1hYnVmX2V4cG9ydChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LAo+ICAJCQkJICAgICAgc3RydWN0IGRtYV9idWZfZXhwb3J0X2luZm8gKmV4cF9p bmZvKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiA9IGV4cF9pbmZvLT5wcml2 Owo+ICAJc3RydWN0IGRtYV9idWYgKmRtYV9idWY7Cj4gIAo+ICAJZG1hX2J1ZiA9IGRtYV9idWZf ZXhwb3J0KGV4cF9pbmZvKTsKPiBAQCAtMjQ3LDcgKzI0OCw4IEBAIHN0cnVjdCBkbWFfYnVmICpk cm1fZ2VtX2RtYWJ1Zl9leHBvcnQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlyZXR1cm4g ZG1hX2J1ZjsKPiAgCj4gIAlkcm1fZGV2X2dldChkZXYpOwo+IC0JZHJtX2dlbV9vYmplY3RfZ2V0 KGV4cF9pbmZvLT5wcml2KTsKPiArCWRybV9nZW1fb2JqZWN0X2dldChvYmopOwo+ICsJZG1hX2J1 Zi0+ZmlsZS0+Zl9tYXBwaW5nID0gb2JqLT5kZXYtPmFub25faW5vZGUtPmlfbWFwcGluZzsKCkNh biB5b3UgcGxzIGFsc28gdGhyb3cgdGhlIGNoYW5nZSB0byBhbWRncHVfZ2VtX3ByaW1lX2V4cG9y dCBvbiB0b3AgaGVyZT8KSW1vIG1ha2VzIGEgbG90IG1vcmUgc2Vuc2UgdGhhdCB3YXkuIFdpdGgg dGhhdCBhZGRlZCBJJ20gaGFwcHkgdG8gci1iLgotRGFuaWVsCgo+ICAKPiAgCXJldHVybiBkbWFf YnVmOwo+ICB9Cj4gLS0gCj4gMi4xOC4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4