From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DA6C4D2C4 for ; Fri, 13 Dec 2019 20:54:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02A60246A5 for ; Fri, 13 Dec 2019 20:54:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02A60246A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FF126EB5C; Fri, 13 Dec 2019 17:17:43 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id B30E86EB5C for ; Fri, 13 Dec 2019 17:17:42 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 09:17:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="265584749" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 13 Dec 2019 09:17:39 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 13 Dec 2019 19:17:39 +0200 Date: Fri, 13 Dec 2019 19:17:39 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson Message-ID: <20191213171739.GC1208@intel.com> References: <20191213152823.26817-1-ville.syrjala@linux.intel.com> <157625247338.7535.668231195608100084@skylake-alporthouse-com> <20191213170601.GB1208@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191213170601.GB1208@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Dec 13, 2019 at 07:06:01PM +0200, Ville Syrj=E4l=E4 wrote: > On Fri, Dec 13, 2019 at 03:54:33PM +0000, Chris Wilson wrote: > > Quoting Ville Syrjala (2019-12-13 15:28:23) > > > From: Ville Syrj=E4l=E4 > > > = > > > Include dev_name() in the tracpoints so one can filter based on > > > the device. > > > = > > > Example: > > > echo 'dev=3D=3D"0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/= filter > > > = > > > TODO: maybe don't both specifying the field name always and just > > > make it 'dev' (or whatever) always? > > > TODO: add for other tracpoints too if this is deemed good enough > > > = > > > Suggested-by: Chris Wilson > > > Signed-off-by: Ville Syrj=E4l=E4 > > > --- > > > drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++--------= -- > > > 1 file changed, 65 insertions(+), 31 deletions(-) > > > = > > > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915= /i915_trace.h > > > index 7ef7a1e1664c..8931b6756f44 100644 > > > --- a/drivers/gpu/drm/i915/i915_trace.h > > > +++ b/drivers/gpu/drm/i915/i915_trace.h > > > @@ -20,11 +20,18 @@ > > > = > > > /* watermark/fifo updates */ > > > = > > > +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)= ->drm.dev)) > > > +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)= ->base.dev->dev)) > > > +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_= name((i915)->drm.dev)) > > > +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_= name((crtc)->base.dev->dev)) > > > +#define __get_dev_name(field) __get_str(field) > > = > > Storing the string is quite expensive, I thought. Can we stash the i915 > > and stringify in the TP_printk? Or is stashing the string the secret for > > the dev=3D=3D filter? > = > Last time I stashed a pointer in there people complained that it can > disappear before being consumed and cause a very theoretical oops. > But I guess we could stash just the pci devfn and whatnot. I believe 'domain + bus + devfn' would amount to 4 bytes. The downside is that it'd be just an integer so we'd lose the dev=3Ddomain:bus:dev.fn syntax for the filter. Suppose I could try to implement a new filter type for it, but no guarantees that would get accepted. Seems a bit too pci specific for kernel/trace/. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx