From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD662C32771 for ; Thu, 9 Jan 2020 11:30:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97B992067D for ; Thu, 9 Jan 2020 11:30:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97B992067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7890C6E3E7; Thu, 9 Jan 2020 11:30:01 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 261166E3E1; Thu, 9 Jan 2020 11:30:00 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 03:29:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208,217";a="223851703" Received: from plaxmina-desktop.iind.intel.com ([10.106.124.119]) by orsmga003.jf.intel.com with ESMTP; 09 Jan 2020 03:29:56 -0800 Date: Thu, 9 Jan 2020 16:55:13 +0530 From: "Bharadiya,Pankaj" To: Jani Nikula Message-ID: <20200109112513.GA19403@plaxmina-desktop.iind.intel.com> References: <20200106172326.32592-1-pankaj.laxminarayan.bharadiya@intel.com> <20200106172326.32592-6-pankaj.laxminarayan.bharadiya@intel.com> <87d0buqff1.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87d0buqff1.fsf@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [RFC 5/7] drm/i915: Make WARN* device specific where drm_priv ptr is available X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: irlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jan 08, 2020 at 02:52:02PM +0200, Jani Nikula wrote: > On Mon, 06 Jan 2020, Pankaj Bharadiya wrote: > > Device specific WARN* calls include device information in the > > backtrace, so we know what device the warnings originate from. > > > > Covert all the calls of WARN* with device specific dev_WARN* > > variants in functions where drm_i915_private struct pointer is readily > > available. > > > > The conversion was done automatically with below coccinelle semantic > > patch. checkpatch errors/warnings are fixed manually. > > > > @rule1@ > > identifier func, T; > > @@ > > func(...) { > > ... > > struct drm_i915_private *T = ...; > > +struct device *dev = i915_to_dev(T); > > <+... > > ( > > -WARN( > > +dev_WARN(dev, > > ...) > > | > > -WARN_ON( > > +dev_WARN_ON(dev, > > ...) > > | > > -WARN_ONCE( > > +dev_WARN_ONCE(dev, > > ...) > > | > > -WARN_ON_ONCE( > > +dev_WARN_ON_ONCE(dev, > > ...) > > ) > > ...+> > > } > > > > @rule2@ > > identifier func, T; > > @@ > > func(struct drm_i915_private *T,...) { > > +struct device *dev = i915_to_dev(T); > > <+... > > ( > > -WARN( > > +dev_WARN(dev, > > ...) > > | > > -WARN_ON( > > +dev_WARN_ON(dev, > > ...) > > | > > -WARN_ONCE( > > +dev_WARN_ONCE(dev, > > ...) > > | > > -WARN_ON_ONCE( > > +dev_WARN_ON_ONCE(dev, > > ...) > > ) > > ...+> > > } > > > > command: spatch --sp-file