[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client engine busyness (rev3)

Patchwork
2020-01-10T16:26:22Z

== Series Details ==

Series: Per client engine busyness (rev3)
URL : https://patchwork.freedesktop.org/series/70977/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f2a2ab0fb90e drm/i915: Expose list of clients in sysfs
-:61: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#61:
new file mode 100644

-:66: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#66: FILE: drivers/gpu/drm/i915/i915_drm_client.c:1:
+/*

-:67: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#67: FILE: drivers/gpu/drm/i915/i915_drm_client.c:2:
+ * SPDX-License-Identifier: MIT

-:222: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#222: FILE: drivers/gpu/drm/i915/i915_drm_client.h:1:
+/*

-:223: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#223: FILE: drivers/gpu/drm/i915/i915_drm_client.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 338 lines checked
4cd0960d1b2d drm/i915: Update client name on context create
b69ea9c5500b drm/i915: Track per-context engine busyness
3878342bf2cc drm/i915: Track all user contexts per client
-:56: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#56: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:808:
+ ctx->client = client = i915_drm_client_get(fpriv->client);

-:116: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#116: FILE: drivers/gpu/drm/i915/i915_drm_client.h:35:
+ spinlock_t ctx_lock;

total: 0 errors, 0 warnings, 2 checks, 84 lines checked
342d49e806c4 drm/i915: Contexts can use struct pid stored in the client
eb3f14196571 drm/i915: Expose per-engine client busyness
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25:
Render/3D/0 63.73% |███████████████████ | 3% 0%

-:107: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#107: FILE: drivers/gpu/drm/i915/i915_drm_client.c:82:
+static const char *uabi_class_names[] = {

-:132: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: drivers/gpu/drm/i915/i915_drm_client.c:133:
+ if (HAS_LOGICAL_RING_CONTEXTS(i915)) {$

-:132: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 16)
#132: FILE: drivers/gpu/drm/i915/i915_drm_client.c:133:
+ if (HAS_LOGICAL_RING_CONTEXTS(i915)) {
+ client->busy_root =

-:189: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: drivers/gpu/drm/i915/i915_drm_client.c:190:
+ }$

total: 0 errors, 5 warnings, 0 checks, 198 lines checked
0f5c8f1a3375 drm/i915: Track hw reported context runtime
-:72: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#72: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1314:
+ ce->last_runtime = new = ce->pphwsp[16];

total: 0 errors, 0 warnings, 1 checks, 70 lines checked
82e4aff984e7 drm/i915: Fallback to hw context runtime when sw tracking is not available