From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A34C33CB1 for ; Fri, 17 Jan 2020 15:37:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C422A2072E for ; Fri, 17 Jan 2020 15:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C422A2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 703636F5FB; Fri, 17 Jan 2020 15:37:57 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41D6A6F5FB for ; Fri, 17 Jan 2020 15:37:56 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 07:37:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="243698463" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 17 Jan 2020 07:37:17 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 17 Jan 2020 17:37:16 +0200 Date: Fri, 17 Jan 2020 17:37:16 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: <20200117153716.GT13686@intel.com> References: <4338a29e4ed49e69f859dff1490fd85f6ae6177e.1579270868.git.jani.nikula@intel.com> <20200117151238.GP13686@intel.com> <20200117151325.GQ13686@intel.com> <87d0bigl0o.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87d0bigl0o.fsf@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 8/9] drm/i915/bios: check port presence based on child device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jan 17, 2020 at 05:28:23PM +0200, Jani Nikula wrote: > On Fri, 17 Jan 2020, Ville Syrj=E4l=E4 wr= ote: > > On Fri, Jan 17, 2020 at 05:12:38PM +0200, Ville Syrj=E4l=E4 wrote: > >> On Fri, Jan 17, 2020 at 04:29:28PM +0200, Jani Nikula wrote: > >> > Affects only two calls in output setup, and ddi init will check the > >> > features in more fine grained way. > >> > = > >> > This will make future changes easier. > >> > = > >> > Signed-off-by: Jani Nikula > >> > --- > >> > drivers/gpu/drm/i915/display/intel_bios.c | 4 +--- > >> > 1 file changed, 1 insertion(+), 3 deletions(-) > >> > = > >> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu= /drm/i915/display/intel_bios.c > >> > index 4c69253739ec..70fb87e7afb6 100644 > >> > --- a/drivers/gpu/drm/i915/display/intel_bios.c > >> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > >> > @@ -2236,9 +2236,7 @@ bool intel_bios_is_port_present(struct drm_i91= 5_private *dev_priv, enum port por > >> > const struct ddi_vbt_port_info *port_info =3D > >> > &dev_priv->vbt.ddi_port_info[port]; > >> > = > >> > - return port_info->supports_dp || > >> > - port_info->supports_dvi || > >> > - port_info->supports_hdmi; > >> > + return port_info->child; > >> = > >> Pondering what happens if there's a non-DP/DVI/HDMI port declared in t= he > >> VBT... I guess those should not have their dvo port set to anything we > >> accept? > > > > Umm, no. We accept DVO_PORT_CRT as PORT_E. > = > My argument is this: > = > - Shouldn't intel_bios_is_port_present(PORT_E) return true in that case? Only on hsw/bdw really. > = > - Where does the change make a functional difference in the > intel_bios_is_port_present() users anyway? AFAICT all the cases will > also check the supports_X flags anyway (or have checked before). After some trawling I can't see anything that should break from this, so probably fine. But the commit message should probably elaborate on this a bit more, just in case there is a regression. Reviewed-by: Ville Syrj=E4l=E4 > = > = > BR, > Jani. > = > = > > > >> = > >> > } > >> > = > >> > /* FIXME maybe deal with port A as well? */ > >> > -- = > >> > 2.20.1 > >> > = > >> > _______________________________________________ > >> > Intel-gfx mailing list > >> > Intel-gfx@lists.freedesktop.org > >> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > >> = > >> -- = > >> Ville Syrj=E4l=E4 > >> Intel > = > -- = > Jani Nikula, Intel Open Source Graphics Center -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx