From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC98DC2D0DB for ; Tue, 21 Jan 2020 09:13:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99B4020882 for ; Tue, 21 Jan 2020 09:13:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99B4020882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 215C06EC07; Tue, 21 Jan 2020 09:13:13 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A7F96EC06; Tue, 21 Jan 2020 09:13:11 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8FDAE20027; Tue, 21 Jan 2020 10:13:07 +0100 (CET) Date: Tue, 21 Jan 2020 10:13:06 +0100 From: Sam Ravnborg To: Jani Nikula Message-ID: <20200121091306.GA29647@ravnborg.org> References: <20200115034455.17658-1-pankaj.laxminarayan.bharadiya@intel.com> <20200115034455.17658-2-pankaj.laxminarayan.bharadiya@intel.com> <87y2u9jav8.fsf@intel.com> <87muahfbjt.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87muahfbjt.fsf@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=QyXUC8HyAAAA:8 a=7gkXJVJtAAAA:8 a=ARxESuRSxSw8adp43KQA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 Subject: Re: [Intel-gfx] [ [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jan 21, 2020 at 10:39:34AM +0200, Jani Nikula wrote: > On Wed, 15 Jan 2020, Jani Nikula wrote: > > On Wed, 15 Jan 2020, Pankaj Bharadiya wrote: > >> Add new struct drm_device based WARN* macros. These are modeled after > >> the core kernel device based WARN* macros. These would be preferred > >> over the regular WARN* macros, where possible. > >> > >> These macros include device information in the backtrace, so we know > >> what device the warnings originate from. > >> > >> Knowing the device specific information in the backtrace would be > >> helpful in development all around. > >> > >> Signed-off-by: Pankaj Bharadiya > > > > Reviewed-by: Jani Nikula > > All, I'd really appreciate acks or reviews on this one to unblock the > rest. I think the patch is fine, but I'd like wider approval before > merging. Patch looks good: Reviewed-by: Sam Ravnborg Sam _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx