From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19CAC2D0DB for ; Fri, 24 Jan 2020 12:24:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B89B6206D4 for ; Fri, 24 Jan 2020 12:24:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B89B6206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 566106FA4F; Fri, 24 Jan 2020 12:24:49 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90AFF6FA4F for ; Fri, 24 Jan 2020 12:24:48 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 04:24:48 -0800 X-IronPort-AV: E=Sophos;i="5.70,357,1574150400"; d="scan'208";a="216576421" Received: from ideak-desk.fi.intel.com ([10.237.72.183]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 04:24:46 -0800 Date: Fri, 24 Jan 2020 14:24:40 +0200 From: Imre Deak To: Ville Syrjala Message-ID: <20200124122440.GA32347@ideak-desk.fi.intel.com> References: <20200120174728.21095-1-ville.syrjala@linux.intel.com> <20200120174728.21095-7-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200120174728.21095-7-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH 06/17] drm/i915: s/need_cd2x_updare/can_cd2x_update/ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Jan 20, 2020 at 07:47:16PM +0200, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > intel_cdclk_needs_cd2x_update() is named rather confusingly. > We don't have to do a cd2x update, rather we are allowed to > do one (as opposed to a full PLL reprogramming with its heavy > handed modeset). So let's rename the function to > intel_cdclk_can_cd2x_update(). > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm= /i915/display/intel_cdclk.c > index f7f886dcd6ae..9d4cf412b65d 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -1767,7 +1767,7 @@ bool intel_cdclk_needs_modeset(const struct intel_c= dclk_state *a, > } > = > /** > - * intel_cdclk_needs_cd2x_update - Determine if two CDCLK states require= a cd2x divider update > + * intel_cdclk_can_cd2x_update - Determine if two CDCLK states need a cd= 2x divider update > * @dev_priv: Not a CDCLK state, it's the drm_i915_private! > * @a: first CDCLK state > * @b: second CDCLK state > @@ -1775,9 +1775,9 @@ bool intel_cdclk_needs_modeset(const struct intel_c= dclk_state *a, > * Returns: > * True if the CDCLK states require just a cd2x divider update, false if= not. > */ > -static bool intel_cdclk_needs_cd2x_update(struct drm_i915_private *dev_p= riv, > - const struct intel_cdclk_state *a, > - const struct intel_cdclk_state *b) > +static bool intel_cdclk_can_cd2x_update(struct drm_i915_private *dev_pri= v, > + const struct intel_cdclk_state *a, > + const struct intel_cdclk_state *b) > { > /* Older hw doesn't have the capability */ > if (INTEL_GEN(dev_priv) < 10 && !IS_GEN9_LP(dev_priv)) > @@ -2393,9 +2393,9 @@ int intel_modeset_calc_cdclk(struct intel_atomic_st= ate *state) > } > = > if (is_power_of_2(state->active_pipes) && > - intel_cdclk_needs_cd2x_update(dev_priv, > - &dev_priv->cdclk.actual, > - &state->cdclk.actual)) { > + intel_cdclk_can_cd2x_update(dev_priv, > + &dev_priv->cdclk.actual, > + &state->cdclk.actual)) { > struct intel_crtc *crtc; > struct intel_crtc_state *crtc_state; > = > -- = > 2.24.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx