From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5C6C2D0DB for ; Fri, 24 Jan 2020 15:24:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36C4420702 for ; Fri, 24 Jan 2020 15:24:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36C4420702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE1AD72AE8; Fri, 24 Jan 2020 15:24:46 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86D6C72AE8 for ; Fri, 24 Jan 2020 15:24:45 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 07:19:30 -0800 X-IronPort-AV: E=Sophos;i="5.70,358,1574150400"; d="scan'208";a="221047513" Received: from ideak-desk.fi.intel.com ([10.237.72.183]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 07:19:29 -0800 Date: Fri, 24 Jan 2020 17:19:23 +0200 From: Imre Deak To: Ville Syrjala Message-ID: <20200124151923.GE32347@ideak-desk.fi.intel.com> References: <20200120174728.21095-1-ville.syrjala@linux.intel.com> <20200120174728.21095-13-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200120174728.21095-13-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH 12/17] drm/i915: Move intel_atomic_state_free() into intel_atomic.c X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Jan 20, 2020 at 07:47:22PM +0200, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > Move intel_atomic_state_free() next to its counterpart. > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Imre Deak Some exported functions in this file are missing documentation. > --- > drivers/gpu/drm/i915/display/intel_atomic.c | 11 +++++++++++ > drivers/gpu/drm/i915/display/intel_atomic.h | 1 + > drivers/gpu/drm/i915/display/intel_display.c | 11 ----------- > 3 files changed, 12 insertions(+), 11 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/dr= m/i915/display/intel_atomic.c > index 1269f63ea006..1c13423d4945 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic.c > +++ b/drivers/gpu/drm/i915/display/intel_atomic.c > @@ -495,6 +495,17 @@ intel_atomic_state_alloc(struct drm_device *dev) > return &state->base; > } > = > +void intel_atomic_state_free(struct drm_atomic_state *_state) > +{ > + struct intel_atomic_state *state =3D to_intel_atomic_state(_state); > + > + drm_atomic_state_default_release(&state->base); > + > + i915_sw_fence_fini(&state->commit_ready); > + > + kfree(state); > +} > + > void intel_atomic_state_clear(struct drm_atomic_state *s) > { > struct intel_atomic_state *state =3D to_intel_atomic_state(s); > diff --git a/drivers/gpu/drm/i915/display/intel_atomic.h b/drivers/gpu/dr= m/i915/display/intel_atomic.h > index 74c749dbfb4f..88133eea0a17 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic.h > +++ b/drivers/gpu/drm/i915/display/intel_atomic.h > @@ -45,6 +45,7 @@ void intel_crtc_destroy_state(struct drm_crtc *crtc, > void intel_crtc_free_hw_state(struct intel_crtc_state *crtc_state); > void intel_crtc_copy_color_blobs(struct intel_crtc_state *crtc_state); > struct drm_atomic_state *intel_atomic_state_alloc(struct drm_device *dev= ); > +void intel_atomic_state_free(struct drm_atomic_state *state); > void intel_atomic_state_clear(struct drm_atomic_state *state); > = > struct intel_crtc_state * > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/d= rm/i915/display/intel_display.c > index 63efb8f9c669..3b725764bdcd 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -17116,17 +17116,6 @@ intel_user_framebuffer_create(struct drm_device = *dev, > return fb; > } > = > -static void intel_atomic_state_free(struct drm_atomic_state *state) > -{ > - struct intel_atomic_state *intel_state =3D to_intel_atomic_state(state); > - > - drm_atomic_state_default_release(state); > - > - i915_sw_fence_fini(&intel_state->commit_ready); > - > - kfree(state); > -} > - > static enum drm_mode_status > intel_mode_valid(struct drm_device *dev, > const struct drm_display_mode *mode) > -- = > 2.24.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx