From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2C7C35250 for ; Sun, 9 Feb 2020 15:50:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABA5120733 for ; Sun, 9 Feb 2020 15:50:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABA5120733 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=etezian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DDB36E830; Sun, 9 Feb 2020 15:50:56 +0000 (UTC) Received: from 2.mo69.mail-out.ovh.net (2.mo69.mail-out.ovh.net [178.33.251.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 803D26E830 for ; Sun, 9 Feb 2020 15:50:54 +0000 (UTC) Received: from player799.ha.ovh.net (unknown [10.110.103.115]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id 99CBC8146F for ; Sun, 9 Feb 2020 16:50:51 +0100 (CET) Received: from etezian.org (81-175-223-118.bb.dnainternet.fi [81.175.223.118]) (Authenticated sender: andi@etezian.org) by player799.ha.ovh.net (Postfix) with ESMTPSA id 0649EF2E35DC; Sun, 9 Feb 2020 15:50:44 +0000 (UTC) Date: Sun, 9 Feb 2020 17:50:43 +0200 From: Andi Shyti To: Jani Nikula Message-ID: <20200209155043.GA38454@jack.zhora.eu> References: <20200208122759.30833-1-andi@etezian.org> <877e0vwyri.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <877e0vwyri.fsf@intel.com> X-Ovh-Tracer-Id: 3052033175819960859 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrheelgdehlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughiucfuhhihthhiuceorghnughisegvthgviihirghnrdhorhhgqeenucfkpheptddrtddrtddrtddpkedurddujeehrddvvdefrdduudeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeelledrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdprhgtphhtthhopehinhhtvghlqdhgfhigsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhg Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: make a gt sysfs group and move power management files X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Jani, > > void intel_gt_init_early(struct intel_gt *gt, struct drm_i915_private *i915) > > { > > @@ -321,6 +322,7 @@ void intel_gt_driver_register(struct intel_gt *gt) > > intel_rps_driver_register(>->rps); > > > > debugfs_gt_register(gt); > > Yikes, when did this happen? Not good. We don't own the debugfs > "namespace" prefix. > > > + sysfs_gt_register(gt); > > Ditto for the sysfs namespace prefix. > > I guess it's not likely debugfs or sysfs would add functions named like > that, but if they did, they'd be right to call these names a violation > of their namespace. > > I have been promoting the idea of naming functions somewhat based on the > name of the file they reside in... so do we want to name the files like > this either? Yes, you're right here. I will rename the "debugfs" function and fix the sysfs in my next patch. Thanks, Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx