From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06EC0C3F2C6 for ; Thu, 27 Feb 2020 22:51:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5658246A1 for ; Thu, 27 Feb 2020 22:51:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5658246A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 659416ED75; Thu, 27 Feb 2020 22:51:13 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C4EE6ED75 for ; Thu, 27 Feb 2020 22:51:12 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 14:51:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="238573006" Received: from nmwoolve-mobl2.ger.corp.intel.com (HELO intel.com) ([10.251.88.225]) by orsmga003.jf.intel.com with ESMTP; 27 Feb 2020 14:51:09 -0800 Date: Fri, 28 Feb 2020 00:51:08 +0200 From: Andi Shyti To: Chris Wilson Message-ID: <20200227225108.GK1514@intel.intel> References: <20200227085723.1961649-1-chris@chris-wilson.co.uk> <20200227085723.1961649-8-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200227085723.1961649-8-chris@chris-wilson.co.uk> Subject: Re: [Intel-gfx] [PATCH 08/20] drm/i915/selftests: Disable heartbeat around manual pulse tests X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chris, On Thu, Feb 27, 2020 at 08:57:11AM +0000, Chris Wilson wrote: > Still chasing the mystery of the stray idle flush, let's ensure that the > heartbeat does not run at the same time as our test and confuse us. > > References: https://gitlab.freedesktop.org/drm/intel/issues/541 > Signed-off-by: Chris Wilson [...] > @@ -331,8 +331,7 @@ void i915_active_unlock_wait(struct i915_active *ref) > } > > /* And wait for the retire callback */ > - spin_lock_irq(&ref->tree_lock); > - spin_unlock_irq(&ref->tree_lock); > + spin_unlock_wait(&ref->tree_lock); maybe one day I will stop complaining about out of context changes... maybe one day. Reviewed-by: Andi Shyti Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx