From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCDAC3F2D6 for ; Mon, 2 Mar 2020 09:39:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCF742469C for ; Mon, 2 Mar 2020 09:39:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="S8eSbxiR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCF742469C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9B066E20D; Mon, 2 Mar 2020 09:39:24 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id B07306E20D for ; Mon, 2 Mar 2020 09:39:23 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id g83so7769009wme.1 for ; Mon, 02 Mar 2020 01:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XgzH+GI4XDfUr3H6/RA0Cs7sjbBaxDHRlo7z/kRe9qg=; b=S8eSbxiR8KhyR/PvANc8GTTCW6eZ8D78AUHr4tW5BXcDfX3g6EjXnA7zjfp73zR2CA OSgUyxhV+d5d8G01XjfF1mvzU5WI77esC3+fZXZHDUxsL3izFZb9uw2ltqZa3IZbWOkm pLC0GLXWbupql6/Jhm/2R5dsAU+oIhXpmVbng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XgzH+GI4XDfUr3H6/RA0Cs7sjbBaxDHRlo7z/kRe9qg=; b=PsSfi6dhUCBZHQXBp2WieJ04pmFJWx3yNwiLtnTjhM3pfohaujMrnGzMQF4kr5s1Ax 5Ia5FsFjTXKKF1XKM/br1vjgAc63ghlAUWt4KGjhVvZlVAkIrXhmCj9JeU4Lj5vcPMbD MFA6HG0N1e0rO0CAD+5w2K2IpI+SS96Uu9gn318Bc78dyvR3BnVIvYrShzqtGvM/v3Gr irdZwejabdHXSnfDJu/7sZQHhF3LtGiBKSUpIYlUMz8NyIp/zFIyFuzvVBwqExJAtN7p QDuHspICLqBfaQ9DYHtDjEU17mj7ejX4ggNohw+6/NwBVRBdoAHe0kqA+QgYgwzxsMqQ 0ZqA== X-Gm-Message-State: APjAAAWxC49xfa4+dRkj9wnf/8omMrs+1FfxX+an9b90UmqBJFRhxfms /bGcG1p3VjTgw1ZvL1mrZ2SFoQ== X-Google-Smtp-Source: APXvYqwGG7ZUAnm+xJwW+2iCcc942XaRsQ5WSdGQDCj2q/Z7fmgG2SX3kFoOhCTEgKahDc5jDIo2vQ== X-Received: by 2002:a1c:f712:: with SMTP id v18mr19977292wmh.155.1583141962345; Mon, 02 Mar 2020 01:39:22 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id q3sm25876359wrs.1.2020.03.02.01.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 01:39:21 -0800 (PST) Date: Mon, 2 Mar 2020 10:39:19 +0100 From: Daniel Vetter To: Jani Nikula Message-ID: <20200302093919.GD2363188@phenom.ffwll.local> References: <20200227181522.2711142-1-daniel.vetter@ffwll.ch> <20200227181522.2711142-4-daniel.vetter@ffwll.ch> <20200228224504.GA23961@ravnborg.org> <20200229111710.GB3674@ravnborg.org> <87blpfqffp.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87blpfqffp.fsf@intel.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 Subject: Re: [Intel-gfx] [PATCH 03/51] drm: add managed resources tied to drm_device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , Daniel Vetter , Intel Graphics Development , Marco Felsch , DRI Development , Laurent Pinchart , Greg Kroah-Hartman , Daniel Vetter , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Mar 02, 2020 at 11:22:34AM +0200, Jani Nikula wrote: > On Sat, 29 Feb 2020, Daniel Vetter wrote: > > On Sat, Feb 29, 2020 at 12:17 PM Sam Ravnborg wrote: > >> The header-check infrastructure was dropped again - see: > >> fcbb8461fd2376ba3782b5b8bd440c929b8e4980 > > > > Uh I'm disappoint :-/ > > To say the least. I thought it was a good *opt-in* feature for whoever > wanted it. But the part that got the backlash was applying it to > absolutely everything under include/. And then it got removed > altogether. From one extreme to the other. Nuts. > > > Adding Jani in case he missed this too. I guess maybe we should > > resurrect it for drm again (and with a file pattern starting in a > > .dot). > > We have a local implementation in i915/Makefile again. It uses 'find' to > find the headers which is fine in i915, but the parameters need to be > adjusted for drm to not be recursive. -maxdepth 1 or something. Also > need to add another local config option. Sad trombone. Splitting this up into two threads. Could we extend this to drm headers again too? Sad thrombones indeed, but at least here we could still the proper fanfares ... Maybe something like have the Makefile snippet in drivers/gpu and then keep a list of directories (or file glob patterns probably better) in there that it should check. I really liked this entire idea very much. Oh also maybe switch the temp files over to dotfiles, so Linus doesn't get upset (which really I think is all that Linus expected, but I guess people just panic and revert). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx