From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B58FC3F2D2 for ; Mon, 2 Mar 2020 13:28:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E426E2086A for ; Mon, 2 Mar 2020 13:28:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="IqXeQHyC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E426E2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 923B16E3EF; Mon, 2 Mar 2020 13:28:27 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15DD86E3EF; Mon, 2 Mar 2020 13:28:26 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BCB19D0; Mon, 2 Mar 2020 14:28:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1583155704; bh=uZsuH7X6ASAn+5GpGL00id9lZWpdGCeWDkVOOpg016c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IqXeQHyCjTpTMpUxsZ/HKu1kdPLfv4+oYVk9mFaLNrFQ9zPnNxbfQF4gvwyQ3iY4P om5vanNRSYHzFCql07959ZGNTBoDsGV5tVD3mzgZL0MEGKDDELNhWJ+H+XpIkTwUaF 2MK8q4SEeAocvnUWVl9WE9kMBZRjZ4TzaDgTgw18= Date: Mon, 2 Mar 2020 15:27:58 +0200 From: Laurent Pinchart To: Pankaj Bharadiya Message-ID: <20200302132758.GO11960@pendragon.ideasonboard.com> References: <20200302125649.61443-1-pankaj.laxminarayan.bharadiya@intel.com> <20200302125649.61443-9-pankaj.laxminarayan.bharadiya@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200302125649.61443-9-pankaj.laxminarayan.bharadiya@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Thomas Zimmermann , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Pankaj, Thank you for the patch. On Mon, Mar 02, 2020 at 06:26:48PM +0530, Pankaj Bharadiya wrote: > drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() > and drm_fb_helper_remove_one_connector() doesn't keep an array of s/doesn't/don't/ > connectors anymore and are just dummy. Now we have no callers to these > functions hence remove them. > > Signed-off-by: Pankaj Bharadiya I like this :-) Reviewed-by: Laurent Pinchart > --- > include/drm/drm_fb_helper.h | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 62e8dda6d1d1..208dbf87afa3 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -451,27 +451,6 @@ drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) > > #endif > > -/* TODO: There's a todo entry to remove these three */ > -static inline int > -drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, > - struct drm_connector *connector) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper, > - struct drm_connector *connector) > -{ > - return 0; > -} > - > /** > * drm_fb_helper_remove_conflicting_framebuffers - remove firmware-configured framebuffers > * @a: memory range, users of which are to be removed -- Regards, Laurent Pinchart _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx