From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F96C3F2D2 for ; Mon, 2 Mar 2020 13:30:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4F5B2086A for ; Mon, 2 Mar 2020 13:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Bd+UjYU0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4F5B2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 452FF6E40D; Mon, 2 Mar 2020 13:30:11 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC5806E3FC; Mon, 2 Mar 2020 13:30:09 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D48369D0; Mon, 2 Mar 2020 14:30:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1583155808; bh=Hee84/PJ0AtWXMwrmwqUhd2qA2lSdrxd4YMOHjSNEKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bd+UjYU0bnGYaqqN4TAT9H5ecLYTV1+o587vEcOGaBstZBzDAFnaUOjCT5mtct5mJ B1B/UWSaW0G1YbPiCP/xuOkaYpffo9n9he4OpEePdRzu+XSVay/UKv1AOOf9S1JUiH Zf/z6SLvVPsm2e/EvGSJCL0ILxVHo7lnyluDFZU4= Date: Mon, 2 Mar 2020 15:29:42 +0200 From: Laurent Pinchart To: Pankaj Bharadiya Message-ID: <20200302132942.GP11960@pendragon.ideasonboard.com> References: <20200302125649.61443-1-pankaj.laxminarayan.bharadiya@intel.com> <20200302125649.61443-10-pankaj.laxminarayan.bharadiya@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200302125649.61443-10-pankaj.laxminarayan.bharadiya@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 9/9] drm/todo: Update drm_fb_helper tasks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Pankaj, Thank you for the patch. On Mon, Mar 02, 2020 at 06:26:49PM +0530, Pankaj Bharadiya wrote: > Remove completed drm_fb_helper tasks from todo list. > > Signed-off-by: Pankaj Bharadiya > --- > Documentation/gpu/todo.rst | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index ccf5e8e34222..98d8782e1440 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -362,17 +362,10 @@ Level: Starter > drm_fb_helper tasks > ------------------- > > -- drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode() > - not the _force variant so it can bail out if there is a master. But first > - these igt tests need to be fixed: kms_fbcon_fbt@psr and > - kms_fbcon_fbt@psr-suspend. > - > -- The max connector argument for drm_fb_helper_init() isn't used anymore and > - can be removed. > - > -- The helper doesn't keep an array of connectors anymore so these can be > - removed: drm_fb_helper_single_add_all_connectors(), > - drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector(). > +drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode() > +not the _force variant so it can bail out if there is a master. But first > +these igt tests need to be fixed: kms_fbcon_fbt@psr and > +kms_fbcon_fbt@psr-suspend. No need to reflow, you can keep the first list entry as-is and just remove the next two. With this fixed, Reviewed-by: Laurent Pinchart > Level: Intermediate > -- Regards, Laurent Pinchart _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx