From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9C3C3F2C6 for ; Tue, 3 Mar 2020 10:20:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F638214DB for ; Tue, 3 Mar 2020 10:20:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F638214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 26DF06E9E0; Tue, 3 Mar 2020 10:20:20 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F34F6E9E0 for ; Tue, 3 Mar 2020 10:20:18 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 02:20:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,510,1574150400"; d="scan'208";a="240026436" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.154]) by orsmga003.jf.intel.com with ESMTP; 03 Mar 2020 02:20:16 -0800 Date: Tue, 3 Mar 2020 15:50:18 +0530 From: Ramalingam C To: Anshuman Gupta Message-ID: <20200303102018.GD20842@intel.com> References: <20200220123217.23635-3-anshuman.gupta@intel.com> <20200303073838.25871-1-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200303073838.25871-1-anshuman.gupta@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/hdcp: Fix config_stream_type() ret value X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2020-03-03 at 13:08:38 +0530, Anshuman Gupta wrote: > DP shim's config_stream_type considered to be succeeded when > return value of intel_dp_hdcp2_write_msg() equals to size of > message to be written, it makes config_stream_type to return > a zero success value in order to succeed the HDCP auth. > > v2: > - config_stream_type() returns 0 on success. [Ram] > > CC: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 2db8d46f61a1..588d0bf37349 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6448,6 +6448,7 @@ static > int intel_dp_hdcp2_config_stream_type(struct intel_digital_port *intel_dig_port, > bool is_repeater, u8 content_type) > { > + int ret; Order it as per the length of the declations. long->short... > struct hdcp2_dp_errata_stream_type stream_type_msg; > > if (is_repeater) > @@ -6463,8 +6464,11 @@ int intel_dp_hdcp2_config_stream_type(struct intel_digital_port *intel_dig_port, > stream_type_msg.msg_id = HDCP_2_2_ERRATA_DP_STREAM_TYPE; > stream_type_msg.stream_type = content_type; > > - return intel_dp_hdcp2_write_msg(intel_dig_port, &stream_type_msg, > + ret = intel_dp_hdcp2_write_msg(intel_dig_port, &stream_type_msg, > sizeof(stream_type_msg)); > + > + return ret < 0 ? ret : 0; > + With that fixed, Looks Good to me. Reviewed-by: Ramalingam C > } > > static > -- > 2.25.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx