From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E71C10DCE for ; Fri, 6 Mar 2020 11:49:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DE442072A for ; Fri, 6 Mar 2020 11:49:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DE442072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49BEE6ECE7; Fri, 6 Mar 2020 11:49:36 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 562826ECE7 for ; Fri, 6 Mar 2020 11:49:35 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2020 03:49:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,518,1574150400"; d="scan'208";a="320513609" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga001.jf.intel.com with SMTP; 06 Mar 2020 03:49:32 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 06 Mar 2020 13:49:31 +0200 Date: Fri, 6 Mar 2020 13:49:31 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Sharma, Swati2" Message-ID: <20200306114931.GQ13686@intel.com> References: <20200303173313.28117-1-ville.syrjala@linux.intel.com> <20200303173313.28117-2-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Polish CHV CGM CSC loading X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Mar 06, 2020 at 02:14:15PM +0530, Sharma, Swati2 wrote: > = > = > On 03-Mar-20 11:03 PM, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > = > > Only load the CGM CSC based on the cgm_mode bit like we > > do with the gamma/degamma LUTs. And make the function > > naming and arguments consistent as well. > > = > > TODO: the code to convert the coefficients look totally > > bogus. IIRC CHV uses two's complement format but the code > > certainly doesn't generate that, so probably negative > > coefficients are totally busted. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/display/intel_color.c | 69 +++++++++++----------- > > 1 file changed, 35 insertions(+), 34 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/d= rm/i915/display/intel_color.c > > index 98aefeebda28..444980fdeda6 100644 > > --- a/drivers/gpu/drm/i915/display/intel_color.c > > +++ b/drivers/gpu/drm/i915/display/intel_color.c > > @@ -348,48 +348,43 @@ static void icl_load_csc_matrix(const struct inte= l_crtc_state *crtc_state) > > crtc_state->csc_mode); > > } > > = > > -/* > > - * Set up the pipe CSC unit on CherryView. > > - */ > > -static void cherryview_load_csc_matrix(const struct intel_crtc_state *= crtc_state) > > +static void chv_load_cgm_csc(struct intel_crtc *crtc, > > + const struct drm_property_blob *blob) > Nitpick: Spacing? I think it's just the use of tabs and the diff's '+' making it look off. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx