From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90EC4C10F27 for ; Tue, 10 Mar 2020 19:09:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6719C20727 for ; Tue, 10 Mar 2020 19:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6719C20727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01DCD6E8CA; Tue, 10 Mar 2020 19:09:53 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A1496E8CA; Tue, 10 Mar 2020 19:09:51 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 12:09:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,538,1574150400"; d="scan'208";a="441406891" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by fmsmga005.fm.intel.com with ESMTP; 10 Mar 2020 12:09:50 -0700 Date: Tue, 10 Mar 2020 12:11:09 -0700 From: Manasi Navare To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20200310191109.GB717@intel.com> References: <20200309213940.27965-1-manasi.d.navare@intel.com> <20200310162027.GL13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310162027.GL13686@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH v5 1/2] drm/edid: Name the detailed monitor range flags X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Harry Wentland , Kazlauskas Nicholas Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 10, 2020 at 06:20:27PM +0200, Ville Syrj=E4l=E4 wrote: > On Mon, Mar 09, 2020 at 02:39:39PM -0700, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > = > > v2: > > * Rename the flags with DRM_EDID_ (Jani N) > > = > > Suggested-by: Ville Syrj=E4l=E4 > > Cc: Ville Syrj=E4l=E4 > > Cc: Harry Wentland > > Cc: Clinton A Taylor > > Cc: Kazlauskas Nicholas > > Cc: Jani Nikula > > Signed-off-by: Manasi Navare > > Reviewed-by: Nicholas Kazlauskas > > --- > > include/drm/drm_edid.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > = > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > index f0b03d401c27..34b15e3d070c 100644 > > --- a/include/drm/drm_edid.h > > +++ b/include/drm/drm_edid.h > > @@ -91,6 +91,11 @@ struct detailed_data_string { > > u8 str[13]; > > } __attribute__((packed)); > > = > > +#define DRM_EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > > +#define DRM_EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > > +#define DRM_EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > > +#define DRM_EDID_CVT_SUPPORT_FLAG 0x04 > = > No indication what flags thse are. Also missing the > actual change to use them in drm_edid.c. > The name of the flag in #define indicates what flag it is, how else do you want me to add teh indication? I have done the change in my second patch to use this flag #define = Use of these flags in other places in drm_edid.c will be follow up patches SOunds good? Manasi = > > + > > struct detailed_data_monitor_range { > > u8 min_vfreq; > > u8 max_vfreq; > > -- = > > 2.19.1 > = > -- = > Ville Syrj=E4l=E4 > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx