From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BFE4C10F27 for ; Tue, 10 Mar 2020 19:20:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEBFB20727 for ; Tue, 10 Mar 2020 19:20:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEBFB20727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 759D16E38A; Tue, 10 Mar 2020 19:20:11 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58BAB6E38A; Tue, 10 Mar 2020 19:20:10 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 12:20:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,538,1574150400"; d="scan'208";a="353692508" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by fmsmga001.fm.intel.com with ESMTP; 10 Mar 2020 12:20:09 -0700 Date: Tue, 10 Mar 2020 12:21:28 -0700 From: Manasi Navare To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20200310192128.GA953@intel.com> References: <20200309213940.27965-1-manasi.d.navare@intel.com> <20200309213940.27965-2-manasi.d.navare@intel.com> <20200310190833.GA717@intel.com> <20200310191330.GR13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310191330.GR13686@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Harry Wentland , Kazlauskas Nicholas , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 10, 2020 at 09:13:30PM +0200, Ville Syrj=E4l=E4 wrote: > On Tue, Mar 10, 2020 at 12:08:33PM -0700, Manasi Navare wrote: > > Hi Ville, > > = > > Please find answers to your concerns below: > > = > > On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > > the EDID's detailed descritors to obtain the adaptive sync monitor ra= nge. > > > Store this info as part fo drm_display_info so it can be used > > > across all drivers. > > > This part of the code is stripped out of amdgpu's function > > > amdgpu_dm_update_freesync_caps() to make it generic and be used > > > across all DRM drivers > > > = > > > v5: > > > * Use the renamed flags > > > v4: > > > * Use is_display_descriptor() (Ville) > > > * Name the monitor range flags (Ville) > > > v3: > > > * Remove the edid parsing restriction for just DP (Nicholas) > > > * Use drm_for_each_detailed_block (Ville) > > > * Make the drm_get_adaptive_sync_range function static (Harry, Jani) > > > v2: > > > * Change vmin and vmax to use u8 (Ville) > > > * Dont store pixel clock since that is just a max dotclock > > > and not related to VRR mode (Manasi) > > > = > > > Cc: Ville Syrj=E4l=E4 > > > Cc: Harry Wentland > > > Cc: Clinton A Taylor > > > Cc: Kazlauskas Nicholas > > > Signed-off-by: Manasi Navare > > > Reviewed-by: Nicholas Kazlauskas > > > --- > > > drivers/gpu/drm/drm_edid.c | 44 +++++++++++++++++++++++++++++++++++= ++ > > > include/drm/drm_connector.h | 22 +++++++++++++++++++ > > > 2 files changed, 66 insertions(+) > > > = > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > index ad41764a4ebe..24b76ae58fdd 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -4938,6 +4938,47 @@ static void drm_parse_cea_ext(struct drm_conne= ctor *connector, > > > } > > > } > > > = > > > +static > > > +void get_adaptive_sync_range(struct detailed_timing *timing, > > > + void *info_adaptive_sync) > > > +{ > > > + struct drm_adaptive_sync_info *adaptive_sync =3D info_adaptive_sync; > > > + const struct detailed_non_pixel *data =3D &timing->data.other_data; > > > + const struct detailed_data_monitor_range *range =3D &data->data.ran= ge; > > > + > > > + if (!is_display_descriptor((const u8 *)timing, EDID_DETAIL_MONITOR_= RANGE)) > > > + return; > > > + > > > + /* > > > + * Check for flag range limits only. If flag =3D=3D 1 then > > > + * no additional timing information provided. > > > + * Default GTF, GTF Secondary curve and CVT are not > > > + * supported > > > + */ > > > + if (range->flags !=3D DRM_EDID_RANGE_LIMITS_ONLY_FLAG) > > > + return; > > > + > > > + adaptive_sync->min_vfreq =3D range->min_vfreq; > > > + adaptive_sync->max_vfreq =3D range->max_vfreq; > > > +} > > > + > > > +static > > > +void drm_get_adaptive_sync_range(struct drm_connector *connector, > > > + const struct edid *edid) > > > +{ > > > + struct drm_display_info *info =3D &connector->display_info; > > > + > > > + if (!version_greater(edid, 1, 1)) > > > + return; > > > + > > > + drm_for_each_detailed_block((u8 *)edid, get_adaptive_sync_range, > > > + &info->adaptive_sync); > > = > > Some functions like get_monitor_name also pass something like &edid_nam= e, I dont > > think there is any specific convention of the argument name to be passe= d. > = > Hmm. Yeah, it's a bit all over. Still I'd probably follow = > the majority vote. > I feel that this name makes it more intuitive rather than adding a generic = name If you dont feel strongly about changing it, I would like to keep this as is = > > = > > > + > > > + DRM_DEBUG_KMS("Adaptive Sync refresh rate range is %d Hz - %d Hz\n", > > > + info->adaptive_sync.min_vfreq, > > > + info->adaptive_sync.max_vfreq); > > = > > Yes I agree that this is just a monitor range and unless the dpcd ignor= e msa bit is set > > and the range is atleast 10Hz apart , it might not be vrr range. > > = > > Would you prefer renaming this info->adaptive_sync as info->monitor_ran= ge ? Or > > should i just print it out as Monitor range is in the dmesg but leave t= he info->adaptive_sync > > naming as is? > = > If we want to parse it uncoditionally then I guess I'd go with the > monitor_rage naming, and leave it up to the vrr code to know what to do > with it. > Yes I plan to add a function in the driver code that checks for the msa bit= and this range to be greater than 10 to say that the sink is adaptive sync capable. So i will just rename this struct to monitor range then? Manasi = > > = > > Manasi > > = > > > +} > > > + > > > /* A connector has no EDID information, so we've got no EDID to comp= ute quirks from. Reset > > > * all of the values which would have been set from EDID > > > */ > > > @@ -4960,6 +5001,7 @@ drm_reset_display_info(struct drm_connector *co= nnector) > > > memset(&info->hdmi, 0, sizeof(info->hdmi)); > > > = > > > info->non_desktop =3D 0; > > > + memset(&info->adaptive_sync, 0, sizeof(info->adaptive_sync)); > > > } > > > = > > > u32 drm_add_display_info(struct drm_connector *connector, const stru= ct edid *edid) > > > @@ -4975,6 +5017,8 @@ u32 drm_add_display_info(struct drm_connector *= connector, const struct edid *edi > > > = > > > info->non_desktop =3D !!(quirks & EDID_QUIRK_NON_DESKTOP); > > > = > > > + drm_get_adaptive_sync_range(connector, edid); > > > + > > > DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop); > > > = > > > if (edid->revision < 3) > > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > > index 0df7a95ca5d9..2b22c0fa42c4 100644 > > > --- a/include/drm/drm_connector.h > > > +++ b/include/drm/drm_connector.h > > > @@ -254,6 +254,23 @@ enum drm_panel_orientation { > > > DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > > > }; > > > = > > > +/** > > > + * struct drm_adaptive_sync_info - Panel's Adaptive Sync capabilitie= s for > > > + * &drm_display_info > > > + * > > > + * This struct is used to store a Panel's Adaptive Sync capabilities > > > + * as parsed from EDID's detailed monitor range descriptor block. > > > + * > > > + * @min_vfreq: This is the min supported refresh rate in Hz from > > > + * EDID's detailed monitor range. > > > + * @max_vfreq: This is the max supported refresh rate in Hz from > > > + * EDID's detailed monitor range > > > + */ > > > +struct drm_adaptive_sync_info { > > > + u8 min_vfreq; > > > + u8 max_vfreq; > > > +}; > > > + > > > /* > > > * This is a consolidated colorimetry list supported by HDMI and > > > * DP protocol standard. The respective connectors will register > > > @@ -473,6 +490,11 @@ struct drm_display_info { > > > * @non_desktop: Non desktop display (HMD). > > > */ > > > bool non_desktop; > > > + > > > + /** > > > + * @adaptive_sync: Adaptive Sync capabilities of the DP/eDP sink > > > + */ > > > + struct drm_adaptive_sync_info adaptive_sync; > > > }; > > > = > > > int drm_display_info_set_bus_formats(struct drm_display_info *info, > > > -- = > > > 2.19.1 > > > = > = > -- = > Ville Syrj=E4l=E4 > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx