From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D6D4C0044D for ; Mon, 16 Mar 2020 23:49:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 552A020663 for ; Mon, 16 Mar 2020 23:49:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 552A020663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB9486E550; Mon, 16 Mar 2020 23:49:55 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BCA86E550 for ; Mon, 16 Mar 2020 23:49:54 +0000 (UTC) IronPort-SDR: gKKxBYXpDHerTfktmBlFG0tqunq1fPTMoP2SC+7xQbQjJXWNglaP8bVib7jRl+R00l9BpOvK29 iEvm8wSdLuAQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 16:49:54 -0700 IronPort-SDR: /WzaCyHlMAgrI2SpfBJ5EZGvtQ6eoet0c9YloOt+WK3SyqU1b62SpWOHtIBnbW6eWSUp8equrH Jryz/cNgA7Xg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,562,1574150400"; d="scan'208";a="262854433" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by orsmga002.jf.intel.com with ESMTP; 16 Mar 2020 16:49:52 -0700 Date: Mon, 16 Mar 2020 16:51:23 -0700 From: Manasi Navare To: Stanislav Lisovskiy Message-ID: <20200316235123.GB24231@intel.com> References: <20200316113744.31203-1-stanislav.lisovskiy@intel.com> <20200316113744.31203-4-stanislav.lisovskiy@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200316113744.31203-4-stanislav.lisovskiy@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH v1 3/3] drm/i915: Remove unneeded hack now for CDCLK X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Mar 16, 2020 at 01:37:44PM +0200, Stanislav Lisovskiy wrote: > No need to bump up CDCLK now, as it is now correctly > calculated, accounting for DBuf BW as BSpec says. > > Signed-off-by: Stanislav Lisovskiy Logic looks good, Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > index f0dcea4d6357..45469f6833b8 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -2055,18 +2055,6 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) > /* Account for additional needs from the planes */ > min_cdclk = max(intel_planes_min_cdclk(crtc_state), min_cdclk); > > - /* > - * HACK. Currently for TGL platforms we calculate > - * min_cdclk initially based on pixel_rate divided > - * by 2, accounting for also plane requirements, > - * however in some cases the lowest possible CDCLK > - * doesn't work and causing the underruns. > - * Explicitly stating here that this seems to be currently > - * rather a Hack, than final solution. > - */ > - if (IS_TIGERLAKE(dev_priv)) > - min_cdclk = max(min_cdclk, (int)crtc_state->pixel_rate); > - > /* > * Similar story as with skl_write_plane_wm and intel_enable_sagv > * - in some certain driver parts, we don't have any guarantee that > -- > 2.24.1.485.gad05a3d8e5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx