From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D60C4332D for ; Wed, 18 Mar 2020 20:44:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0EC4208DB for ; Wed, 18 Mar 2020 20:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0EC4208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 017E96E964; Wed, 18 Mar 2020 20:44:39 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E60CA6E962; Wed, 18 Mar 2020 20:44:37 +0000 (UTC) IronPort-SDR: k4hnVejjnwu6Fb0n6vtVyg92BEWNNED+o2jCS+J1sSVfBgFkMmBJ3MiZfgSmEezNxsPW6eRCRx OhR5abRd2V8g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 13:44:37 -0700 IronPort-SDR: WYfRcxkLj/LFlJqmjLUuVj57XDZGeQ2mDMVAr9yu5beKwwNST7wG6bgqtBxEo53EF88CnKTxlK 1cKaO0tlB6pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,568,1574150400"; d="scan'208";a="263510120" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 18 Mar 2020 13:44:34 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Mar 2020 22:44:33 +0200 Date: Wed, 18 Mar 2020 22:44:33 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Matt Roper Message-ID: <20200318204433.GG13686@intel.com> References: <20200318154959.9017-1-ville.syrjala@linux.intel.com> <20200318203107.GM2286538@mdroper-desk1.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200318203107.GM2286538@mdroper-desk1.amr.corp.intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Mar 18, 2020 at 01:31:07PM -0700, Matt Roper wrote: > On Wed, Mar 18, 2020 at 05:49:59PM +0200, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > = > > Currently a driver must not provide a .dumb_create() hook in the > > drm_driver structure if it wants to declare dumb buffers as not > > supported. So if the same driver wants to support both modeset > > and non-modeset devices it would require two distinct drm_driver > > structures in order to reject the dumb buffer operations on the > > non-modeset devices. That's rather tedious, so let's make life > > easier for such drivers by also checking for the DRIVER_MODESET > > flag before we declare dumb buffers as supported. Now all the > > driver has to do is clear the flag for any device that can't > > do modesetting. > = > Will this be a problem for vgem? I thought it exposed dumb buffers > without modesetting support? Well that's disappointing. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx