From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5857C2BA80 for ; Tue, 7 Apr 2020 16:58:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BF8720730 for ; Tue, 7 Apr 2020 16:58:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m9E0bGcM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BF8720730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA67C6E8B0; Tue, 7 Apr 2020 16:58:48 +0000 (UTC) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by gabe.freedesktop.org (Postfix) with ESMTPS id C94B16E113 for ; Tue, 7 Apr 2020 16:40:53 +0000 (UTC) Received: by mail-qk1-x741.google.com with SMTP id m67so1136294qke.12 for ; Tue, 07 Apr 2020 09:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NEBZoEbbGRpG5+efrS4YpEv5tZvQcL2k17oabanZi30=; b=m9E0bGcM1xVIO6HzwOiiw6azRMQ74K9HY/E+3Cq8ZYo+b2q/t/4DqwdDJysT1v2/jE /Fbw+z77aAyD2P+UZL/NhMvnvrX4mIAXXG4/6zyxXJSoSCTEF/6PwBr25bCL4Wdgl11G xE1YP75k2LXGGKeO0RfqexMQBXvkypqNCbnG8KDXj0GGIMsc/fxCnRSOpuQtldDxVBT5 bKitoI/pXFqrGa6Tuno2w0+IeKCc15VeBK2o8DK2XbIfk3dLryz+nDLgDWir1FYORsOm YILS26DYbdWonLPnQAoI/lvv1QTpYxRO1rw/3K5Sqc9L7RWKCOLQMyA7GfTRGaA9C+HU msKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NEBZoEbbGRpG5+efrS4YpEv5tZvQcL2k17oabanZi30=; b=Qj0fCiZk44JVc+4fClddh2ZUVZlKTi+T3CtqnS1SeE9yD/SKLIdxtyUaKN35CgWAMJ 00MX9cKhjr7aMxQ8CusQyU8R7yY3/UguOkwkxiSSdmCqyL5oxm6NX0t7mLMi9fQ1Wun1 XNe7t5i8A9ggNHhiN+hPS6C1kBuElIw1TwW8vTE/hv0+ud926+BH/Z2btihOwOWL/rTg smHFvsdy1TXZHirtkNr0xTov/0FIu0KawYemY6a5K0qzeaue0gOeHTooDjYxLPyH8dOu RSzRCTKaJ/X6tSEqihbs3qiOesfNfoa5uW02um7fkYxnr1B+DBLQ6u3Mf69iX/xWeCWL Rx2A== X-Gm-Message-State: AGi0PuZltrHoZBXOgoVRNP/AHo4YlUTcVynHC2zfleMxDNFY1VNa4tOu 1YJ3V0DxqpiSaYPOp4W0Aps= X-Google-Smtp-Source: APiQypLyjk8hC3wH5TspiRi3WgJRbW7/VmxEEgbMs9kvR9mUY96WFZvAa+DGSCDDJfubK+BP2ROymA== X-Received: by 2002:ae9:c312:: with SMTP id n18mr3041970qkg.472.1586277652883; Tue, 07 Apr 2020 09:40:52 -0700 (PDT) Received: from quaco.ghostprotocols.net ([179.97.37.151]) by smtp.gmail.com with ESMTPSA id t11sm3230053qto.75.2020.04.07.09.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 09:40:52 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4A371409A3; Tue, 7 Apr 2020 13:40:50 -0300 (-03) Date: Tue, 7 Apr 2020 13:40:50 -0300 To: Arnaldo Carvalho de Melo Message-ID: <20200407164050.GC12003@kernel.org> References: <20200407143014.GD11186@kernel.org> <20200407143551.GF11186@kernel.org> <10cc74ee-8587-8cdb-f85f-5724b370a2ce@linux.intel.com> <20200407163654.GB12003@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200407163654.GB12003@kernel.org> X-Url: http://acmel.wordpress.com X-Mailman-Approved-At: Tue, 07 Apr 2020 16:58:43 +0000 Subject: Re: [Intel-gfx] [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-man@vger.kernel.org, Song Liu , Andi Kleen , "linux-doc@vger.kernel.org" , Peter Zijlstra , linux-kernel , Igor Lubashev , Alexei Starovoitov , Stephane Eranian , James Morris , "selinux@vger.kernel.org" , "linux-security-module@vger.kernel.org" , Ingo Molnar , Namhyung Kim , Thomas Gleixner , Jiri Olsa , "intel-gfx@lists.freedesktop.org" , Serge Hallyn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Em Tue, Apr 07, 2020 at 01:36:54PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 07, 2020 at 05:54:27PM +0300, Alexey Budankov escreveu: > > On 07.04.2020 17:35, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Apr 07, 2020 at 11:30:14AM -0300, Arnaldo Carvalho de Melo escreveu: > > >> [perf@five ~]$ type perf > > >> perf is hashed (/home/perf/bin/perf) > > >> [perf@five ~]$ getcap /home/perf/bin/perf > > >> /home/perf/bin/perf = cap_sys_ptrace,cap_syslog,38+ep > > >> [perf@five ~]$ groups > > >> perf perf_users > > >> [perf@five ~]$ id > > >> uid=1002(perf) gid=1002(perf) groups=1002(perf),1003(perf_users) context=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 > > >> [perf@five ~]$ perf top --stdio > > >> Error: > > >> Failed to mmap with 1 (Operation not permitted) > > >> [perf@five ~]$ perf record -a > > >> ^C[ perf record: Woken up 1 times to write data ] > > >> [ perf record: Captured and wrote 1.177 MB perf.data (1552 samples) ] > > >> > > >> [perf@five ~]$ perf evlist > > >> cycles:u > > >> [perf@five ~]$ > > > > > > Humm, perf record falls back to cycles:u after initially trying cycles > > > (i.e. kernel and userspace), lemme see trying 'perf top -e cycles:u', > > > lemme test, humm not really: > > > > > > [perf@five ~]$ perf top --stdio -e cycles:u > > > Error: > > > Failed to mmap with 1 (Operation not permitted) > > > [perf@five ~]$ perf record -e cycles:u -a sleep 1 > > > [ perf record: Woken up 1 times to write data ] > > > [ perf record: Captured and wrote 1.123 MB perf.data (132 samples) ] > > > [perf@five ~]$ > > > > > > Back to debugging this. > > > > Could makes sense adding cap_ipc_lock to the binary to isolate from this: > > > > kernel/events/core.c: 6101 > > if ((locked > lock_limit) && perf_is_paranoid() && > > !capable(CAP_IPC_LOCK)) { > > ret = -EPERM; > > goto unlock; > > } > > > That did the trick, I'll update the documentation and include in my > "Committer testing" section: I ammended this to that patch, please check the wording: - Arnaldo diff --git a/Documentation/admin-guide/perf-security.rst b/Documentation/admin-guide/perf-security.rst index c0ca0c1a6804..ed33682e26b0 100644 --- a/Documentation/admin-guide/perf-security.rst +++ b/Documentation/admin-guide/perf-security.rst @@ -127,12 +127,19 @@ taken to create such groups of privileged Perf users. :: - # setcap "cap_perfmon,cap_sys_ptrace,cap_syslog=ep" perf - # setcap -v "cap_perfmon,cap_sys_ptrace,cap_syslog=ep" perf + # setcap "cap_perfmon,cap_ipc_lock,cap_sys_ptrace,cap_syslog=ep" perf + # setcap -v "cap_perfmon,cap_ipc_lock,cap_sys_ptrace,cap_syslog=ep" perf perf: OK # getcap perf perf = cap_sys_ptrace,cap_syslog,cap_perfmon+ep +If the libcap installed doesn't yet support "cap_perfmon", use "38" instead, +i.e.: + +:: + + # setcap "38,cap_ipc_lock,cap_sys_ptrace,cap_syslog=ep" perf + As a result, members of perf_users group are capable of conducting performance monitoring and observability by using functionality of the configured Perf tool executable that, when executes, passes perf_events _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx