From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBEAC2D0EC for ; Tue, 7 Apr 2020 22:44:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E79A52063A for ; Tue, 7 Apr 2020 22:43:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E79A52063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72AC06E92D; Tue, 7 Apr 2020 22:43:59 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56C606E92D for ; Tue, 7 Apr 2020 22:43:58 +0000 (UTC) IronPort-SDR: 5VyMkTWE7Q5BpFcN+dO5Jpg7pxl59k5t0HmgIRO2EBSLIeUwzruc/KehzL8L926QJM1Y6gG/Pk 2v97ljY8sP/g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 15:43:57 -0700 IronPort-SDR: 00Ee700mUVa94WAUoI7tLSgyqKO1KKSyZeix+ET/vDWlj4CjQYOchQ7K+NNjCdGFT3IlHQeOy7 xUzMAPIIxCYg== X-IronPort-AV: E=Sophos;i="5.72,356,1580803200"; d="scan'208";a="243885374" Received: from ideak-desk.fi.intel.com ([10.237.72.183]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 15:43:56 -0700 Date: Wed, 8 Apr 2020 01:43:45 +0300 From: Imre Deak To: "Souza, Jose" Message-ID: <20200407224345.GF23597@ideak-desk.fi.intel.com> References: <20200407214000.342933-1-jose.souza@intel.com> <20200407214000.342933-4-jose.souza@intel.com> <20200407220346.GC23597@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/tc/icl: Implement TC cold sequences X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: "Chiou, Cooper" , "intel-gfx@lists.freedesktop.org" , "kai.heng.feng@canonical.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Apr 08, 2020 at 01:20:02AM +0300, Souza, Jose wrote: > [...] > > > + drm_dbg_kms(&i915->drm, "TC cold block %s\n", ret ? "failed" : > > > + "succeeded"); > > > > You missed turning this to an error. > > Can we postpone this at least for ICL? > > The ICL machines in CI don't have the IFWI that have this PCODE > command, so it is failing. I have asked to CI team do update but it > is going to take a while. VLK-9040 Ah, yes it's ok. Please also add a FIXME: then. --Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx