From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C2EAC3815B for ; Wed, 15 Apr 2020 11:24:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4255E20768 for ; Wed, 15 Apr 2020 11:24:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4255E20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C8EF46E96F; Wed, 15 Apr 2020 11:24:22 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ACE16E96E for ; Wed, 15 Apr 2020 11:24:22 +0000 (UTC) IronPort-SDR: dk6mohFnN2Ki+SZPoFUyi8yfQvfWg5P4I+LYhKW0D8taRZ/iF0WiMRJaZ7I0XRB343EsNEbdAG mCEQl5OlBc3A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 04:24:21 -0700 IronPort-SDR: GlQM2AYNhbo9+7tYDnarSoJfFjHnvrpcfnZ6lQIRjOyIwohaKJmiqiukTt8wh8UTwUms8+aVnf a4GSWWwuyZjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="298967963" Received: from lbrannix-mobl.ger.corp.intel.com (HELO intel.com) ([10.251.93.149]) by FMSMGA003.fm.intel.com with ESMTP; 15 Apr 2020 04:24:19 -0700 Date: Wed, 15 Apr 2020 14:24:18 +0300 From: Andi Shyti To: Chris Wilson Message-ID: <20200415112418.GE50947@intel.intel> References: <20200415075018.7636-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200415075018.7636-1-chris@chris-wilson.co.uk> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Update PMINTRMSK holding fw X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chris, On Wed, Apr 15, 2020 at 08:50:18AM +0100, Chris Wilson wrote: > If we use a non-forcewaked write to PMINTRMSK, it does not take effect > until much later, if at all, causing a loss of RPS interrupts and no GPU > reclocking, leaving the GPU running at the wrong frequency for long > periods of time. > > Reported-by: Francisco Jerez > Suggested-by: Francisco Jerez > Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS") > Signed-off-by: Chris Wilson > Cc: Francisco Jerez > Cc: Mika Kuoppala > Cc: Andi Shyti > Cc: # v5.6+ Reviewed-by: Andi Shyti Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx