From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B91C433E0 for ; Fri, 15 May 2020 17:24:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0563220758 for ; Fri, 15 May 2020 17:24:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0563220758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96CE96ED0B; Fri, 15 May 2020 17:24:54 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C333D6ED0B for ; Fri, 15 May 2020 17:24:53 +0000 (UTC) IronPort-SDR: 5WIWWNsgb10RrKb8d0fvDW8b+3aZuJf+PcCSKCdFIhYV+2X4so11ta84MEy1TGvr0iJnVJ1vK+ nVIjrLfRX0uA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 10:24:53 -0700 IronPort-SDR: ntebUOceB8JmegD/3pWanl2ViRgPB0r/RoA8ekLpysnvF7EuAjYDCeeCkI1nKMXdslNtOjgSNA NR9z5earB4bA== X-IronPort-AV: E=Sophos;i="5.73,396,1583222400"; d="scan'208";a="438385082" Received: from ideak-desk.fi.intel.com ([10.237.72.183]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 10:24:51 -0700 Date: Fri, 15 May 2020 20:24:45 +0300 From: Imre Deak To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20200515172445.GA20373@ideak-desk.fi.intel.com> References: <20200514204553.27193-1-imre.deak@intel.com> <20200515162106.GL6112@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515162106.GL6112@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix AUX power domain toggling across TypeC mode resets X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, May 15, 2020 at 07:21:06PM +0300, Ville Syrj=E4l=E4 wrote: > On Thu, May 14, 2020 at 11:45:53PM +0300, Imre Deak wrote: > > Make sure to select the port's AUX power domain while holding the TC > > port lock. The domain depends on the port's current TC mode, which may > > get changed under us if we're not holding the lock. > = > Can we toss in a lockdep assert? Yes, can do that. However, now I realize, there is one more place to fix in intel_dp_force(), where I think we could just drop the aux get/put. So are you ok to do that as a follow-up? > Did this by any chance help with the MST issues you were seeing? No, at least it didn't resolve it. Still some missing responses to MST down messages. More precisely the sink does send interrupts as a response, but the interrupt handler won't see the DP_DOWN_REP_MSG_RDY being set in ESI. > > This was left out from > > commit 8c10e2262663 ("drm/i915: Keep the TypeC port mode fixed for dete= ct/AUX transfers") > > = > > Cc: # v5.4+ > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/= i915/display/intel_dp.c > > index 408c3c1c5e81..40d42dcff0b7 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -1359,8 +1359,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp, > > bool is_tc_port =3D intel_phy_is_tc(i915, phy); > > i915_reg_t ch_ctl, ch_data[5]; > > u32 aux_clock_divider; > > - enum intel_display_power_domain aux_domain =3D > > - intel_aux_power_domain(intel_dig_port); > > + enum intel_display_power_domain aux_domain; > > intel_wakeref_t aux_wakeref; > > intel_wakeref_t pps_wakeref; > > int i, ret, recv_bytes; > > @@ -1375,6 +1374,8 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp, > > if (is_tc_port) > > intel_tc_port_lock(intel_dig_port); > > = > > + aux_domain =3D intel_aux_power_domain(intel_dig_port); > > + > > aux_wakeref =3D intel_display_power_get(i915, aux_domain); > > pps_wakeref =3D pps_lock(intel_dp); > > = > > -- = > > 2.23.1 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > -- = > Ville Syrj=E4l=E4 > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx