From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B59AC433DF for ; Thu, 4 Jun 2020 19:23:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FAF5206E6 for ; Thu, 4 Jun 2020 19:23:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FAF5206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABB9E6E58E; Thu, 4 Jun 2020 19:23:47 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 592206E58E for ; Thu, 4 Jun 2020 19:23:46 +0000 (UTC) IronPort-SDR: MOMWY0oxFBSjnynqlkkN3hZOFCUQB4piPQeSoOqzJBhWPzcB0tVNwIBgHY/uQFWUIrGl8t+FVq qbp+y43wfJPw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 12:23:45 -0700 IronPort-SDR: m/BEF+mRgSozELhf+PwfVrVjNsOHufB2EYNoXmyKXz8ASCWnq3rLstRr82pk5iA3/QlcXKB8Cc jecIedmFJmLA== X-IronPort-AV: E=Sophos;i="5.73,472,1583222400"; d="scan'208";a="445613533" Received: from ideak-desk.fi.intel.com ([10.237.72.183]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 12:23:44 -0700 Date: Thu, 4 Jun 2020 22:23:40 +0300 From: Imre Deak To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Manasi D Navare Message-ID: <20200604192340.GF15427@ideak-desk.fi.intel.com> References: <20200604002359.17128-1-manasi.d.navare@intel.com> <20200604152543.GU6112@intel.com> <20200604183530.GB3922@intel.com> <20200604183819.GD6112@intel.com> <20200604185223.GC3922@intel.com> <20200604185824.GG6112@intel.com> <20200604190140.GH6112@intel.com> <20200604190858.GE15427@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200604190858.GE15427@ideak-desk.fi.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: Reset link params on connector disconnect X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jun 04, 2020 at 10:08:58PM +0300, Imre Deak wrote: > On Thu, Jun 04, 2020 at 10:01:40PM +0300, Ville Syrj=E4l=E4 wrote: > > [...] > > > > Then we get this hpd, in this case if we dont reset the param to ma= x values, prev triggered modeset continues > > > > with fallback values but since connector probe doesnt happen again = through IGT, it tries the same mode > > > > with fallback values and return encoder config failure. > > > = > > > If the link training failed then clearly the sink didn't like us anym= ore > > > anyway. So feels like resetting these here is just shifting some race > > > window around a bit, but it could still fail if the sink still doesn't > > > like us. > > > = > > > Would be good if someone was able to figure out why the sink goes bad= in > > > the first place. > > = > > Oh, and don't we now have Imre's "weird hpd happened in the middle of > > the test, don't trust the results" thing in igt? > = > An LG and IIyama monitor this happens on disconnect and reconnect after > waking from an idle state when modesetting them, not sure if it's the > same case. Manasi, could you try if a modeset on the monitor after it has been disabled for a while always results in a long HPD pulse a few seconds after the modeset? If so does this also happen when you just modeset in a sequence from one mode to the other not letting the monitor idle? The same monitor should be also tested then with the above sequences on older platforms if it behaves the same on those too. > = > --Imre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx