From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9243AC433DF for ; Tue, 16 Jun 2020 17:12:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B02320B1F for ; Tue, 16 Jun 2020 17:12:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="W6TaR11r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B02320B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04BFB6E921; Tue, 16 Jun 2020 17:12:49 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id A48976E921 for ; Tue, 16 Jun 2020 17:12:47 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id q25so3912630wmj.0 for ; Tue, 16 Jun 2020 10:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QF77TfpXaCpf3AajPTPB0V47GnH1aes+zvHcWXvs9K8=; b=W6TaR11rZdjNqUvWs05Qj7o52M7gzYRcpZx4oVhmEEAftItipznpReFrtyAckjiUnG 7rKYsWPyW7RSd0JJFadJS6HHiC0LNdfPLXfBIEnd6AS0MRydSTgV6P4l5r0GiCYxnCih ieTeuk4i+udLxaseqJ2ZG5iuFOyNw6xtkjDbs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QF77TfpXaCpf3AajPTPB0V47GnH1aes+zvHcWXvs9K8=; b=KL4aY1xBzdm7hsm4uRwBqFSWcZJKV+sZIusNlxOUVHON0dO/ZUL3AHwZEEj7A+dzEI mIX5yX18l+bfCgs9LRBUKFxJf/d295sEDpum4KjmNVo3KPelRxuhgz5tFTFq/1cKdUJI zHvhws8DlNXKG37zlwxoLHE3purG5a01VPfafWSAFvfHMUwRbWNOly9wzXcdCHJlPWlO mcCHOeagvfveeLNkjQBloyNtf2yl6q5QnZCtjl6Fpw5poK49L8tNpNhKhK4e0wyYulO8 xphS+o1V+bh1b5PB7ryJgGJlZ4zRB/PalSokeYS4zgsHftIMs/m7YCjrBWMSwdml5EWv 45kA== X-Gm-Message-State: AOAM5302WQj0eAIEHNEu9w1YqOF8DkRPRFklbNEMWYSQjXpHfKHTxFJV DxsEsfbTF/44uQcP2E2HhwyUNQ== X-Google-Smtp-Source: ABdhPJyN3MEIvR8P4WTKEICd/+HgfywI20Ewu7aFZR9PEYw6m3bu6J846GPih+JcjvV14aTdz7J24g== X-Received: by 2002:a1c:c904:: with SMTP id f4mr4227814wmb.69.1592327566302; Tue, 16 Jun 2020 10:12:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id y14sm4556985wma.25.2020.06.16.10.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 10:12:45 -0700 (PDT) Date: Tue, 16 Jun 2020 19:12:43 +0200 From: Daniel Vetter To: Thomas Zimmermann Message-ID: <20200616171243.GQ20149@phenom.ffwll.local> References: <20200616114723.2363268-1-daniel.vetter@ffwll.ch> <8c125158-fe7c-29a9-d9a8-9e6b418b6dd5@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8c125158-fe7c-29a9-d9a8-9e6b418b6dd5@suse.de> X-Operating-System: Linux phenom 5.6.0-1-amd64 Subject: Re: [Intel-gfx] [PATCH] drm/shmem-helper: Only dma-buf imports are private obj X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Daniel Vetter , Intel Graphics Development , DRI Development , Gerd Hoffmann , Daniel Vetter Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jun 16, 2020 at 02:06:24PM +0200, Thomas Zimmermann wrote: > Hi > = > Am 16.06.20 um 13:47 schrieb Daniel Vetter: > > I broke that in my refactoring: > > = > > commit 7d2cd72a9aa3df3604cafd169a2d4a525afb68ca > > Author: Daniel Vetter > > Date: Fri May 29 16:05:42 2020 +0200 > > = > > drm/shmem-helpers: Simplify dma-buf importing > > = > > I'm not entirely sure of the history here, but I suspect that in one > > of the rebases or when applying the patch I moved the hunk from > > drm_gem_shmem_prime_import_sg_table(), where it should be, to > > drm_gem_shmem_create_with_handle(), which is totally wrong. > > = > > Remedy this. > > = > > Thanks for Thomas for the crucual hint in debugging this. > > = > > Reported-by: Thomas Zimmermann > > Fixes: 7d2cd72a9aa3 ("drm/shmem-helpers: Simplify dma-buf importing") > > Cc: Boris Brezillon > > Cc: Thomas Zimmermann > > Cc: Gerd Hoffmann > > Cc: Rob Herring > > Cc: Noralf Tr=F8nnes > > Signed-off-by: Daniel Vetter > = > Tested-by: Thomas Zimmermann > Reviewed-by: Thomas Zimmermann Now also merged, thanks a lot for your help. -Daniel > = > > --- > > drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/d= rm_gem_shmem_helper.c > > index 0a7e3b664bc2..837e0840990c 100644 > > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > > @@ -377,7 +377,7 @@ drm_gem_shmem_create_with_handle(struct drm_file *f= ile_priv, > > struct drm_gem_shmem_object *shmem; > > int ret; > > = > > - shmem =3D __drm_gem_shmem_create(dev, size, true); > > + shmem =3D drm_gem_shmem_create(dev, size); > > if (IS_ERR(shmem)) > > return shmem; > > = > > @@ -730,7 +730,7 @@ drm_gem_shmem_prime_import_sg_table(struct drm_devi= ce *dev, > > size_t size =3D PAGE_ALIGN(attach->dmabuf->size); > > struct drm_gem_shmem_object *shmem; > > = > > - shmem =3D drm_gem_shmem_create(dev, size); > > + shmem =3D __drm_gem_shmem_create(dev, size, true); > > if (IS_ERR(shmem)) > > return ERR_CAST(shmem); > > = > > = > = > -- = > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 N=FCrnberg, Germany > (HRB 36809, AG N=FCrnberg) > Gesch=E4ftsf=FChrer: Felix Imend=F6rffer > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx