From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E2ADC433E0 for ; Thu, 18 Jun 2020 18:34:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F230207E8 for ; Thu, 18 Jun 2020 18:34:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F230207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CDE36EB9D; Thu, 18 Jun 2020 18:34:47 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D71D96EB9D; Thu, 18 Jun 2020 18:34:45 +0000 (UTC) IronPort-SDR: va5MfxIJ2IA6fqCVJ84PH4Y5L1+j8Em9cmKmbPNCmTsD0OrWZC4YmZg+c8hUU6hlVaMr+ngSpp gHuADmjXfUvA== X-IronPort-AV: E=McAfee;i="6000,8403,9656"; a="122916534" X-IronPort-AV: E=Sophos;i="5.75,252,1589266800"; d="scan'208";a="122916534" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2020 11:34:45 -0700 IronPort-SDR: D3ggCbjjETw92amIWT4ZZeUhj8ErXZGMxInomQdPf3pOmDYRjWX6rSCGssz3uJgJKfU8kmvbi1 CoBNwrqgX5ag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,252,1589266800"; d="scan'208";a="477344935" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by fmsmga005.fm.intel.com with ESMTP; 18 Jun 2020 11:34:45 -0700 Date: Thu, 18 Jun 2020 11:35:58 -0700 From: Manasi Navare To: Emil Velikov Message-ID: <20200618183558.GA32149@intel.com> References: <20200612230444.10121-4-manasi.d.navare@intel.com> <20200612235606.25120-1-manasi.d.navare@intel.com> <20200615214809.GA4334@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , ML dri-devel , Bhanuprakash Modem Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jun 16, 2020 at 04:34:07PM +0100, Emil Velikov wrote: > On Mon, 15 Jun 2020 at 22:47, Manasi Navare w= rote: > > > > On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote: > > > Hi Manasi, > > > > > > On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote: > > > > > > > > From: Bhanuprakash Modem > > > > > > > > [Why] > > > > It's useful to know the min and max vrr range for IGT testing. > > > > > > > > [How] > > > > Expose the min and max vfreq for the connector via a debugfs file > > > > on the connector, "vrr_range". > > > > > > > > Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range > > > > > > > > v7: > > > > * Fix cmpilation due to rebase > > > > v6: > > > > * Rebase (manasi) > > > > v5: > > > > * Rename to vrr_range to match AMD debugfs > > > > v4: > > > > * Rebase > > > > v3: > > > > * Remove the unnecessary debug print (Manasi) > > > > v2: > > > > * Fix the typo in max_vfreq (Manasi) > > > > * Change the name of node to i915_vrr_info so we can add > > > > other vrr info for more debug info (Manasi) > > > > * Change the VRR capable to display Yes or No (Manasi) > > > > * Fix indentation checkpatch errors (Manasi) > > > > > > > Nit: generally revision log is listed in v2 -> v6 order. > > > > Okay point noted. Will update this in the next rev > > > > > > > > > Signed-off-by: Bhanuprakash Modem > > > > Signed-off-by: Manasi Navare > > > > Cc: Jani Nikula > > > > Cc: Ville Syrj=E4l=E4 > > > > Tested-by: Manasi Navare > > > > --- > > > > .../drm/i915/display/intel_display_debugfs.c | 22 +++++++++++++++= +++- > > > > 1 file changed, 21 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b= /drivers/gpu/drm/i915/display/intel_display_debugfs.c > > > > index 28dd717e943a..2921f7d2a26e 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > > > > @@ -2185,6 +2185,21 @@ static const struct file_operations i915_dsc= _fec_support_fops =3D { > > > > .write =3D i915_dsc_fec_support_write > > > > }; > > > > > > > > +static int vrr_range_show(struct seq_file *m, void *data) > > > > +{ > > > > + struct drm_connector *connector =3D m->private; > > > > + > > > > + if (connector->status !=3D connector_status_connected) > > > > + return -ENODEV; > > > > + > > > > + seq_printf(m, "Vrr_capable: %s\n", yesno(intel_dp_is_vrr_ca= pable(connector))); > > > > + seq_printf(m, "Min: %u\n", (u8)connector->display_info.moni= tor_range.min_vfreq); > > > > + seq_printf(m, "Max: %u\n", (u8)connector->display_info.moni= tor_range.max_vfreq); > > > > + > > > > + return 0; > > > > +} > > > > +DEFINE_SHOW_ATTRIBUTE(vrr_range); > > > > + > > > > /** > > > > * intel_connector_debugfs_add - add i915 specific connector debug= fs files > > > > * @connector: pointer to a registered drm_connector > > > > @@ -2220,10 +2235,15 @@ int intel_connector_debugfs_add(struct drm_= connector *connector) > > > > if (INTEL_GEN(dev_priv) >=3D 10 && > > > > ((connector->connector_type =3D=3D DRM_MODE_CONNECTOR_D= isplayPort && > > > > !to_intel_connector(connector)->mst_port) || > > > > - connector->connector_type =3D=3D DRM_MODE_CONNECTOR_eD= P)) > > > > + connector->connector_type =3D=3D DRM_MODE_CONNECTOR_eD= P)) { > > > > debugfs_create_file("i915_dsc_fec_support", S_IRUGO= , root, > > > > connector, &i915_dsc_fec_suppor= t_fops); > > > > > > > > + if (INTEL_GEN(dev_priv) >=3D 12) > > > > + debugfs_create_file("vrr_range", S_IRUGO, > > > > + root, connector, &vrr_r= ange_fops); > > > > + } > > > > + > > > > > > I think this should be added by core drm. Ideally drm will add it > > > automatically for each connector that the driver has called > > > drm_connector_attach_vrr_capable_property() upon. > > > > > > > But in this case drm_connector_attach_vrr_capable_property() is called = by individual > > driver since its an optional connector property. So we call this inside= i915. > = > I'm _not_ suggesting that one moves the > drm_connector_attach_vrr_capable_property() call. Simply create the > debugfs file in drm itself. > = > > Also currently AMD sets this debugfs inside AMD IMO, so setting this he= re for now. > Let's do the better thing of a) make drm create the file, and b) > remove the AMDGPU specific one. > = > We're talking about 20-30 lines worth of a patch. Postponing it sounds si= lly. > = > > But I agree that can be moved to drm core may be when drm_display_info = gets populated > > with min and max, thats where drm can add this? > > > Both min and max are already part of drm_display_info. On the question > of how - check the existing properties (edid_override, force) for > examples. > Okay makes sense. Will move the vrr_range to drm debugfs node. Thanks for your feedback. Regards Manasi = > -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx