From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09605C433E2 for ; Mon, 22 Jun 2020 19:00:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE76F2078A for ; Mon, 22 Jun 2020 19:00:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE76F2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76F366E8BF; Mon, 22 Jun 2020 19:00:45 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78AA56E8BF; Mon, 22 Jun 2020 19:00:44 +0000 (UTC) IronPort-SDR: p6bXJ2xTtZqKxi7/v4eXxb39awlTpKDX+/5QO1WLFEL33yYxVmsZ8UVWcLGWr3+SJRTlmF9baQ Dmsz+QyCwSNw== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="161927763" X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="161927763" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 12:00:43 -0700 IronPort-SDR: cXwXur80jFHbaLsA7UWEMB2uEp2ePrDX5f9MY7RJLBUVhkYZ8VPmNQ4YpyZ2Qn5iRadBQXH8Fc TBf6/N9mLPjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="318862157" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jun 2020 12:00:42 -0700 Date: Mon, 22 Jun 2020 12:02:03 -0700 From: Manasi Navare To: Bhanuprakash Modem Message-ID: <20200622190203.GB18249@intel.com> References: <20200622142519.16214-1-bhanuprakash.modem@intel.com> <20200622142519.16214-3-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200622142519.16214-3-bhanuprakash.modem@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [v9 2/3] drm/debug: Expose connector VRR monitor range via debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Jun 22, 2020 at 07:55:18PM +0530, Bhanuprakash Modem wrote: > [Why] > It's useful to know the min and max vrr range for IGT testing. > = > [How] > Expose the min and max vfreq for the connector via a debugfs file > on the connector, "vrr_range". > = > Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range > = > v2: > * Fix the typo in max_vfreq (Manasi) > * Change the name of node to i915_vrr_info so we can add > other vrr info for more debug info (Manasi) > * Change the VRR capable to display Yes or No (Manasi) > * Fix indentation checkpatch errors (Manasi) > v3: > * Remove the unnecessary debug print (Manasi) > v4: > * Rebase > v5: > * Rename to vrr_range to match AMD debugfs > v6: > * Rebase (manasi) > v7: > * Fix cmpilation due to rebase > v8: > * Move debugfs node creation logic to DRM (Emil) > * Remove AMD specific logic (Emil) > v9: > * Seperate patch for removal of AMD specific logic (Manasi) > = > Signed-off-by: Bhanuprakash Modem > Signed-off-by: Manasi Navare > Cc: Jani Nikula > Cc: Ville Syrj=E4l=E4 > Cc: Harry Wentland > CC: Emil Velikov Looks good to me, Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/drm_debugfs.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > = > diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c > index bfe4602f206b..3d7182001004 100644 > --- a/drivers/gpu/drm/drm_debugfs.c > +++ b/drivers/gpu/drm/drm_debugfs.c > @@ -376,6 +376,24 @@ static ssize_t edid_write(struct file *file, const c= har __user *ubuf, > return (ret) ? ret : len; > } > = > +/* > + * Returns the min and max vrr vfreq through the connector's debugfs fil= e. > + * Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range > + */ > +static int vrr_range_show(struct seq_file *m, void *data) > +{ > + struct drm_connector *connector =3D m->private; > + > + if (connector->status !=3D connector_status_connected) > + return -ENODEV; > + > + seq_printf(m, "Min: %u\n", (u8)connector->display_info.monitor_range.mi= n_vfreq); > + seq_printf(m, "Max: %u\n", (u8)connector->display_info.monitor_range.ma= x_vfreq); > + > + return 0; > +} > +DEFINE_SHOW_ATTRIBUTE(vrr_range); > + > static const struct file_operations drm_edid_fops =3D { > .owner =3D THIS_MODULE, > .open =3D edid_open, > @@ -413,6 +431,10 @@ void drm_debugfs_connector_add(struct drm_connector = *connector) > /* edid */ > debugfs_create_file("edid_override", S_IRUGO | S_IWUSR, root, connector, > &drm_edid_fops); > + > + /* vrr range */ > + debugfs_create_file("vrr_range", S_IRUGO, root, connector, > + &vrr_range_fops); > } > = > void drm_debugfs_connector_remove(struct drm_connector *connector) > -- = > 2.20.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx