From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AD3C433E0 for ; Tue, 30 Jun 2020 21:20:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A33CD20663 for ; Tue, 30 Jun 2020 21:20:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A33CD20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4218E88E79; Tue, 30 Jun 2020 21:20:31 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id E663C88E79 for ; Tue, 30 Jun 2020 21:20:29 +0000 (UTC) IronPort-SDR: DlRF3ckb38a67VHwdlFNVqeYA7jP9Da8ylbmnRZ2De6Q1dClYwMi8YE3/JTOW5u/rgeVjKCK1D bJtNEEz1Vk5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="126482448" X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="126482448" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 14:20:29 -0700 IronPort-SDR: m63KZ6yQWBTwq+JISJQmtDXqbns5dwaAzqjDATKiaLGwMJPnEweY2dirHg0tFm6uX221OKL6Nk 2db/gA0Gkk4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="321041066" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 30 Jun 2020 14:20:27 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 01 Jul 2020 00:20:26 +0300 Date: Wed, 1 Jul 2020 00:20:26 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Manasi Navare Message-ID: <20200630212026.GV6112@intel.com> References: <20200626232641.4557-1-manasi.d.navare@intel.com> <20200626232641.4557-2-manasi.d.navare@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626232641.4557-2-manasi.d.navare@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/dp: Helper to check for DDI BUF status to get active X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jun 26, 2020 at 04:26:41PM -0700, Manasi Navare wrote: > Based on the platform, Bspec expects us to wait or poll with > timeout for DDI BUF IDLE bit to be set to 0 (non idle) or get active > after enabling DDI_BUF_CTL. > = > v4: > * Use the timeout for GLK (Ville) > v3: > * Add a new function _active for DDI BUF CTL to be non idle (Ville) > v2: > * Based on platform, fixed delay or poll (Ville) > * Use a helper to do this (Imre, Ville) > = > Cc: Ville Syrj=E4l=E4 > Cc: Imre Deak > Signed-off-by: Manasi Navare > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i= 915/display/intel_ddi.c > index 052a74625a61..94d57b57139b 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -1195,6 +1195,20 @@ static void intel_wait_ddi_buf_idle(struct drm_i91= 5_private *dev_priv, > port_name(port)); > } > = > +static void intel_wait_ddi_buf_active(struct drm_i915_private *dev_priv, > + enum port port) > +{ > + if (INTEL_GEN(dev_priv) < 10 && !IS_GEMINILAKE(dev_priv) ) { > + usleep_range(600, 1000); I would probably put a spec quote here to make it clear what this is: "Wait >518 us for buffers to enable..." Or we could s/600/518/ to make it easier to figure out. But that could be a followup. > + return; > + } > + > + if (wait_for_us(!(intel_de_read(dev_priv, DDI_BUF_CTL(port)) & > + DDI_BUF_IS_IDLE), 600)) Spec says 500 usec for this. Is there a reason to not go with the spec value? I guess one argument is that we didn't do it before. But I'd probably change it, if not in this patch then as a followup. > + drm_err(&dev_priv->drm, "Timeout waiting for DDI BUF %c to get active\= n", > + port_name(port)); > +} > + > static u32 hsw_pll_to_ddi_pll_sel(const struct intel_shared_dpll *pll) > { > switch (pll->info->id) { > @@ -4020,7 +4034,7 @@ static void intel_ddi_prepare_link_retrain(struct i= ntel_dp *intel_dp) > intel_de_write(dev_priv, DDI_BUF_CTL(port), intel_dp->DP); > intel_de_posting_read(dev_priv, DDI_BUF_CTL(port)); > = > - udelay(600); > + intel_wait_ddi_buf_active(dev_priv, port); Still can't see fdi anywhere. Whatever Reviewed-by: Ville Syrj=E4l=E4 > } > = > static void intel_ddi_set_link_train(struct intel_dp *intel_dp, > -- = > 2.19.1 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx