From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C512FC433E0 for ; Thu, 9 Jul 2020 11:01:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1D7320774 for ; Thu, 9 Jul 2020 11:01:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1D7320774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54B516E405; Thu, 9 Jul 2020 11:01:26 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F3096E405 for ; Thu, 9 Jul 2020 11:01:24 +0000 (UTC) IronPort-SDR: Xaw/D/jDAr3PUwwriPmOzke5zGr18TXR8fiyRyOLKsAEh9idhH2E7WbitdSEXIyASudBjmU6Y5 Me9QVvMNUmRw== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="136200200" X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="136200200" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 04:01:24 -0700 IronPort-SDR: yMH9gcHtEQ8uDtSNej9yJZbh4A47U2WRnM2rRE1pl9fYMFkCOZQN4T55woKQWSohrJuCyBaqLK fEp4PFcPGyxQ== X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="428170171" Received: from ideak-desk.fi.intel.com ([10.237.68.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 04:01:23 -0700 Date: Thu, 9 Jul 2020 14:01:19 +0300 From: Imre Deak To: Ville Syrjala Message-ID: <20200709110119.GC16776@ideak-desk.fi.intel.com> References: <20200108181242.13650-1-ville.syrjala@linux.intel.com> <20200108181242.13650-6-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200108181242.13650-6-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: Reject DRM_MODE_FLAG_DBLCLK with DVI sinks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jan 08, 2020 at 08:12:39PM +0200, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > The code assumes that DRM_MODE_FLAG_DBLCLK means that we enable the > pixel repeat feature. That only works with HDMI since it requires > AVI infoframe to signal the information to the sink. Hence even if > the mode dotclock would be valid we cannot currently assume that > we can just ignore the DBLCLK flag. Reject it for DVI sinks. > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/= i915/display/intel_hdmi.c > index 85c5f840a0fc..a62dd3348301 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -2185,8 +2185,11 @@ intel_hdmi_mode_valid(struct drm_connector *connec= tor, > if (clock > max_dotclk) > return MODE_CLOCK_HIGH; > = > - if (mode->flags & DRM_MODE_FLAG_DBLCLK) > + if (mode->flags & DRM_MODE_FLAG_DBLCLK) { > + if (!has_hdmi_sink) > + return MODE_CLOCK_LOW; MODE_H_ILLEGAL is used elsewhere for this case, and also an odd MODE_BAD at one place. > clock *=3D 2; > + } > = > if (drm_mode_is_420_only(&connector->display_info, mode)) > clock /=3D 2; > -- = > 2.24.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx