From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E0BC433EB for ; Tue, 14 Jul 2020 16:08:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B966B2253A for ; Tue, 14 Jul 2020 16:08:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B966B2253A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72B836E40C; Tue, 14 Jul 2020 16:08:38 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48E986E40C for ; Tue, 14 Jul 2020 16:08:37 +0000 (UTC) IronPort-SDR: 7roAG6B+jqTrSzq3uk0gt3KR11x1ijXsr7CJXaw6Ur126GozkNNLAZL7879d8wYpgZDap3AXYm EAgc3HizrBmA== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="137084157" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="137084157" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 09:08:36 -0700 IronPort-SDR: eDj7aRDI6v2/mdHQPAJrPgm4CiSUH++3KwH/mwrF3yV53jHXwEeW7ZVjgcVyuxGLxYZY508YYN i0ULXSL9RLRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="285802271" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 14 Jul 2020 09:08:34 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 14 Jul 2020 19:08:33 +0300 Date: Tue, 14 Jul 2020 19:08:33 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Message-ID: <20200714160833.GL6112@intel.com> References: <20200714153141.10280-1-imre.deak@intel.com> <20200714153141.10280-2-imre.deak@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714153141.10280-2-imre.deak@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/ddi: Don't rewrite DDI_BUF_CTL reg during DP link training X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jul 14, 2020 at 06:31:41PM +0300, Imre Deak wrote: > The driver enables the DDI function in the DDI_BUF_CTL register before > starting the link training and disables it when disabling the output. It > also gets disabled/re-enabled during link re-trainining. > = > Except of the above the value we program to the register (intel_dp->DP) > doesn't change, so no need to reprogram the register when changing the > link training patterns. > = > Signed-off-by: Imre Deak The only concern I had was the buf trans stuff for hsw/bdw/skl, but looks like hsw_set_signal_levels() does everything we need. Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 4 ---- > 1 file changed, 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i= 915/display/intel_ddi.c > index c467f18d5e1b..424d59671561 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -4060,7 +4060,6 @@ static void intel_ddi_set_link_train(struct intel_d= p *intel_dp, > { > struct drm_i915_private *dev_priv =3D dp_to_i915(intel_dp); > u8 train_pat_mask =3D drm_dp_training_pattern_mask(intel_dp->dpcd); > - enum port port =3D dp_to_dig_port(intel_dp)->base.port; > u32 temp; > = > temp =3D intel_de_read(dev_priv, intel_dp->regs.dp_tp_ctl); > @@ -4085,9 +4084,6 @@ static void intel_ddi_set_link_train(struct intel_d= p *intel_dp, > } > = > intel_de_write(dev_priv, intel_dp->regs.dp_tp_ctl, temp); > - > - intel_de_write(dev_priv, DDI_BUF_CTL(port), intel_dp->DP); > - intel_de_posting_read(dev_priv, DDI_BUF_CTL(port)); > } > = > static void intel_ddi_set_idle_link_train(struct intel_dp *intel_dp) > -- = > 2.23.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx