From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD5DC433E3 for ; Sat, 18 Jul 2020 16:37:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA8762080D for ; Sat, 18 Jul 2020 16:37:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA8762080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 588CA6E1A8; Sat, 18 Jul 2020 16:37:07 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93FB16E124; Sat, 18 Jul 2020 16:37:05 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 64E2620024; Sat, 18 Jul 2020 18:37:03 +0200 (CEST) Date: Sat, 18 Jul 2020 18:37:01 +0200 From: Sam Ravnborg To: Anitha Chrisanthus Message-ID: <20200718163701.GA3010985@ravnborg.org> References: <1595020551-30768-1-git-send-email-anitha.chrisanthus@intel.com> <1595020551-30768-2-git-send-email-anitha.chrisanthus@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1595020551-30768-2-git-send-email-anitha.chrisanthus@intel.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=KHs3S8JdNAQvkEa9sOgA:9 a=wPNLvfGTeEIA:10 Subject: Re: [Intel-gfx] [PATCH v3] drm/kmb: Add support for KeemBay Display X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, edmund.j.dea@intel.com, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Anitha. A few extra details. > diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crt= c.c > new file mode 100644 > index 0000000..570d46e > --- /dev/null > +++ b/drivers/gpu/drm/kmb/kmb_crtc.c > @@ -0,0 +1,219 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright =A9 2018-2020 Intel Corporation > + */ > + > +#include > +#include Not used, can be dropped. Gos for all includes except the one in kmb_drv.c > +#include Not used, can be dropped. Goes for all include of this file. > + /* disable vertical interrupt */ > + kmb_clr_bitmask_lcd(dev_p, LCD_INT_ENABLE, > + LCD_INT_VERT_COMP); > +} > + > +static const struct drm_crtc_funcs kmb_crtc_funcs =3D { > + .destroy =3D kmb_crtc_cleanup, > + .set_config =3D drm_atomic_helper_set_config, >From the description of set_config: * Drivers implementing atomic modeset should use * drm_atomic_helper_set_config() to implement this hook. Sam _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx