From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA347C433DF for ; Tue, 11 Aug 2020 08:57:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD05A20678 for ; Tue, 11 Aug 2020 08:57:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD05A20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F7F889B96; Tue, 11 Aug 2020 08:57:22 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1829C89B96; Tue, 11 Aug 2020 08:57:21 +0000 (UTC) IronPort-SDR: KRhEesK2wzOZRyMFbHg48jUEnpPElz8cWe0TWJ2FVr7qeMb8cYgeUgmVy+wRIpdn+w1whcGomi 4EAEF4pfpzig== X-IronPort-AV: E=McAfee;i="6000,8403,9709"; a="218030519" X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="asc'?scan'208";a="218030519" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 01:57:20 -0700 IronPort-SDR: 6w6pEaNMHsf3yFldUzEZW7pA/PGPHU3iNV03jY5lWj7tErsW5U82MaqytpMB0xbzib4Zfiv61T 11w2wjZrKpOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="asc'?scan'208";a="494611047" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.160.147]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2020 01:57:18 -0700 Date: Tue, 11 Aug 2020 16:39:09 +0800 From: Zhenyu Wang To: Chris Wilson Message-ID: <20200811083909.GM27035@zhen-hp.sh.intel.com> References: <20200811030209.21058-1-yan.y.zhao@intel.com> <159713437103.2955.4439985576665396417@build.alporthouse.com> MIME-Version: 1.0 In-Reply-To: <159713437103.2955.4439985576665396417@build.alporthouse.com> User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt:fix raw-wakeref not held calltrace in vGPU X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Zhenyu Wang Cc: intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Yan Zhao Content-Type: multipart/mixed; boundary="===============1902971479==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============1902971479== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="APsrsY0yTFDXy1q8" Content-Disposition: inline --APsrsY0yTFDXy1q8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2020.08.11 09:26:11 +0100, Chris Wilson wrote: > Quoting Yan Zhao (2020-08-11 04:02:09) > > UNCORE_HAS_FORCEWAKE is not turned on when intel_vgpu_active() returns > > true, so the guest mmio writes go to gen2_write32(). >=20 > The vgpu writes are just memory traps, the device wakeref should not be > required. It seems like we've accidentally added the assert to the wrong > io accessors. yeah, I agree. I did remember we didn't have that assert before for vgpu case... maybe better hook with explicit vgpu_read()/vgpu_write() that won't be affected by other changes. --APsrsY0yTFDXy1q8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCXzJZLQAKCRCxBBozTXgY J1h0AJ9/XbyF3jeaoSuF1hm+FEEWH7I1OgCfQAOIVos3VAmLu4wrgp7BwMAP314= =y+Gq -----END PGP SIGNATURE----- --APsrsY0yTFDXy1q8-- --===============1902971479== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1902971479==--