From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2800AC433E1 for ; Fri, 21 Aug 2020 08:01:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 038BA2087D for ; Fri, 21 Aug 2020 08:01:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 038BA2087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75C456E103; Fri, 21 Aug 2020 08:01:25 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 467636E0E2; Fri, 21 Aug 2020 08:01:24 +0000 (UTC) IronPort-SDR: ngg5JXo94a8dHVPSyVzShUktJ8T7euW370rHk+GKQAP0QM+UxcH86Ov56aYm3TjoyjzBdF/Zoq 7CBs8ea3+Pcg== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="153087399" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="153087399" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 01:01:23 -0700 IronPort-SDR: V5ykKVf37xtN9hWUTjgEqhbFgTB8DPDzus78Fq+kSW7pC3vJiJiiXboGqEYDslbzWkaytVQE4a uERGW3ItJQ/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="327698192" Received: from thrakatuluk.fi.intel.com (HELO thrakatuluk) ([10.237.68.154]) by orsmga008.jf.intel.com with ESMTP; 21 Aug 2020 01:01:22 -0700 Received: from platvala by thrakatuluk with local (Exim 4.92) (envelope-from ) id 1k91sv-0006Fp-H6; Fri, 21 Aug 2020 10:54:49 +0300 Date: Fri, 21 Aug 2020 10:54:49 +0300 From: Petri Latvala To: Lionel Landwerlin Message-ID: <20200821075449.GE7444@platvala-desk.ger.corp.intel.com> References: <20200820182640.65842-1-chris@chris-wilson.co.uk> <5bdb17eb-4f92-ac67-5d89-de7b797663f8@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5bdb17eb-4f92-ac67-5d89-de7b797663f8@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf: 32bit printf cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Aug 21, 2020 at 12:45:23AM +0300, Lionel Landwerlin wrote: > On 20/08/2020 20:26, Chris Wilson wrote: > > Use PRI[du]64 as necessary for 32bit builds. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Lionel Landwerlin > Was this for just 1/4 or the whole series? This one is for the whole series: Reviewed-by: Petri Latvala > > Thanks! > > -Lionel > > > --- > > tests/i915/perf.c | 8 ++++---- > > tools/i915-perf/i915_perf_recorder.c | 2 +- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/tests/i915/perf.c b/tests/i915/perf.c > > index 92edc9f1f..a894fd382 100644 > > --- a/tests/i915/perf.c > > +++ b/tests/i915/perf.c > > @@ -2077,7 +2077,7 @@ test_blocking(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t ke > > user_ns = (end_times.tms_utime - start_times.tms_utime) * tick_ns; > > kernel_ns = (end_times.tms_stime - start_times.tms_stime) * tick_ns; > > - igt_debug("%d blocking reads during test with %lu Hz OA sampling (expect no more than %d)\n", > > + igt_debug("%d blocking reads during test with %"PRIu64" Hz OA sampling (expect no more than %d)\n", > > n, NSEC_PER_SEC / oa_period, max_iterations); > > igt_debug("%d extra iterations seen, not related to periodic sampling (e.g. context switches)\n", > > n_extra_iterations); > > @@ -2265,7 +2265,7 @@ test_polling(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t ker > > user_ns = (end_times.tms_utime - start_times.tms_utime) * tick_ns; > > kernel_ns = (end_times.tms_stime - start_times.tms_stime) * tick_ns; > > - igt_debug("%d non-blocking reads during test with %lu Hz OA sampling (expect no more than %d)\n", > > + igt_debug("%d non-blocking reads during test with %"PRIu64" Hz OA sampling (expect no more than %d)\n", > > n, NSEC_PER_SEC / oa_period, max_iterations); > > igt_debug("%d extra iterations seen, not related to periodic sampling (e.g. context switches)\n", > > n_extra_iterations); > > @@ -2357,7 +2357,7 @@ num_valid_reports_captured(struct drm_i915_perf_open_param *param, > > int64_t start, end; > > int num_reports = 0; > > - igt_debug("Expected duration = %lu\n", *duration_ns); > > + igt_debug("Expected duration = %"PRId64"\n", *duration_ns); > > stream_fd = __perf_open(drm_fd, param, true); > > @@ -2389,7 +2389,7 @@ num_valid_reports_captured(struct drm_i915_perf_open_param *param, > > *duration_ns = end - start; > > - igt_debug("Actual duration = %lu\n", *duration_ns); > > + igt_debug("Actual duration = %"PRIu64"\n", *duration_ns); > > return num_reports; > > } > > diff --git a/tools/i915-perf/i915_perf_recorder.c b/tools/i915-perf/i915_perf_recorder.c > > index 7671f39b4..adc41c29f 100644 > > --- a/tools/i915-perf/i915_perf_recorder.c > > +++ b/tools/i915-perf/i915_perf_recorder.c > > @@ -1001,7 +1001,7 @@ main(int argc, char *argv[]) > > } > > ctx.oa_exponent = oa_exponent_for_period(ctx.timestamp_frequency, perf_period); > > - fprintf(stdout, "Opening perf stream with metric_id=%lu oa_exponent=%u\n", > > + fprintf(stdout, "Opening perf stream with metric_id=%"PRIu64" oa_exponent=%u\n", > > ctx.metric_set->perf_oa_metrics_set, ctx.oa_exponent); > > ctx.perf_fd = perf_open(&ctx); > > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx