From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAFCC43461 for ; Fri, 11 Sep 2020 12:44:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C554C206DB for ; Fri, 11 Sep 2020 12:44:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C554C206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C5176EA20; Fri, 11 Sep 2020 12:44:30 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A82576EA20; Fri, 11 Sep 2020 12:44:29 +0000 (UTC) IronPort-SDR: tFfqmvjcUN/CBgovttizzLCbmCDC3z3u4lVGR4WKuYUUcUB9rDzkF0SYjroddmKFx74trhs9Hg WfMexwKTehww== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="138262252" X-IronPort-AV: E=Sophos;i="5.76,415,1592895600"; d="scan'208";a="138262252" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 05:44:29 -0700 IronPort-SDR: E/tFw/+Z93hiMBb9LiJVdvTPEButG5UeUcQnSyACkWQpDxdSNlej5p1IKJZ1sgX7DWV5KYX6bO y1lASXsd9MlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,415,1592895600"; d="scan'208";a="334503028" Received: from thrakatuluk.fi.intel.com (HELO thrakatuluk) ([10.237.68.154]) by orsmga008.jf.intel.com with ESMTP; 11 Sep 2020 05:44:27 -0700 Received: from platvala by thrakatuluk with local (Exim 4.92) (envelope-from ) id 1kGi4Z-0001Om-SV; Fri, 11 Sep 2020 15:22:35 +0300 Date: Fri, 11 Sep 2020 15:22:35 +0300 From: Petri Latvala To: Janusz Krzysztofik Message-ID: <20200911122235.GO7444@platvala-desk.ger.corp.intel.com> References: <20200911103039.4574-1-janusz.krzysztofik@linux.intel.com> <20200911103039.4574-22-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200911103039.4574-22-janusz.krzysztofik@linux.intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, =?utf-8?Q?Micha=C5=82?= Winiarski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 11, 2020 at 12:30:36PM +0200, Janusz Krzysztofik wrote: > Unbinding the i915 driver on some Haswell and Broadwell platforms with > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1 > wakelocks=1 on cleanup". The issue can be worked around by manually > enabling runtime power management for the conflicting audio adapter. > Use that method but also display a warning to preserve visibility of > the issue. Also tag the workaround with a FIXME comment. > > v2: Extend the scope of the workaround over Broadwell > > Signed-off-by: Janusz Krzysztofik > --- > tests/core_hotunplug.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c > index ac106d964..3e2a76ddb 100644 > --- a/tests/core_hotunplug.c > +++ b/tests/core_hotunplug.c > @@ -484,8 +484,23 @@ igt_main > igt_skip_on_f(fd_drm < 0, "No known DRM device found\n"); > > if (is_i915_device(fd_drm)) { > + uint32_t devid = intel_get_drm_devid(fd_drm); > + > gem_quiescent_gpu(fd_drm); > igt_require_gem(fd_drm); > + > + /** > + * FIXME: Unbinding the i915 driver on some Haswell > + * platforms with Azalia audio results in a kernel WARN > + * on "i915 raw-wakerefs=1 wakelocks=1 on cleanup". The > + * below CI friendly user level workaround prevents the > + * warning from appearing. Drop this hack as soon as > + * this is fixed in the kernel. > + */ > + if (igt_warn_on_f(IS_HASWELL(devid) || > + IS_BROADWELL(devid), > + "Manually enabling audio PM to work around a kernel WARN\n")) > + igt_pm_enable_audio_runtime_pm(); What happens without this? Is it just a kernel warning, or does the operation also fail? If the former, what does this gain? All it does is we lose the capability to track whether the kernel still has that issue, we still have to filter this warning in cibuglog. -- Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx