From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1D6C43461 for ; Fri, 11 Sep 2020 14:17:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9627C22242 for ; Fri, 11 Sep 2020 14:17:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9627C22242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 141476E94A; Fri, 11 Sep 2020 14:17:31 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 467D26E94A; Fri, 11 Sep 2020 14:17:30 +0000 (UTC) IronPort-SDR: vz/ZeN5HKAwhHtQXjC2YfWsdz1IgsdaYRrPr/aHJ+7+eMKucwVzvYCcadMmVoP4BFc4+9JOjSY HsLUHltxxXog== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="176822542" X-IronPort-AV: E=Sophos;i="5.76,415,1592895600"; d="scan'208";a="176822542" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 07:17:29 -0700 IronPort-SDR: R5hpqzOalaMDmgRLKJaU0+92+ys9iurELA1gNH+OtcNM9CtIQHU8ZiZtuNJufeB10IxAWNCgiq 60AkToU4L3rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,415,1592895600"; d="scan'208";a="334524694" Received: from thrakatuluk.fi.intel.com (HELO thrakatuluk) ([10.237.68.154]) by orsmga008.jf.intel.com with ESMTP; 11 Sep 2020 07:17:26 -0700 Received: from platvala by thrakatuluk with local (Exim 4.92) (envelope-from ) id 1kGjrh-0001it-VU; Fri, 11 Sep 2020 17:17:25 +0300 Date: Fri, 11 Sep 2020 17:17:25 +0300 From: Petri Latvala To: Janusz Krzysztofik Message-ID: <20200911141725.GP7444@platvala-desk.ger.corp.intel.com> References: <20200911103039.4574-1-janusz.krzysztofik@linux.intel.com> <20200911103039.4574-22-janusz.krzysztofik@linux.intel.com> <20200911122235.GO7444@platvala-desk.ger.corp.intel.com> <162f01fdd164618423a4786b6a7d23bac852bfc0.camel@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <162f01fdd164618423a4786b6a7d23bac852bfc0.camel@linux.intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, =?utf-8?Q?Micha=C5=82?= Winiarski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 11, 2020 at 03:15:43PM +0200, Janusz Krzysztofik wrote: > Hi Petri, > > On Fri, 2020-09-11 at 15:22 +0300, Petri Latvala wrote: > > On Fri, Sep 11, 2020 at 12:30:36PM +0200, Janusz Krzysztofik wrote: > > > Unbinding the i915 driver on some Haswell and Broadwell platforms with > > > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1 > > > wakelocks=1 on cleanup". The issue can be worked around by manually > > > enabling runtime power management for the conflicting audio adapter. > > > Use that method but also display a warning to preserve visibility of > > > the issue. Also tag the workaround with a FIXME comment. > > > > > > v2: Extend the scope of the workaround over Broadwell > > > > > > Signed-off-by: Janusz Krzysztofik > > > --- > > > tests/core_hotunplug.c | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c > > > index ac106d964..3e2a76ddb 100644 > > > --- a/tests/core_hotunplug.c > > > +++ b/tests/core_hotunplug.c > > > @@ -484,8 +484,23 @@ igt_main > > > igt_skip_on_f(fd_drm < 0, "No known DRM device found\n"); > > > > > > if (is_i915_device(fd_drm)) { > > > + uint32_t devid = intel_get_drm_devid(fd_drm); > > > + > > > gem_quiescent_gpu(fd_drm); > > > igt_require_gem(fd_drm); > > > + > > > + /** > > > + * FIXME: Unbinding the i915 driver on some Haswell > > > + * platforms with Azalia audio results in a kernel WARN > > > + * on "i915 raw-wakerefs=1 wakelocks=1 on cleanup". The > > > + * below CI friendly user level workaround prevents the > > > + * warning from appearing. Drop this hack as soon as > > > + * this is fixed in the kernel. > > > + */ > > > + if (igt_warn_on_f(IS_HASWELL(devid) || > > > + IS_BROADWELL(devid), > > > + "Manually enabling audio PM to work around a kernel WARN\n")) > > > + igt_pm_enable_audio_runtime_pm(); > > > > What happens without this? Is it just a kernel warning, or does the > > operation also fail? > > runner: This test was killed due to a kernel taint (0x200). > (https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4901/shard-hsw4/igt@core_hotunplug@unbind-rebind.html) > > That happens before the test completes so no results of the operation > are reported. Ah, right. I had a brainfart. Indeed this igt_warn is better. Reviewed-by: Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx