From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37850C43461 for ; Tue, 15 Sep 2020 14:07:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCFF82220D for ; Tue, 15 Sep 2020 14:07:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCFF82220D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0313A8920E; Tue, 15 Sep 2020 14:07:27 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8D988920E; Tue, 15 Sep 2020 14:07:25 +0000 (UTC) IronPort-SDR: nBJFAhVy7Do3uwfVAkfJi9Et0WXgPhPHKezT0m7cu3gxxK3HJmG6TTt6H2W9sXpNDES1jLhylu OXE++Bq0FD/g== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="177329953" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="177329953" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 07:07:24 -0700 IronPort-SDR: aGYtl15hg1DUW7ctfkvwP6meEMcRsPQpSyEUg0nCmp37aTUVB+VarDi3mGW6b8EqbstLsOXDnB cYmnh/yVWJiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="343517109" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 15 Sep 2020 07:07:20 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 15 Sep 2020 17:07:19 +0300 Date: Tue, 15 Sep 2020 17:07:19 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Karthik B S Message-ID: <20200915140719.GK6112@intel.com> References: <20200914055633.21109-1-karthik.b.s@intel.com> <20200914055633.21109-5-karthik.b.s@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914055633.21109-5-karthik.b.s@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v8 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: paulo.r.zanoni@intel.com, michel@daenzer.net, dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com, daniel.vetter@intel.com, harry.wentland@amd.com, intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Sep 14, 2020 at 11:26:29AM +0530, Karthik B S wrote: > Since the flip done event will be sent in the flip_done_handler, > no need to add the event to the list and delay it for later. > = > v2: -Moved the async check above vblank_get as it > was causing issues for PSR. > = > v3: -No need to wait for vblank to pass, as this wait was causing a > 16ms delay once every few flips. > = > v4: -Rebased. > = > v5: -Rebased. > = > v6: -Rebased. > = > v7: -No need of irq disable if we are not doing vblank evade. (Ville) > = > v8: -Rebased. > = > Signed-off-by: Karthik B S > Signed-off-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++++++ > 1 file changed, 6 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/dr= m/i915/display/intel_sprite.c > index 5ac0dbf0e03d..f0c89418d2e1 100644 > --- a/drivers/gpu/drm/i915/display/intel_sprite.c > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c > @@ -93,6 +93,9 @@ void intel_pipe_update_start(const struct intel_crtc_st= ate *new_crtc_state) > DEFINE_WAIT(wait); > u32 psr_status; > = > + if (new_crtc_state->uapi.async_flip) > + return; > + > vblank_start =3D adjusted_mode->crtc_vblank_start; > if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) > vblank_start =3D DIV_ROUND_UP(vblank_start, 2); > @@ -202,6 +205,9 @@ void intel_pipe_update_end(struct intel_crtc_state *n= ew_crtc_state) > = > trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end); > = > + if (new_crtc_state->uapi.async_flip) > + return; The pipe update tracepoints will be inconsistent if you put this here. I guess we don't really need the pipe update tracepoints for async flips. We might want to add a separate tracepoint for async flip itself, or perhaps convey the sync vs. async information via the current plane update tracepoint. With this moved to before the tracepoint Reviewed-by: Ville Syrj=E4l=E4 > + > /* We're still in the vblank-evade critical section, this can't race. > * Would be slightly nice to just grab the vblank count and arm the > * event outside of the critical section - the spinlock might spin for a > -- = > 2.22.0 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx