Re: [Intel-gfx] [PATCH v2 09/11] drm/i915: Split TGL DKL PHY buf trans per output type

Imre Deak
2020-09-30T15:31:38Z

On Wed, Sep 30, 2020 at 02:34:47AM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the mess inside the buf trans funcs a bit more manageable by
> splitting along the lines of output type.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 31 ++++++++++++++++++------
> 1 file changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index fea06c1b09d9..7032c367075a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -1218,19 +1218,34 @@ tgl_get_combo_buf_trans(struct intel_encoder *encoder, int type, int rate,
> }
>
> static const struct tgl_dkl_phy_ddi_buf_trans *
> -tgl_get_dkl_buf_trans(struct intel_encoder *encoder, int type, int rate,
> - int *n_entries)
> +tgl_get_dkl_buf_trans_hdmi(struct intel_encoder *encoder, int type, int rate,
> + int *n_entries)
> {
> - if (type == INTEL_OUTPUT_HDMI) {
> - *n_entries = ARRAY_SIZE(tgl_dkl_phy_hdmi_ddi_trans);
> - return tgl_dkl_phy_hdmi_ddi_trans;
> - } else if (rate > 270000) {
> + *n_entries = ARRAY_SIZE(tgl_dkl_phy_hdmi_ddi_trans);
> + return tgl_dkl_phy_hdmi_ddi_trans;
> +}
> +
> +static const struct tgl_dkl_phy_ddi_buf_trans *
> +tgl_get_dkl_buf_trans_dp(struct intel_encoder *encoder, int type, int rate,
> + int *n_entries)
> +{
> + if (rate > 270000) {
> *n_entries = ARRAY_SIZE(tgl_dkl_phy_dp_ddi_trans_hbr2);
> return tgl_dkl_phy_dp_ddi_trans_hbr2;
> + } else {
> + *n_entries = ARRAY_SIZE(tgl_dkl_phy_dp_ddi_trans);
> + return tgl_dkl_phy_dp_ddi_trans;
> }
> +}
>
> - *n_entries = ARRAY_SIZE(tgl_dkl_phy_dp_ddi_trans);
> - return tgl_dkl_phy_dp_ddi_trans;
> +static const struct tgl_dkl_phy_ddi_buf_trans *
> +tgl_get_dkl_buf_trans(struct intel_encoder *encoder, int type, int rate,
> + int *n_entries)
> +{
> + if (type == INTEL_OUTPUT_HDMI)
> + return tgl_get_dkl_buf_trans_hdmi(encoder, type, rate, n_entries);
> + else
> + return tgl_get_dkl_buf_trans_dp(encoder, type, rate, n_entries);
> }
>
> static int intel_ddi_hdmi_level(struct intel_encoder *encoder)
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx