Re: [Intel-gfx] [PATCH v2 02/11] drm/i915: s/old_crtc_state/crtc_state/

Imre Deak
2020-09-30T13:57:29Z

On Wed, Sep 30, 2020 at 02:34:40AM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_dp_enable_port() is called during the enable sequence,
> so there is nothing old about the passed in crtc state.
> Rename it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index ff96540c8612..3586d79f5599 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3850,7 +3850,7 @@ g4x_set_link_train(struct intel_dp *intel_dp,
> }
>
> static void intel_dp_enable_port(struct intel_dp *intel_dp,
> - const struct intel_crtc_state *old_crtc_state)
> + const struct intel_crtc_state *crtc_state)
> {
> struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
>
> @@ -3865,7 +3865,7 @@ static void intel_dp_enable_port(struct intel_dp *intel_dp,
> * fail when the power sequencer is freshly used for this port.
> */
> intel_dp->DP |= DP_PORT_EN;
> - if (old_crtc_state->has_audio)
> + if (crtc_state->has_audio)
> intel_dp->DP |= DP_AUDIO_OUTPUT_ENABLE;
>
> intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx