[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/jsl: Update JSL Voltage swing table

Patchwork
2020-10-01T22:00:52Z

== Series Details ==

Series: drm/i915/jsl: Update JSL Voltage swing table
URL : https://patchwork.freedesktop.org/series/82313/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7c3e877540c1 drm/i915/jsl: Split EHL/JSL platform info and PCI ids
-:156: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pll->info->id == DPLL_ID_EHL_DPLL4'
#156: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+ if (IS_EHL_JSL(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))

-:258: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#258: FILE: drivers/gpu/drm/i915/i915_drv.h:1420:
+#define IS_EHL_JSL(dev_priv) (IS_PLATFORM(dev_priv, INTEL_ELKHARTLAKE) || \
+ IS_PLATFORM(dev_priv, INTEL_JASPERLAKE))

-:375: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#375: FILE: include/drm/i915_pciids.h:592:
+#define INTEL_JSL_IDS(info) \
+ INTEL_VGA_DEVICE(0x4E71, info), \
INTEL_VGA_DEVICE(0x4E61, info), \
INTEL_VGA_DEVICE(0x4E57, info), \
INTEL_VGA_DEVICE(0x4E55, info), \

-:375: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#375: FILE: include/drm/i915_pciids.h:592:
+#define INTEL_JSL_IDS(info) \
+ INTEL_VGA_DEVICE(0x4E71, info), \
INTEL_VGA_DEVICE(0x4E61, info), \
INTEL_VGA_DEVICE(0x4E57, info), \
INTEL_VGA_DEVICE(0x4E55, info), \

total: 1 errors, 0 warnings, 3 checks, 273 lines checked
5b220796eaf0 drm/i915/edp/jsl: Update vswing table for HBR and HBR2
-:94: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#94: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1227:
+ return jsl_combo_phy_ddi_translations_edp_hbr2;
+ } else {

total: 0 errors, 1 warnings, 0 checks, 145 lines checked