From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF700C4363A for ; Fri, 23 Oct 2020 17:32:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19E0521527 for ; Fri, 23 Oct 2020 17:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19E0521527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43A1B6E323; Fri, 23 Oct 2020 17:32:05 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3691F6E2ED for ; Fri, 23 Oct 2020 17:32:04 +0000 (UTC) IronPort-SDR: wZBFkZMuggbr/hqvkpLdg2cforhhHhoZp1ZCJ9CGvWZebFlX2EkEYiVOnONVmvQ3aP0lI8xIb7 kgws/TYilX4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="229344172" X-IronPort-AV: E=Sophos;i="5.77,409,1596524400"; d="scan'208";a="229344172" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 10:32:03 -0700 IronPort-SDR: N/e+2EFAAxHARYMXTt1QGPFKhk+rkaQeMkycGr5abwjBGLDiaLGQZvSD4Q9/kqymdLeRDm1+ZB 6SYrAg641ZXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,409,1596524400"; d="scan'208";a="423486246" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 23 Oct 2020 10:32:01 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 23 Oct 2020 20:32:00 +0300 Date: Fri, 23 Oct 2020 20:32:00 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Manasi Navare Message-ID: <20201023173200.GX6112@intel.com> References: <20201022054223.25071-1-manasi.d.navare@intel.com> <20201022054223.25071-5-manasi.d.navare@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201022054223.25071-5-manasi.d.navare@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v11 04/12] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Oct 21, 2020 at 10:42:15PM -0700, Manasi Navare wrote: > From: Maarten Lankhorst > = > Small changes to intel_dp_mode_valid(), allow listing modes that > can only be supported in the bigjoiner configuration, which is > not supported yet. > = > eDP does not support bigjoiner, so do not expose bigjoiner only > modes on the eDP port. > = > v9: > * Restric Bigjoiner on PORT A (Ville) > v8: > * use source dotclock for max dotclock (Manasi) > v7: > * Add can_bigjoiner() helper (Ville) > * Pass bigjoiner to plane_size validation (Ville) > v6: > * Rebase after dp_downstream mode valid changes (Manasi) > v5: > * Increase max plane width to support 8K with bigjoiner (Maarten) > v4: > * Rebase (Manasi) > = > Changes since v1: > - Disallow bigjoiner on eDP. > Changes since v2: > - Rename intel_dp_downstream_max_dotclock to intel_dp_max_dotclock, > and split off the downstream and source checking to its own function. > (Ville) > v3: > * Rebase (Manasi) > = > Signed-off-by: Manasi Navare > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/display/intel_display.c | 5 +- > drivers/gpu/drm/i915/display/intel_display.h | 3 +- > drivers/gpu/drm/i915/display/intel_dp.c | 106 +++++++++++++++---- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > drivers/gpu/drm/i915/display/intel_dsi.c | 2 +- > drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- > 6 files changed, 96 insertions(+), 24 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/d= rm/i915/display/intel_display.c > index 9b4fcc734122..1c2d67ae361d 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -17751,7 +17751,8 @@ intel_mode_valid(struct drm_device *dev, > = > enum drm_mode_status > intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv, > - const struct drm_display_mode *mode) > + const struct drm_display_mode *mode, > + bool bigjoiner) > { > int plane_width_max, plane_height_max; > = > @@ -17768,7 +17769,7 @@ intel_mode_valid_max_plane_size(struct drm_i915_p= rivate *dev_priv, > * too big for that. > */ > if (INTEL_GEN(dev_priv) >=3D 11) { > - plane_width_max =3D 5120; > + plane_width_max =3D 5120 << bigjoiner; > plane_height_max =3D 4320; > } else { > plane_width_max =3D 5120; > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/d= rm/i915/display/intel_display.h > index 1b946209e06b..4f8dee9dfb4d 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.h > +++ b/drivers/gpu/drm/i915/display/intel_display.h > @@ -497,7 +497,8 @@ u32 intel_plane_fb_max_stride(struct drm_i915_private= *dev_priv, > bool intel_plane_can_remap(const struct intel_plane_state *plane_state); > enum drm_mode_status > intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv, > - const struct drm_display_mode *mode); > + const struct drm_display_mode *mode, > + bool bigjoiner); > enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port= ); > bool is_trans_port_sync_mode(const struct intel_crtc_state *state); > = > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i9= 15/display/intel_dp.c > index 2c29e7f5281b..d123e5a508c1 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -254,6 +254,29 @@ intel_dp_max_data_rate(int max_link_clock, int max_l= anes) > return max_link_clock * max_lanes; > } > = > +static bool intel_dp_can_bigjoiner(struct intel_dp *intel_dp) > +{ > + struct intel_digital_port *intel_dig_port =3D dp_to_dig_port(intel_dp); > + struct intel_encoder *encoder =3D &intel_dig_port->base; > + struct drm_i915_private *dev_priv =3D to_i915(encoder->base.dev); > + > + return INTEL_GEN(dev_priv) >=3D 12 || > + (INTEL_GEN(dev_priv) =3D=3D 11 && > + encoder->port !=3D PORT_A); > +} > + > +static int intel_dp_max_dotclock(struct intel_dp *intel_dp, bool allow_b= igjoiner) > +{ > + struct intel_digital_port *intel_dig_port =3D dp_to_dig_port(intel_dp); > + struct intel_encoder *encoder =3D &intel_dig_port->base; > + struct drm_i915_private *dev_priv =3D to_i915(encoder->base.dev); > + > + if (allow_bigjoiner && intel_dp_can_bigjoiner(intel_dp)) > + return 2 * dev_priv->max_dotclk_freq; > + > + return dev_priv->max_dotclk_freq; > +} > + > static int cnl_max_source_rate(struct intel_dp *intel_dp) > { > struct intel_digital_port *dig_port =3D dp_to_dig_port(intel_dp); > @@ -519,7 +542,8 @@ small_joiner_ram_size_bits(struct drm_i915_private *i= 915) > = > static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > u32 link_clock, u32 lane_count, > - u32 mode_clock, u32 mode_hdisplay) > + u32 mode_clock, u32 mode_hdisplay, > + bool bigjoiner) > { > u32 bits_per_pixel, max_bpp_small_joiner_ram; > int i; > @@ -537,6 +561,10 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i9= 15_private *i915, > /* Small Joiner Check: output bpp <=3D joiner RAM (bits) / Horiz. width= */ > max_bpp_small_joiner_ram =3D small_joiner_ram_size_bits(i915) / > mode_hdisplay; > + > + if (bigjoiner) > + max_bpp_small_joiner_ram *=3D 2; > + > drm_dbg_kms(&i915->drm, "Max small joiner bpp: %u\n", > max_bpp_small_joiner_ram); > = > @@ -546,6 +574,15 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i9= 15_private *i915, > */ > bits_per_pixel =3D min(bits_per_pixel, max_bpp_small_joiner_ram); > = > + if (bigjoiner) { > + u32 max_bpp_bigjoiner =3D > + i915->max_cdclk_freq * 48 / > + intel_dp_mode_to_fec_clock(mode_clock); > + > + DRM_DEBUG_KMS("Max big joiner bpp: %u\n", max_bpp_bigjoiner); > + bits_per_pixel =3D min(bits_per_pixel, max_bpp_bigjoiner); > + } > + > /* Error out if the max bpp is less than smallest allowed valid bpp */ > if (bits_per_pixel < valid_dsc_bpp[0]) { > drm_dbg_kms(&i915->drm, "Unsupported BPP %u, min %u\n", > @@ -568,7 +605,8 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i91= 5_private *i915, > } > = > static u8 intel_dp_dsc_get_slice_count(struct intel_dp *intel_dp, > - int mode_clock, int mode_hdisplay) > + int mode_clock, int mode_hdisplay, > + bool bigjoiner) > { > struct drm_i915_private *i915 =3D dp_to_i915(intel_dp); > u8 min_slice_count, i; > @@ -595,12 +633,20 @@ static u8 intel_dp_dsc_get_slice_count(struct intel= _dp *intel_dp, > = > /* Find the closest match to the valid slice count values */ > for (i =3D 0; i < ARRAY_SIZE(valid_dsc_slicecount); i++) { > - if (valid_dsc_slicecount[i] > > - drm_dp_dsc_sink_max_slice_count(intel_dp->dsc_dpcd, > - false)) > + u8 test_slice_count =3D bigjoiner ? > + 2 * valid_dsc_slicecount[i] : > + valid_dsc_slicecount[i]; > + > + if (test_slice_count > > + drm_dp_dsc_sink_max_slice_count(intel_dp->dsc_dpcd, false)) > break; > - if (min_slice_count <=3D valid_dsc_slicecount[i]) > - return valid_dsc_slicecount[i]; > + > + /* big joiner needs small joiner to be enabled */ > + if (bigjoiner && test_slice_count < 4) > + continue; > + > + if (min_slice_count <=3D test_slice_count) > + return test_slice_count; > } > = > drm_dbg_kms(&i915->drm, "Unsupported Slice Count %d\n", > @@ -684,10 +730,6 @@ intel_dp_mode_valid_downstream(struct intel_connecto= r *connector, > const struct drm_display_info *info =3D &connector->base.display_info; > int tmds_clock; > = > - if (intel_dp->dfp.max_dotclock && > - target_clock > intel_dp->dfp.max_dotclock) > - return MODE_CLOCK_HIGH; > - > /* Assume 8bpc for the DP++/HDMI/DVI TMDS clock check */ > tmds_clock =3D target_clock; > if (drm_mode_is_420_only(info, mode)) > @@ -717,6 +759,7 @@ intel_dp_mode_valid(struct drm_connector *connector, > u16 dsc_max_output_bpp =3D 0; > u8 dsc_slice_count =3D 0; > enum drm_mode_status status; > + bool dsc =3D false, bigjoiner =3D false; > = > if (mode->flags & DRM_MODE_FLAG_DBLSCAN) > return MODE_NO_DBLESCAN; > @@ -724,6 +767,8 @@ intel_dp_mode_valid(struct drm_connector *connector, > if (mode->flags & DRM_MODE_FLAG_DBLCLK) > return MODE_H_ILLEGAL; > = > + max_dotclk =3D intel_dp_max_dotclock(intel_dp, false); > + > if (intel_dp_is_edp(intel_dp) && fixed_mode) { > if (mode->hdisplay > fixed_mode->hdisplay) > return MODE_PANEL; > @@ -737,6 +782,18 @@ intel_dp_mode_valid(struct drm_connector *connector, > if (mode->clock < 10000) > return MODE_CLOCK_LOW; > = > + if (target_clock > max_dotclk) { > + if (intel_dp_is_edp(intel_dp)) > + return MODE_CLOCK_HIGH; Not sure why we check for edp? > + > + max_dotclk =3D intel_dp_max_dotclock(intel_dp, true); > + > + if (target_clock > max_dotclk) > + return MODE_CLOCK_HIGH; > + > + bigjoiner =3D intel_dp_can_bigjoiner(intel_dp); Isn't that just going to be =3Dtrue always? I guess the logic here is a bit confusing on account of the extra roundtrips throught the other functions. Might be less confusing to just avoid that stuff and simplify this down to something like this: max_dotclock =3D dev_priv->max_dotclk; if (target_clock > max_dotclock && can_bigjoiner) { bigjoiner =3D true; max_dotclock *=3D 2; } if (target_clock > max_dotclock) return CLOCK_HIGH; > + } > + > max_link_clock =3D intel_dp_max_link_rate(intel_dp); > max_lanes =3D intel_dp_max_lane_count(intel_dp); > = > @@ -765,24 +822,35 @@ intel_dp_mode_valid(struct drm_connector *connector, > max_link_clock, > max_lanes, > target_clock, > - mode->hdisplay) >> 4; > + mode->hdisplay, > + bigjoiner) >> 4; > dsc_slice_count =3D > intel_dp_dsc_get_slice_count(intel_dp, > target_clock, > - mode->hdisplay); > + mode->hdisplay, > + bigjoiner); > } > + > + dsc =3D dsc_max_output_bpp && dsc_slice_count; > } > = > - if ((mode_rate > max_rate && !(dsc_max_output_bpp && dsc_slice_count)) = || > - target_clock > max_dotclk) > + /* big joiner configuration needs DSC */ > + if (bigjoiner && !dsc) { > + DRM_DEBUG_KMS("Link clock needs bigjoiner, but DSC or FEC not availabl= e\n"); No debugs anywhere else in this function, so probably shouldn't have them here either. > return MODE_CLOCK_HIGH; > + } > + > + if (mode_rate > max_rate && !dsc) { > + DRM_DEBUG_KMS("Cannot drive without DSC\n"); ditto. I guess if we wanted to differentiate between fail due to no dsc vs. just clock is too high we could add something like MODE_NO_COMPRESSION. Probably should take a good look at these MODE_FOO values and nuke all unused ones... > + return MODE_CLOCK_HIGH; > + } > = > status =3D intel_dp_mode_valid_downstream(intel_connector, > mode, target_clock); > if (status !=3D MODE_OK) > return status; > = > - return intel_mode_valid_max_plane_size(dev_priv, mode); > + return intel_mode_valid_max_plane_size(dev_priv, mode, bigjoiner); > } > = > u32 intel_dp_pack_aux(const u8 *src, int src_bytes) > @@ -2297,11 +2365,13 @@ static int intel_dp_dsc_compute_config(struct int= el_dp *intel_dp, > pipe_config->port_clock, > pipe_config->lane_count, > adjusted_mode->crtc_clock, > - adjusted_mode->crtc_hdisplay); > + adjusted_mode->crtc_hdisplay, > + false); > dsc_dp_slice_count =3D > intel_dp_dsc_get_slice_count(intel_dp, > adjusted_mode->crtc_clock, > - adjusted_mode->crtc_hdisplay); > + adjusted_mode->crtc_hdisplay, > + false); > if (!dsc_max_output_bpp || !dsc_dp_slice_count) { > drm_dbg_kms(&dev_priv->drm, > "Compressed BPP/Slice Count not supported\n"); > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/dr= m/i915/display/intel_dp_mst.c > index c8fcec4d0788..fd5faa5d7c22 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -714,7 +714,7 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *con= nector, > return 0; > } > = > - *status =3D intel_mode_valid_max_plane_size(dev_priv, mode); > + *status =3D intel_mode_valid_max_plane_size(dev_priv, mode, true); true? > return 0; > } > = > diff --git a/drivers/gpu/drm/i915/display/intel_dsi.c b/drivers/gpu/drm/i= 915/display/intel_dsi.c > index afa4e6817e8c..f453ceb8d149 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi.c > @@ -75,7 +75,7 @@ enum drm_mode_status intel_dsi_mode_valid(struct drm_co= nnector *connector, > return MODE_CLOCK_HIGH; > } > = > - return intel_mode_valid_max_plane_size(dev_priv, mode); > + return intel_mode_valid_max_plane_size(dev_priv, mode, false); > } > = > struct intel_dsi_host *intel_dsi_host_init(struct intel_dsi *intel_dsi, > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/= i915/display/intel_hdmi.c > index f90838bc74fb..82674a8853c6 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -2274,7 +2274,7 @@ intel_hdmi_mode_valid(struct drm_connector *connect= or, > if (status !=3D MODE_OK) > return status; > = > - return intel_mode_valid_max_plane_size(dev_priv, mode); > + return intel_mode_valid_max_plane_size(dev_priv, mode, false); > } > = > bool intel_hdmi_deep_color_possible(const struct intel_crtc_state *crtc_= state, > -- = > 2.19.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx