From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25684C388F9 for ; Tue, 27 Oct 2020 05:51:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1BF9217A0 for ; Tue, 27 Oct 2020 05:51:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1BF9217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87B436EAD7; Tue, 27 Oct 2020 05:51:21 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE8996EACB; Tue, 27 Oct 2020 05:51:19 +0000 (UTC) IronPort-SDR: PF7YJX2dyVWctiGwiniwhhiLpdR+t3eQICp9z2bbiYdYGH02+ue4vpwgPQYSaLDa7Lm104ob7o G+egRFnNFBjw== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="167249677" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="167249677" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 22:51:19 -0700 IronPort-SDR: SDd1NIz2NgVv7Feb9L4RPmeX6Lhf0kwkWYNN1nVdj8DM9xlNB7nGZK5b6MrN/nbHDoGeVJqFe8 aPWuN3AJx5cQ== X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="360632412" Received: from genxfsim-desktop.iind.intel.com (HELO intel.com) ([10.223.74.178]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 22:51:17 -0700 Date: Tue, 27 Oct 2020 11:07:39 +0530 From: Anshuman Gupta To: "Shankar, Uma" Message-ID: <20201027053737.GB29526@intel.com> References: <20201023122112.15265-1-anshuman.gupta@intel.com> <20201023122112.15265-3-anshuman.gupta@intel.com> <447146c6e1034f7fb03c57f9e35d18d4@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <447146c6e1034f7fb03c57f9e35d18d4@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH v3 02/16] drm/i915/hdcp: Get conn while content_type changed X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "seanpaul@chromium.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2020-10-27 at 11:04:17 +0530, Shankar, Uma wrote: > > > > -----Original Message----- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanpaul@chromium.org; Nikula, Jani ; C, > > Ramalingam ; Li, Juston ; > > Shankar, Uma ; Gupta, Anshuman > > > > Subject: [PATCH v3 02/16] drm/i915/hdcp: Get conn while content_type changed > > > > Get DRM connector reference count while scheduling a prop work to avoid any > > possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED > > state. > > > > Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing > > connectors") > > Cc: Sean Paul > > Cc: Ramalingam C > > Signed-off-by: Anshuman Gupta > > --- > > drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c > > b/drivers/gpu/drm/i915/display/intel_hdcp.c > > index 0d9e8d3b5603..42cf91cf4f20 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > > @@ -2210,6 +2210,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state > > *state, > > if (content_protection_type_changed) { > > mutex_lock(&hdcp->mutex); > > hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED; > > + drm_connector_get(&connector->base); > > Where are releasing this ref. Thanks Uma for review the releasing ref is present in prop work function. intel_hdcp_prop_work(). As prop function releases the ref for connector somtimes it lead to destroy the connector, if we schedule the prop work without taking any connector reference. Thanks, Anshuman Gupta. > > > schedule_work(&hdcp->prop_work); > > mutex_unlock(&hdcp->mutex); > > } > > -- > > 2.26.2 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx