From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF6A1C4363A for ; Tue, 27 Oct 2020 09:36:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 233932224E for ; Tue, 27 Oct 2020 09:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="SgiGfHua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 233932224E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3534289CA0; Tue, 27 Oct 2020 09:36:36 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67D3B6E1A8 for ; Tue, 27 Oct 2020 09:36:35 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id e17so1037190wru.12 for ; Tue, 27 Oct 2020 02:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oKyhhlggIzQZEALt6LDXbEGeExFCJKLngSO4q056TRw=; b=SgiGfHua4PGRBgKddAU9OCyQ6gEct1idFssRqSbWwjGRJqXG169x46PTmvdjQceWZf fk5dAtJxunjnhbD4rbCsNxxDzknml/sX2Srv0TepflP0Th4ndJ/+cwJxg9Nb54onNn7a SioLMZC7T1foebo0tvNh9MYDlsSqwMmR1SUDo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oKyhhlggIzQZEALt6LDXbEGeExFCJKLngSO4q056TRw=; b=Zyl7lIiUBkhZw5SSQqFcrn5JikxW699FJClM6h0tB2Of/wZ9Yz4YI/0LDMdLchw4Wq PSVU2x7e/2Rn9mBgWOklBsK/h/9i+EtvBz3BF03YANYHYJz71URiKiytpKmDMi3YG9yA M1SNB6YXD6X9NZWb5myGRxST4dFDChDxxL52zvvQCQRc4d+Z5O19+w2+fG2/n+cDCdfk j+pDGz4VRldnT1TU0k3nG9ba426nrRlxf3NWbtCcdjxeW+W3VPdEFqvygTtiNnMU/AIL cUbjmdc9gsk+t2IqbnK7gc5Gr53ghJnXyrbKFyhDCJBcPeQ4MGayLb9MLOaIFCFTIsM9 4GwQ== X-Gm-Message-State: AOAM531HoSG1rLJMXzSGLF3XKQuU0WbYbCFKG6p0v1Psf54cY1anEPEQ cu/o6nQrZclMmpb3iVx7CjQiLQ== X-Google-Smtp-Source: ABdhPJzHD8U/7HI5c4wsPD1H08r/8tFlxpBIJaaJcDdq1QoqLSTpEsPUJ2pxSZrV6BQcS2YaZr5g8A== X-Received: by 2002:adf:c3c6:: with SMTP id d6mr1782755wrg.206.1603791394082; Tue, 27 Oct 2020 02:36:34 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u15sm1268718wrm.77.2020.10.27.02.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:36:33 -0700 (PDT) Date: Tue, 27 Oct 2020 10:36:31 +0100 From: Daniel Vetter To: DRI Development Message-ID: <20201027093631.GJ401619@phenom.ffwll.local> References: <20201023123925.2374863-1-daniel.vetter@ffwll.ch> <20201023123925.2374863-3-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201023123925.2374863-3-daniel.vetter@ffwll.ch> X-Operating-System: Linux phenom 5.7.0-1-amd64 Subject: Re: [Intel-gfx] [PATCH 3/3] drm/doc: Document legacy_cursor_update better X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Intel Graphics Development , Maxime Ripard , Thomas Zimmermann , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Oct 23, 2020 at 02:39:25PM +0200, Daniel Vetter wrote: > It's the horror and shouldn't be used. Realized we're not clear on > this in a discussion with Rob about what msm is doing to better > support async commits. > > v2: Refine existing todo item to include this (Thomas) > > Cc: Sean Paul > Cc: Rob Clark > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter Pushed this one with Rob's irc-ack, since the functional changes will take a bit longer to figure out. -Daniel > --- > Documentation/gpu/todo.rst | 4 ++++ > include/drm/drm_atomic.h | 12 +++++++++++- > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 700637e25ecd..6b224ef14455 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -105,6 +105,10 @@ converted over to the new infrastructure. > One issue with the helpers is that they require that drivers handle completion > events for atomic commits correctly. But fixing these bugs is good anyway. > > +Somewhat related is the legacy_cursor_update hack, which should be replaced with > +the new atomic_async_check/commit functionality in the helpers in drivers that > +still look at that flag. > + > Contact: Daniel Vetter, respective driver maintainers > > Level: Advanced > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index d07c851d255b..413fd0ca56a8 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -308,7 +308,6 @@ struct __drm_private_objs_state { > * struct drm_atomic_state - the global state object for atomic updates > * @ref: count of all references to this state (will not be freed until zero) > * @dev: parent DRM device > - * @legacy_cursor_update: hint to enforce legacy cursor IOCTL semantics > * @async_update: hint for asynchronous plane update > * @planes: pointer to array of structures with per-plane data > * @crtcs: pointer to array of CRTC pointers > @@ -336,6 +335,17 @@ struct drm_atomic_state { > * drm_atomic_crtc_needs_modeset(). > */ > bool allow_modeset : 1; > + /** > + * @legacy_cursor_update: > + * > + * Hint to enforce legacy cursor IOCTL semantics. > + * > + * WARNING: This is thoroughly broken and pretty much impossible to > + * implement correctly. Drivers must ignore this and should instead > + * implement &drm_plane_helper_funcs.atomic_async_check and > + * &drm_plane_helper_funcs.atomic_async_commit hooks. New users of this > + * flag are not allowed. > + */ > bool legacy_cursor_update : 1; > bool async_update : 1; > /** > -- > 2.28.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx